From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A153D24454 for ; Thu, 10 Oct 2024 21:17:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 01AAB6B0082; Thu, 10 Oct 2024 17:17:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0C626B0083; Thu, 10 Oct 2024 17:17:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD4146B0085; Thu, 10 Oct 2024 17:17:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BE8D56B0082 for ; Thu, 10 Oct 2024 17:17:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9A636160C5B for ; Thu, 10 Oct 2024 21:17:26 +0000 (UTC) X-FDA: 82658953818.30.9C49FEC Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id 3461B14000F for ; Thu, 10 Oct 2024 21:17:27 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=u+N6SE9K; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728594897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cLqazrdIOZWkwfMyVr4Z1bynrjhwU1UnouWdWu17BMk=; b=NScvpcLljc+XGkqqHd1c33BXbW6IJO2F7yBQP9tHz7pU6jO9E+LvOBsryIYqxOHoFqOAeT bhRi1ch/t4pc2OmAmRkF8eCdBtCuTJefNwqcK+4gRNWLB0vspm+XGLvyJi+eVcmMklpXyx Ubn1bS9rApU4CLf4fqYq3Wo/aU1UTXU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728594897; a=rsa-sha256; cv=none; b=Pul6GPEWelo5X1p1i1KqBlG3g90WydwoQca69NNhJN+nFiJVnlx5istopvCvIMN89FV0nw t4AlOqn7/E2JpGNTRQb3QMJDbBY3o58UlIoNWHbBh2qudODNN11fd+DLcwS1E7iwhL2RyC OrvRPD6ksBR+PmRssI3QnSFXVe9glJ0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=u+N6SE9K; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 386C3A44C47; Thu, 10 Oct 2024 21:17:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D5E3C4CEC5; Thu, 10 Oct 2024 21:17:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1728595047; bh=h/ydTxkvMIlJ33x8vbPMvRfe6S+g8mbXshs+rjB07HA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u+N6SE9KV1DUPMTlYZr52oPJT95+GVQ+9eMki630RwTp8kd6oyeSyx7OYwJdTo+/J efQmV5A3cfJNTaGTPx28R5XhtznQN8gDcMin5sT135VEZovhQ35XSprj5QAHr29wLu C2B6DgmtdPUKMvcKW2kCTxZojIrUW6shfV3sSR4k= Date: Thu, 10 Oct 2024 14:17:26 -0700 From: Andrew Morton To: =?UTF-8?B?6auY57+U?= Cc: Frank van der Linden , David Hildenbrand , Xiang Gao , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: =?UTF-8?B?562U5aSNOiDlm57lpI06?= [External Mail]Re: [PATCH v2] mm/cma: print total and used count in cma_alloc() Message-Id: <20241010141726.0bc7b9d0758756249efadc3a@linux-foundation.org> In-Reply-To: <5de41e1999414426ba88447a4d95db18@xiaomi.com> References: <20240929032757.404707-1-gxxa03070307@gmail.com> <2a7b7fc3a48d4bb9a6394e51af074017@xiaomi.com> <20241004153947.43c5b16b7f75b0f60e918019@linux-foundation.org> <5de41e1999414426ba88447a4d95db18@xiaomi.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3461B14000F X-Stat-Signature: 18hqnxkbnd8pqor9emzjwsss37ifdk6k X-Rspam-User: X-HE-Tag: 1728595047-591300 X-HE-Meta: U2FsdGVkX18NdqReOsblHArchtZaFgY672mPel6bhq09uCFqGtzjq04XUtlRqw6pLzWo6SxOfGa5Rp3Vi3+lwEvaFAXSPS194pIkKCTd+zBd7UVMpM/zFv7k5VYTL27YojjF3mgTAmolIFPw0gZl01NGjwXtBNQi/u/VcsUDAaGUGIfkziVoTaOIwCaY7GAvktxHXbjbeif7fYQdwsvy12BW4KRrgCu6+3eYaTfAmYOfYKk/jXQSwY9Hc6WPvIDYVVEnb7QY80xTP439GU2cDMa+l6uJgeynWGME9LQScBGeeIiiyBZwcpeUEWbTPDUNmp+ZcchqdFbPA7aOsIVsHJM4UMgzx80ITIjFejfzVjbmC25i+tmqH6FAD/SskFrdBlZgcEOt+UE/Is23ReDc271ieIzvHkpU267cdBzxOOeZhQTwFsulaWq6f3cexsSRgFAx7OMDp7elrXeNgfgO54mO5nVTGzmTzTY2Xk1+e5lYugUiwoHRmwSYCz+JBp565BgS7Nq7GNER/9dChulMsOhqdOpmk37PxPvV14Mate8Ynt3ySEIbEADGthTUpAkeOef5UA/1LrcQYPqWsnpCWjSsUkXri1NbS7L0Rc3ciCTddSFFPRhYDCyWB+5/rIr0BSNK5PojXZKIjHjW3Z/ceupZci88aROqNo3LYawElK5VY6cxTHvcygS+P7iOVieYcSEO63P49F5q3452uzAEuok33N1yjTZjOrDZiOiRq7JZdhKbQzRRCwEoeDe7qNXRk+/rETE5AYwO5hRkEFDr/1YKTFfpXP4eW8mlaxaUq9XIDdTrlUuqVGYj5gnlIMjlL5HFEX+X1eSoCaolZHhnolLJbTOE87eg9hnYKCmKd8bVndUiAzwyGmbZ7qbnK2G13vNCI3PEXhzBFPaclcMIZJ84tbtt8YhJeh48cggFbamCCwV0d3ND0tlT8mRRwi11G2p7Xtsl+V5pz6AJflw nu26FX+l 4EVfda2BxhXrSL8johms+Xmsxg63g/h7xtlHJHYugnApT6j9fwTey8cu7gzsZTybJLEN37QLZsFIaGnA7qT6k7/X/hX/mVy1we1v4VrNL4A357dV8sW7cJOm+ky5iSxAs+wjXM0y/ESCYR/vYMhgMgbUtQcMi+P0e0b3rUInUjfDwFDOG2ALXDSjWYTqKvDuM02u0hstdLGoiySm5H1sRcztyq8HHf+xQBL760i3zWwy33th+U1wGl70zrYlJaDvTEQqCV6iNWYRP9PrZwkxSC1zUY78btPFwYU1b40xLY9OdQxetRUUA++sQ9brNi31onsL5XhvEkcp6DiCnJe/X2GDjsFdJx/E5fFsvEqAMPy/gqPb7lPqK1SAYj8L0uavmNtmEhnrnTp/NamJG3BmIMyNd34JmYgHNNGfCjnByRM67wErBYlJRo+11ALMVjvc/4pxHXjmnkqdISGKsX06+kFROVizld4P26nzzDBXs6ByLE1wzVuf6tJIw+5+/0IP+s3tzzU1tqUyZHYjL5ea/ntw/dDZ1o4wrSeT7KQJIw3wQXaGv3A9LEpK9PumKAmCHy3MvNIFivFaCZoHOS2r+uwWEK7KgOQicslCc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 10 Oct 2024 08:48:55 +0000 高翔 wrote: > > ________________________________ > 发件人: Frank van der Linden > 发送时间: 2024年10月5日 6:55 > 收件人: Andrew Morton > 抄送: 高翔; David Hildenbrand; Xiang Gao; linux-mm@kvack.org; linux-kernel@vger.kernel.org > 主题: Re: 回复: [External Mail]Re: [PATCH v2] mm/cma: print total and used count in cma_alloc() > > [外部邮件] 此邮件来源于小米公司外部，请谨慎处理。若对邮件安全性存疑，请将邮件转发给misec@xiaomi.com进行反馈 > > On Fri, Oct 4, 2024 at 3:39 PM Andrew Morton wrote: > > > > On Fri, 4 Oct 2024 12:23:30 +0000 高翔 wrote: > > > > > > > +static unsigned long cma_get_used_pages(struct cma *cma) { > > > > > + unsigned long used; > > > > > + > > > > > + spin_lock_irq(&cma->lock); > > > > > + used = bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(cma)); > > > > > + spin_unlock_irq(&cma->lock); > > > > > > > > This adds overhead to each allocation, even if debug outputs are > > > > ignored I assume? > > > > > > > > I wonder if we'd want to print these details only when our allocation > > > > failed? > > > > > > > > Alternatively, we could actually track how many pages are allocated in > > > > the cma, so we don't have to traverse the complete bitmap on every > > > > allocation. > > > > > > > > > > Yep, that's what I did as part of > > > https://lore.kernel.org/all/20240724124845.614c03ad39f8af3729cebee6@linux-foundation.org/T/ > > > > > > That patch didn't make it in (yet). I'm happy for it to be combined with this one if that's easier. > > > > That patch has been forgotten about. As I asked in July, > > "I suggest a resend, and add some Cc:s for likely reviewers." > > > Indeed - I certainly wasn't suggesting that anyone else forgot about > > it, it's up to me to follow up here, and I haven't yet. > > > Do I need to resend it after adding "used_count" member to the "struct cma" as V3? I don't know what is being asked here. What is this used_count? Some other patch, presumably? Which? The preferable thing to do is to send a patch against latest mm-unstable or linux-next.