From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF84D1627D for ; Mon, 14 Oct 2024 14:42:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 235D26B0082; Mon, 14 Oct 2024 10:42:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E5E26B0083; Mon, 14 Oct 2024 10:42:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AD936B0085; Mon, 14 Oct 2024 10:42:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E21E46B0082 for ; Mon, 14 Oct 2024 10:42:47 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 049BD160F8D for ; Mon, 14 Oct 2024 14:42:38 +0000 (UTC) X-FDA: 82672474038.20.EC548DA Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf03.hostedemail.com (Postfix) with ESMTP id 73FE620009 for ; Mon, 14 Oct 2024 14:42:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728916809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=acCwe8Rf3x/gPmAb3177O8MLPO1QFv+fMb05TvQVrQo=; b=pVHRa58kQ/O4nBEYy6L4rI5RAEKB0MUM4Ymwg4hx9Oa1oK6+tlgzQbaYYGdNyePr+44noo xIdG6iceVjSY1kbKzjGvJa9lHX2JZvymbZ5ngbYPSi8lxJPJ+COa83LxAZOI+7aJ0RmPHb nrUaxtRZE0bjA+s5Ha5CnurpHvAGW8U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728916809; a=rsa-sha256; cv=none; b=gV5j1d7qpGgoCqKT47O6rEyoDZD34aOXqBIrH7usrBy40klIy1vhoxWi5WUU/6xQCWL2b9 vJYOceealZj0gHPqo2Yz2+9aXciYbSpaZAZRTrLuouIseyhtZZBVbae0soxSysHskg9cRp XfnSMBya1MvgXvxiDF6ON8f3Q7Dayj4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XS0KG6Nxwz6GC8c; Mon, 14 Oct 2024 22:41:06 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 8F831140A77; Mon, 14 Oct 2024 22:42:41 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 16:42:40 +0200 Date: Mon, 14 Oct 2024 15:42:38 +0100 From: Jonathan Cameron To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 05/18] cxl: Move mailbox related bits to the same context Message-ID: <20241014154238.000055a3@Huawei.com> In-Reply-To: <20241009124120.1124-6-shiju.jose@huawei.com> References: <20241009124120.1124-1-shiju.jose@huawei.com> <20241009124120.1124-6-shiju.jose@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 73FE620009 X-Stat-Signature: ferwgiggun3rpi6gyc8rqhskddp89e3t X-Rspam-User: X-HE-Tag: 1728916962-561277 X-HE-Meta: U2FsdGVkX19E+QRDS3ZdEosS3zCoDezA9acIz+IdWlk1Jr+ltRDozMfBRUWIJEd3OcBlQrOBwufRFlTKXmYVe4X/I0WLddCs3hX4RDofpebnQqDrqFCQ52aIWNGwNeWfowtm/cIm8L5YIlmF1WZvqowzGz5P+zz6nFUI7EYtmxxa5VM9UWufGMq/jhggcHuT/IU1LbIK9pdOTEOmkK9q6pq+tTgzob0FExcj9PWp+7Bbt0awINM1674eu2xdF+9LfEmrrwPGoh0RGF0JJ9eGHIx04RztaSNjS7WJQzIBbu3LQ0CgBMZs+hzoNRTTdasvLJvq6eYUMhfINuQWGJKpd3FGhjNPTRf/IY4hCQEsEE3US+Uzb+N3z3Nw1fAefeaKWpjsCimy8JoNrdUQ38uPoMaxvHUL0LFz9B1/JTjOsFfuJ8rQTsMpY9Vz4sbO6cC7HL62lGXR2HyG6835n+eSu6xErI0SKprt7K5s8uLliRMM2o0qonILrEZKX7uiSlvL7LV4Q7UkC1y9J879nUgg22KL/2QrpYJfPDT82CSRxLLdAU85Pi23BECPKRFIb1yDmYSGEJXFOVhHzBhh3N2IJqD2Dle4+kBpkzsAqeqWQ03TSxcKIkEWC5SC8GTlkV8cSqgoxL9NhRtvL03IFK5dxTB8HjLHnxsJonKAR+9BNpNU7JzdceG+jRsrsEcif3/TbtulPnDlkySr0NYM6NBXUy1YG3nSWTSMYLFsC3cWyng/QWqDPQ/IkI7xAUEiIpLIr6438RjS1tQcOO5By4RLVIN1EEPr/kBAs/xanoSvrFq386hvfF/LtLg7AWqkZvu7GU1c5J5vs0UyuWOLBiCZSvGedB5aalWeHLKCo5J0n8i3OkYV8Z9qkQsQNQGY6J8axac3nZCWscnXux4FZFLajACxUVG7SZ7r0cVttKwXNAW2WnE4878qRVzhhrMgdKfrXzgMIWOy/AAhuKCCtKG iR4qH21T IybLX2qshBTOQ2PkzdlI7NeH7eG4OnLJP6OfuCQn9PM/1bOGJVWt+6HckFGpQ1wZJK1pXIMlThdhrwYqM6twFT307aH80asceWX5iYdiOkiXfgbWeooBmL9j2DzTiHHPeKhmmji0jRetksD68AZj1mrdp5ahs8zFyI+r/sBqBcCKSIe10I/cyz5TJLAWi82Wno8tvCVO2zCtwQEuzsg9lnfQwOj3nKu79LdAYAeYT077LNmorpuh0udCmrrM+Pd1GY/P7yA4MSgiCM+uso/zdX4ys76rDGvvECwu1ZQ1Av93Z9mvAuvnFZvtoBapDtspJskEQLMmuMyi/RpeBGz2FlVXhn7SrFFEKkivkEpb+0PgoJ8VIbVyWji4Wtn8RhILWpbmkCOAbZCqVLZkwueypKMJ9DMZE72D/b5SaQ5LBWM257WwpCan4c4Mn260BAwDagjsvKtfAP2MBtfk2gfiDq7n+RgHWCNpZU4eI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 9 Oct 2024 13:41:06 +0100 wrote: > From: Dave Jiang > > Create a new 'struct cxl_mailbox' and move all mailbox related bits to > it. This allows isolation of all CXL mailbox data in order to export > some of the calls to external kernel callers and avoid exporting of CXL > driver specific bits such has device states. The allocation of > 'struct cxl_mailbox' is also split out with cxl_mailbox_create() so the Ira called this out in the v4 posting from Dave. Change text to say cxl_mailbox_init() > mailbox can be created independently. > > Reviewed-by: Fan Ni > Reviewed-by: Alejandro Lucero > Reviewed-by: Alison Schofield > Link: https://patch.msgid.link/20240724185649.2574627-2-dave.jiang@intel.com That link is to an old version. https://lore.kernel.org/linux-cxl/20240905223711.1990186-1-dave.jiang@intel.com/ Is what you have in the cover letter change log so needs to be that here as well. I'll review this on Dave's thread rather than here. Dave, we'll need a immutable branch for this one once you think it's ready for queuing up. If we can do that soon that would be good as it's either gating this series and is a precursor for the type2 stuff. If we are sure only this stuff will make the coming merge window (crosses fingers) then we an take it via Borislav's tree - perhaps we should discuss this on the sync call tomorrow.