From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F1F8D18123 for ; Mon, 14 Oct 2024 15:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15B7E6B0083; Mon, 14 Oct 2024 11:12:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10C186B0085; Mon, 14 Oct 2024 11:12:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3C006B0089; Mon, 14 Oct 2024 11:12:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D19E36B0083 for ; Mon, 14 Oct 2024 11:12:27 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F353FABFDF for ; Mon, 14 Oct 2024 15:12:11 +0000 (UTC) X-FDA: 82672549008.04.F845975 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf12.hostedemail.com (Postfix) with ESMTP id 6BAEF40019 for ; Mon, 14 Oct 2024 15:12:22 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728918589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gWVeKlsgjI3JAUswKjmuw2/AGOY4Dary5paT69/HM04=; b=ttN2p/aflNX24woYMZcbo5D/XtLwnISda/Lt0Xcx7on3q+IlUk4xRsEP5OGwf/jXelCYYS 3Qjq3A7lns0kdWvoYqxdK0uAvLq1nJUKFKOqcbTCYj8cQPaYSdC/Vo2s+Y+tJ4UHdL5Ozp nTO4CcQUFmPUxCi5LGn5xzx+7FrLdBQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728918589; a=rsa-sha256; cv=none; b=NGudNPaivMS1S67WUEyO5P1rIECoUmMTEKJS40EizJaK2gFPGuBbeSL3jdrDbynodwcB3L A4fxLFWzUC2fo7slrXP6BAmkiiJ77u19WTTvOeXVpQ4HgS+P9z8IrpzPrX8IbUvmhId4e+ xj2amWCN5YzgpaHFno4A/yWXHZbJSRs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XS0wD2ppYz6L9F1; Mon, 14 Oct 2024 23:07:56 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id A6C731401F4; Mon, 14 Oct 2024 23:12:23 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 17:12:22 +0200 Date: Mon, 14 Oct 2024 16:12:20 +0100 From: Jonathan Cameron To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 09/18] cxl/mbox: Add SET_FEATURE mailbox command Message-ID: <20241014161220.00007e5b@Huawei.com> In-Reply-To: <20241009124120.1124-10-shiju.jose@huawei.com> References: <20241009124120.1124-1-shiju.jose@huawei.com> <20241009124120.1124-10-shiju.jose@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6BAEF40019 X-Stat-Signature: o354twoim7k7cjizbc7x81kbzmhwqgdy X-Rspam-User: X-HE-Tag: 1728918742-735696 X-HE-Meta: U2FsdGVkX18R3fyhnBmpYI2ROo7RxYE5vUlVvzN4V5CVI9Sp2dZMqvQ0uZBHwa0m/KzjQB9iykucwK1FS5NSpc9jCXM7tPoE2k74pcTMobVcokGuHd0LIiIhLy9jq1SHhzdo17xyvebME/USyBcG0sLLhMhevrLkAmdgKJO4SnWnTyq74K+WGAesNEKjViXtLACl7BGXz2ixB5L/E10U8yHfg4gwU8klI8TwE5Vm1FLVfQXRPm7x6AYTr8w7nYP22ctsL/sTmGuqeQJLfXS/urgofcsPWiQBjEoLv1jecFGZddJQ9sUr6iuK8i/A84uQIIFoyvF8aT77b3idXn1t1zYHSkdwHgW6LM5NaUrt/FatlT0eNi+w+/whxGUdMyzcwmKg4YSFQwQjU6miMVnE+EBKbqa2ONyznI32OYIQDLZsREdabTz7waPELH57B1/8Cn9OSgb7qBlnDWmYQ5qo8wFWy4i7ie7wUygQFCGzHgIh08B8rcPOWJmcNrk4wkHv/A9dxWPZGEXzFEai9uyqGa/wqgzMCLEdGZ1OpraPK9fnzTEKxxdKK/Zx+PTBP0JITaeMBAX5FQzGkFOJmKB/7xrEEifc2P6K28DXh6xz8cZ27FKVUfFohX8Xhz4PiT2xP5Y9BxsLUpVrc0I0Dpcez8CydzX0wY3YQiwEtXL+p6ktM3MaDdQAPuWtFaFmt+jkkMkVEiyT1vXQtRakOCj2Df4OfCxfhpDJLCwcBVI+UFRdYeTieC9YzWhraGzaTxCMg0eFgNdsGNQl27SI5Eta9ucpaprYoa76HlnLoEUk6ZZyH/qVMaoPD0iU1PAmjykDCSJ5s6lLD+IBMAfypB6WLmt7CbQqYxYfddY4B5dfVPZfksNgarw+n4ZNHWKE1bbMJOBWTUCvtd2k+NFBHQeH49fAy+E30Afi+eHmzXJtzJXTWv9YnE0cON2QxGA0XMjfEuLJhpLZts8/NodVQiV 6y2oo16A 7tDRDLFRdUZwgHqRg+bRKZwmiL8zlBhNELj15ZBLkSAo/5ZIR2tl5M+zZojE9Rkop/ySg8EbcOevG+rCw5tsIj4manchWGiObb6oJxnsxwJmVZNA0QByUVyIIQFsrx5Ot85e4oXuaWri5CY1n4p64U4CI7lrSFLkt1XZj7HlfetSuKyfRCPPfWqF/yk5iqPvhG5L5wZ+iNj4m3gWPjlBZ4JnTGTmaOUTVGW8WTrQhI+Rmyf8k6lDHyLpxa5nxSIeZUzbZgLQiPyV+E/cTRIrP29LAVZLTZf+NUy0qT7SgQljRGYWWomPpQsIGexLGssEP2DeuE4Eh5G4LJKlmg5JYeVu+cyPknRC8R6PSX8N+tWtlFoh5ccAcb7u89FbdX/j9Gt7T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 9 Oct 2024 13:41:10 +0100 wrote: > From: Shiju Jose > > Add support for SET_FEATURE mailbox command. > > CXL spec 3.1 section 8.2.9.6 describes optional device specific features. > CXL devices support features with changeable attributes. > The settings of a feature can be optionally modified using Set Feature > command. > CXL spec 3.1 section 8.2.9.6.3 describes Set Feature command. > > Signed-off-by: Shiju Jose LGTM Reviewed-by: Jonathan Cameron CXL reviewers. I'd like at least one more review of this one simply because it's a core code. Fan, you looked at v12 and pointed out a typo only. Could you take another quick look? Thanks, Jonathan