From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 091C2D18131 for ; Mon, 14 Oct 2024 16:26:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 808F86B0089; Mon, 14 Oct 2024 12:26:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B8836B008A; Mon, 14 Oct 2024 12:26:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 680626B008C; Mon, 14 Oct 2024 12:26:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 47E776B0089 for ; Mon, 14 Oct 2024 12:26:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7B6A6C1088 for ; Mon, 14 Oct 2024 16:26:09 +0000 (UTC) X-FDA: 82672735026.22.7A465D5 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf30.hostedemail.com (Postfix) with ESMTP id 2037280008 for ; Mon, 14 Oct 2024 16:26:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728923035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LEe1QDlvd9sjqvNezKKzkALfA/RJxcdNLItYcqZ/hCs=; b=1qs3izfuwt/mgQGI5apy3S1XYgUVgMCTFBQMjOWKMTEGQT+gulTD3jP5By8LPWk177wzS6 lPH6+r/3g5QEuBrLQx6MsRxYVMNo2JOtlUQgJt2x+BwYcI4svRHPyR4xL9BqBwCit9Lt1w GjNv1fGkgtE5EElP+Ay9+pVd1kbFXdg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728923035; a=rsa-sha256; cv=none; b=vaJSzOF7QAcczPV9B62c04g83hXGS8YMQd8lBSEp+tZYw88Ne82nR17acZBx0VxFfcUiak YI57DwVWK4PPgjEkSOOEjom80zrDqJRRpKsO//PwKd+VVah02iuzgK7xPr0ydDkWhtMvUE XTsRaGTGZRFD+rRQcTHwFKm1o0pG9MI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XS2cg3dG7z6K5Xl; Tue, 15 Oct 2024 00:24:35 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 76EBE140B55; Tue, 15 Oct 2024 00:26:10 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 14 Oct 2024 18:26:09 +0200 Date: Mon, 14 Oct 2024 17:26:07 +0100 From: Jonathan Cameron To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v13 16/18] cxl/mbox: Add support for PERFORM_MAINTENANCE mailbox command Message-ID: <20241014172607.000066bb@Huawei.com> In-Reply-To: <20241009124120.1124-17-shiju.jose@huawei.com> References: <20241009124120.1124-1-shiju.jose@huawei.com> <20241009124120.1124-17-shiju.jose@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Queue-Id: 2037280008 X-Stat-Signature: 86bhtg8z71mgrkjb94u6rjaezoj8s9rq X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728923163-793858 X-HE-Meta: U2FsdGVkX19hlr834GiCMLpBXjd/6A/XYooS3dfcI/jakxMJpI7hoBC0I42B6t4tBF6RSTDBg8O0SMpXqxGEKoIgPBh9S3EoeShxvbVRAxG7ObmnvzdTyE0BcF7XtxptG+Q0W48YZtfl6uruoGiM0g88G85kxkxyrk4/CfMrxMEYtmq45IkNbs+N44j4V8c7oOcxcQP20vmq+GgEx7hHzL2hwQ5ijEpdYIb02IxTiwXe2gKn7K9WIP7EVfpWOsamrY8EIexaD0YX7bwNXGDCxYijvOaS6FuWrMkgpVntMtMQC6RDrrFNyMVFdQAyBQ1iu+XwJpmLb5DTIiugsck1vzXcPXCgJNtMNTg+SXqSKEMOAeOgA8qNwgGz+z/5EteSBWy4AftdKWjkFRYp0l6T0sU8kMxj6vn/IPYYATbae/j1CghpSzDo4NZZg94uCDlELQTZhfKsyINiRgar5ax/B+6q1ndd7obp+H7SWjWRWuu9gRE4R88OGwBb1+CHTKt+f43c55eLERbKvnGF3zdE8kV+OXsQEeQteX0sIZpGQ4Q2+VmFi9RvHjjtIOw+gAsE6waMV1qY1B+x7MZEzXcWKxjd/QAxbgUhEwQbIMp+NlgP5e7+YktOWtzkltqGfm/fo1+jqwCNeJeoVUPv+zhUdYzLwEJHTPhLBww4iBkMlG/JYdN2DzD8dlGmGQcCz8xb9AyEspGK6sCAMKMr2hhafciw+cbKsXLuIJYAzv2BOLWu+hWZdTYZAhJBoyu/yKpPcXYN9FU62R8VWJrmdV4AVk6JGlJNmZouc9q8FZJAiyY8Az0XO04PZSVQR8fCqVXGYw5l9OpIHtK4hWHK8gthUpKzDO0ISG0+IpJG6VKgpFb4XsfKfgvB9sngxnlOCAW1bxvpy5wnD4QmU8QfBNOnNgbqNOzEAOvPX+FO0t3I3WxfuZF6riGodEI9DC1/58MTLydaChWmLyQ9RUWxeyJ Mfm/PiY0 lV8ShVdXDckGMS05phnAB3wLNdSYXJd+1/vI5vUEftXRFGzigX+KgX91rWy/PNOL0SNic8iJScotsJx9lAa/ZBCjs5x7av1v918A2YrCEeFvicBJ4S1lZ11156jk2BdZ6vCl9vEDUOidi3s4mh7aAzHDxx0BecX/vtmtuG/OC9ev5lkm3yWUlKIXDCittBgU/tfSWy4Olrctnachxk69wrjwFQudSmpmAVJI9bzpXkoMTP/RWiuuf86VSm/sIK7nQ2FCYjHqiLAM+bLLNtHQOdIJHRGLwZQFRnOXCripOTQVcrOAWtIeecxs+FwCDBHun4NzcSM9RuCx8djKl/+RZarjVZFqj4P+Xv9kEdOFm69f9BsvBPR1ZHpztbtT3dLmAN/qe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 9 Oct 2024 13:41:17 +0100 wrote: > From: Shiju Jose > > Add support for PERFORM_MAINTENANCE mailbox command. > > CXL spec 3.1 section 8.2.9.7.1 describes the Perform Maintenance command. > This command requests the device to execute the maintenance operation > specified by the maintenance operation class and the maintenance operation > subclass. > > Signed-off-by: Shiju Jose One trivial comment. With that tidied up Reviewed-by: Jonathan Cameron > --- > drivers/cxl/core/mbox.c | 40 ++++++++++++++++++++++++++++++++++++++++ > drivers/cxl/cxlmem.h | 17 +++++++++++++++++ > 2 files changed, 57 insertions(+) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 30c44ab11347..a6f69864c504 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -1084,6 +1084,46 @@ int cxl_set_feature(struct cxl_memdev_state *mds, > } > EXPORT_SYMBOL_NS_GPL(cxl_set_feature, CXL); > > +int cxl_do_maintenance(struct cxl_memdev_state *mds, > + u8 class, u8 subclass, > + void *data_in, size_t data_in_size) > +{ > + struct cxl_mailbox *cxl_mbox = &mds->cxlds.cxl_mbox; > + struct cxl_memdev_maintenance_pi { > + struct cxl_mbox_do_maintenance_hdr hdr; > + u8 data[]; > + } __packed; > + struct cxl_mbox_cmd mbox_cmd; > + size_t hdr_size; > + int rc = 0; Always set, so no need to init. > + > + struct cxl_memdev_maintenance_pi *pi __free(kfree) = > + kmalloc(cxl_mbox->payload_size, GFP_KERNEL); > + pi->hdr.op_class = class; > + pi->hdr.op_subclass = subclass; > + hdr_size = sizeof(pi->hdr); > + /* > + * Check minimum mbox payload size is available for > + * the maintenance data transfer. > + */ > + if (hdr_size + data_in_size > cxl_mbox->payload_size) > + return -ENOMEM; > + > + memcpy(pi->data, data_in, data_in_size); > + mbox_cmd = (struct cxl_mbox_cmd) { > + .opcode = CXL_MBOX_OP_DO_MAINTENANCE, > + .size_in = hdr_size + data_in_size, > + .payload_in = pi, > + }; > + > + rc = cxl_internal_send_cmd(cxl_mbox, &mbox_cmd); > + if (rc < 0) > + return rc; > + > + return 0; > +} > +EXPORT_SYMBOL_NS_GPL(cxl_do_maintenance, CXL);