From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C15D1813A for ; Mon, 14 Oct 2024 18:21:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 464346B0089; Mon, 14 Oct 2024 14:21:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 414AB6B008A; Mon, 14 Oct 2024 14:21:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DD006B008C; Mon, 14 Oct 2024 14:21:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 104656B0089 for ; Mon, 14 Oct 2024 14:21:06 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6AD5B1A11B5 for ; Mon, 14 Oct 2024 18:20:51 +0000 (UTC) X-FDA: 82673024364.11.751764A Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf28.hostedemail.com (Postfix) with ESMTP id 29B2AC0002 for ; Mon, 14 Oct 2024 18:20:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=eaNHFEKw; spf=pass (imf28.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728930016; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+15fU+vlFJXlfWNo5SAb6q/LxbDR71Q4LmaLqoFoAZY=; b=H0Ru+jo8r9QIWAbY9Yt8djXBJm/s0PcjDNVB6SAhpd9HUkl7M4Ggyuy6Nsc1FpCwILxS0c y586bPLvnAc7LhoETdzFzIU4dTN+g8HxpOkRbKC+QU0y9lxrGGB1+ngV3M7rb+NoI6UZSj lNva7qmTlVPGpPBi2iEnb9r4qy2oNl4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=eaNHFEKw; spf=pass (imf28.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728930016; a=rsa-sha256; cv=none; b=jY7i/QsmtN9MMBJI6HdduvipcZ2+iePl/qTg/2jSssNnWeQRXIC0o+/cBDqYJQYfymotEE 1Dq186Obfl0TkZ6TIPRIoeD0C5RfN3DV4UfFQ6yK0B9O/NILOfvh8MSRI0OomF6NGBaLGz WywlIL5zbfqTEsrx7HqObT7vwV3+GLE= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49EHLkwT026660; Mon, 14 Oct 2024 18:21:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=pp1; bh=+15fU+vlFJXlfWNo5SAb6q/LxbD R71Q4LmaLqoFoAZY=; b=eaNHFEKwAne8T5Hw2RuPNhr4IuZPqpuAd6PDLZfd4W2 2ua4t2Ns/mhAzdVfGH1rRTanXrr0dHqRIuF0H9ZxSHZOqN1Xfde3r3RZ7en+j556 bxhS46+2O1W1jb7yuqKmrCOeiVLZqE/C67SoUeO5ljNQN1QvBuCvLr2NrJg2PDiZ GBZZI7k6w3VtsDNQWHd9fjaOTVR5bN6Vrnw/S0XnP3IjpKEgCGXFHXUGhibZ65// 8TuT+jehc8jqB3j+eLVnGmZLr5gxblfETosLAxM6HUAx3irF9x+xv3ODQ4tLz2YT xYOpZjaLAgQtQIbJN+RBvkyh4FOfMHPDIcVlqSbmUzg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4297mh07ww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 18:21:02 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49EIL1KV023177; Mon, 14 Oct 2024 18:21:01 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4297mh07ws-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 18:21:01 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49EICqoP006757; Mon, 14 Oct 2024 18:21:00 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4284xjyumy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2024 18:21:00 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49EIKul654788570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Oct 2024 18:20:56 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B54FD20043; Mon, 14 Oct 2024 18:20:56 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B980620040; Mon, 14 Oct 2024 18:20:55 +0000 (GMT) Received: from osiris (unknown [9.171.66.174]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 14 Oct 2024 18:20:55 +0000 (GMT) Date: Mon, 14 Oct 2024 20:20:54 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero Subject: Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel() Message-ID: <20241014182054.10447-D-hca@linux.ibm.com> References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241014144622.876731-2-david@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ZNrF-vliafvsXTZlHD8cU1V8rNPhMb3U X-Proofpoint-GUID: bsGZDluyQp-DsQa9Pp8zZysEnv_dnaq2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-14_12,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1015 mlxlogscore=388 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410140128 X-Rspam-User: X-Stat-Signature: frimiy7qmnfzj7wsqeghbq69sqp1hehp X-Rspamd-Queue-Id: 29B2AC0002 X-Rspamd-Server: rspam11 X-HE-Tag: 1728930056-180989 X-HE-Meta: U2FsdGVkX1+CvLAvUkSFYawHCcFfKwD5WhavRIQBH0VkYjYcfnNhVhByD4mbkA2GF+HKcjWwfXOrvTzbiFoqPnQ+n1531dpvKYh89CsMLmP4KbOtDfCne2S59IKHjEL9d+nqLgvwG7JqRF+O0mYx30yBXNALGakVi7K7mzyBu9wYAcur4Bi6q4UNla/k0+qYrUNDXcEm3iIX2i4JqDulzQMGCDPDCpuAT1/AG6x8jzw0rI9wtWtQEtOs/WEgpioxeevWaUmQRGmNf0bLOCTOlI266NSN484veJC2GuY3M32M8RLqlraLSB9LSHVlfXXQOqcBgGQh6+DhVyVPO0LFR9pJ70vp5dNr1phfNJArxQ0buZha79XQ3vpwyARndMn5ty/Mxhg10voH8uiKUtQi4XDIXEzmXKOwIL3yoCrmpRWLOb6x3CFLPRQAtKXeIPzLN+c0coXN91KfpiLoL1yZgz8mQMfSlLHS0hXC5oxIeQUkJVvGAOlIKdhZeUGWLBl4ttzq5dLKMECNkE1ZI0c90fAU+OI/Wx43dc/pVMjiD8RUbXe11BzU3sIBMllmNgDTnJaA7IVvt7Lu7diix6U4edC68Qz5IL9M9qpdaOWaoy6A+lx27+ZygG+X18qchzMZHdqBb0I6YTX+HZUz8Og69FYnvfIQuxKr7rIhCm3RJEwNYOytMfHty5dJLcPOYyb1iOOiuUwTyWJVD1piJKpN5tU8KhTTUtWpJbvpz9KX2ZWoQ7Bf9GU/kk77NPc/l8v4R265y+Rmi6PixtwWqdBtkHLi3KlNhy9M+qdoSIMupCN6xzvs0LTL2byL6OBvFWApNBRAuKn1EuCJhX0/X0HdV0RtFf0NU4N2vUM/0Kg+TGG9WSVagvzKNX48aX6fHbbXc0INahdsDOeRPGdyrJkn5mXIDB3Lch6z+YrMBUkRm57rFJad69iUTrmdL/kVtjrEoTzwzEj8T3100XA3jJu cY6Bsm2n +LS8hixuFVxzF9AyB6MD7Mpd2llNpSi6fKZ7xJgfQWYpzj8+K27eYg82OS4N9+y2F4fPr//UatcYC9TYJ+RNrBi0gXAJZ5JB2S1Cc2ncxk2Gv01eBk2+H8gz6W+gj1Gs5pHUu2q0RYV+Oi1HY2NJVnybCjvqJq3bPekzGw4U0Y0OK6GkDEqAnNEv28ZLVwPkN3XdYVM6EfDCkQwMn86ejB2dFgQ3uCeLElfS2H+xOrXlurYZy2SQUTOjC5WH3ZCKaZZZItaCNWbJmZ8usa3zJ6NXWF938o31cESpOqPN9vzauXMw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 04:46:13PM +0200, David Hildenbrand wrote: > s390 currently always results in is_kdump_kernel() == false, because > it sets "elfcorehdr_addr = ELFCORE_ADDR_MAX;" early during setup_arch to > deactivate the elfcorehdr= kernel parameter. > > Let's follow the powerpc example and implement our own logic. > > This is required for virtio-mem to reliably identify a kdump > environment to not try hotplugging memory. > > Tested-by: Mario Casquero > Signed-off-by: David Hildenbrand > --- > arch/s390/include/asm/kexec.h | 4 ++++ > arch/s390/kernel/crash_dump.c | 6 ++++++ > 2 files changed, 10 insertions(+) Looks like this could work. But the comment in smp.c above dump_available() needs to be updated. Are you willing to do that, or should I provide an addon patch?