From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1985CFC274 for ; Tue, 15 Oct 2024 08:12:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 687446B0082; Tue, 15 Oct 2024 04:12:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 637EC6B0083; Tue, 15 Oct 2024 04:12:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FF0E6B0089; Tue, 15 Oct 2024 04:12:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 34E726B0082 for ; Tue, 15 Oct 2024 04:12:24 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 29A5E161394 for ; Tue, 15 Oct 2024 08:12:14 +0000 (UTC) X-FDA: 82675119198.16.083B7A8 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf08.hostedemail.com (Postfix) with ESMTP id 72948160007 for ; Tue, 15 Oct 2024 08:12:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QxPqLRoI; spf=pass (imf08.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728979799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gj2eff/gDKvrExQ0+U5SRr43vqoklI2ZPTnRHbRAPdQ=; b=7xRWdbvnapelrYdEuqElx1SGMyeH3htCp6zz1FALNMXxOI4zyuf8b+u3T9zqLR58239ZOZ 3ANYkEyJxu1fjUEQ1Ejzbf+Zwmr5rG0NtrvTTSW/FeOnOuPx8jNKLVnebmkUgsJG8N1OHE S/ALrsNLeDuSExhw3JF7+Eh7bJDq+LM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728979799; a=rsa-sha256; cv=none; b=kYiJvss+vXKhdY8ApOh7jXtVBVULBkkFYDlKqauAVRsjc1kwxkYa34uySMh1Gb4yTACdQm 29h/JTj6JKRCg0yPFgroX22xMI1zMjm8PGbuWHZUaNMGMjBO++mNMnH1ABjkPqtT832ARD eYQacIHdruh1SxysNxDWSNlb52FI0HY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QxPqLRoI; spf=pass (imf08.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F7ssVi022825; Tue, 15 Oct 2024 08:12:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=Gj2eff/gDKvrExQ0+U5SRr43vqoklI 2ZPTnRHbRAPdQ=; b=QxPqLRoIwrlhYxR/G8ca8oI31/biUBd+KcVRUQl+bDw1TC HH0nxcV64tw+3sLV/9kPa/89SCu+zeACdBBaBTk2kf9a1HyV5IFVwKBqJWl7KSlW HlZib7pCxv8B/d+1T0a34KIbTdWKHA8Fgg9XyetlgR/U2dWBEUdnnjVy//0/cLe8 +oHOYPOJpzYlrpfevjbUSWAlnlIucLRnlkoy+ltx0n7w4Ap4Hw97z/4IHVmMhJuw kWJloHTZD9a2PN3eBD7QluycYo10q/BwTmyY1MD/8ctB0eg3347YdxBaXsq9OB4P BIK9Uyjrfah1lJ6H2oNfWxp/SOS6RjC74OU4yTiQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429me102fb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:12:20 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49F88uwr021532; Tue, 15 Oct 2024 08:12:19 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429me102f6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:12:19 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49F5Sdm0005936; Tue, 15 Oct 2024 08:12:18 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 428650tabn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:12:18 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49F8CFYE56820040 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 08:12:15 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2880F2004D; Tue, 15 Oct 2024 08:12:15 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8EF8B20040; Tue, 15 Oct 2024 08:12:14 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 15 Oct 2024 08:12:14 +0000 (GMT) Date: Tue, 15 Oct 2024 10:12:12 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet Subject: Re: [PATCH v2 2/7] Documentation: s390-diag.rst: make diag500 a generic KVM hypercall Message-ID: <20241015081212.7641-A-hca@linux.ibm.com> References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-3-david@redhat.com> <20241014180410.10447-C-hca@linux.ibm.com> <78e8794a-d89f-4ded-b102-afc7cea20d1d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78e8794a-d89f-4ded-b102-afc7cea20d1d@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 2n-W7mBbZ4G_mAo1_wnkX_RTK_1WA3Sm X-Proofpoint-ORIG-GUID: HNLO0T6YpVxtKhQmcClC95BGRIIZvtZD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 mlxlogscore=465 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410150052 X-Rspamd-Queue-Id: 72948160007 X-Stat-Signature: j1iuehdk6pqx5mhxsb85dfkoqyk64yng X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728979936-862379 X-HE-Meta: U2FsdGVkX19NijnWZaldoueGRM5b9Ot4kYA6H7KPPdjyXFoBLztL/q3V+JwifrF8lHNfYbNBYMuriXgBVCJMmZi2h6yILDZ5tAwW7tJIaMhXnw8shn4KukV4Zya5ZRJdWPA/9SDHIhOmDu/RoxxEgv4IvdM3ihk9g1Ov464LNLnu9cSSSDOPyeAUoguD+MFm5i2IBgkfTImjyN7xUNyWuntS6nxcIAuSma8u5dGCzHMdWcBILiX/RMIDx/+jpTM0bn/qE9VKAS7X3/vZp+fglwHIMU0pMqhpK89H+wf5Fdnbf3mAO94Y+mNSCGscPfBsPAhof7UeuombBRqgkJYtachhIMS1DOiVpS6HNXTGG+aq9vBMA8Spfsh1+4v/A1yjLOFlSP2/ftkHWXowPaYispmyvVGu7m6KlnGQCSY+FytKYn7QdN5DmCbjOFO6zwrEgYV2nUsuAu3N5HWIes43FXEsvFgaRrc/lGgARc1e/By2wz/G31I1ilYU2VFfNQ2Hm4g2kTIE02rHGxioH3O0DZAuVbrNU+n3IXjJHty0KfGSS/P4UXQqkCZtWWm3+URiWsN4LZazB+rhLfrkTtHSAcEDnCI55uqbx02WjUsp5s5rscPOwTu4hErQRzz7DHWGzzgc4nn0jRqx0KpA4nu7KV8vRBrFTxlB//qyOaWowPo6d570LbwbgZ1JvaNZf79rixKlibejhh70zyoShpJ+C18KVoeiV+8jFrZjhP6IqGPGgJM8rntS+FV12bkUIEwouUhnyUL1RnEDWQIuV7ZLTwwwjK4a0OY9s2KoW6FM4XYGavvybHaCFOe84a9jBe98m8lfkhTfs9McrzBuCQP0H6dcTkZJOkzvV2ZGH8dPXvuDPvB1USRJC2Pvf2XJHiaQ55Rd19pe14W/yjcwtxjTnVRRkjHUtTcTydNW5q9bAnHwrWHGlnDXM8zn0+FfwpdALcIOgnjH9ujxv2rIIMK C6igY6Po SR5lZfhchqwT58WDRnu6Z+WeZ8zbyZQV6+YSxAhqANuZzMGDZVcB6J/Dzarq0SuZi14Dh7ty6JaupZ8guoITkgRD/LhL8J2LUwIM3hNTH820W9676Y80R2ZNv8BDLCla6AGBHUipwP7eCFXk2kaME+leCpYx6lMh8Xc2SEmv0MOuhGIn6vN2YtTKq/alLtCFfy/VzUlpaKh2bql1lM6XFUxP+Kxns2fSS1p4Hohw/teyhmsXW58dxeUybSzrUA+u8jinl1/DQiTnW+RCZhkdYtzWzuntOqUJLb0bGSj+W+lBsBcF+kpbypulJDjIy0p7lx4fl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 09:35:27PM +0200, David Hildenbrand wrote: > On 14.10.24 20:04, Heiko Carstens wrote: > > On Mon, Oct 14, 2024 at 04:46:14PM +0200, David Hildenbrand wrote: > > If so, it would be nice to document that too; but that is not > > necessarily your problem. > > I can squash: > > diff --git a/Documentation/virt/kvm/s390/s390-diag.rst b/Documentation/virt/kvm/s390/s390-diag.rst > index d9b7c6cbc99e..48a326d41cc0 100644 > --- a/Documentation/virt/kvm/s390/s390-diag.rst > +++ b/Documentation/virt/kvm/s390/s390-diag.rst > @@ -50,6 +50,9 @@ Upon completion of the DIAGNOSE instruction, general register 2 contains > the function's return code, which is either a return code or a subcode > specific value. > +If the specified subfunction is not supported, a SPECIFICATION exception > +will be triggered. > + Looks good. Thanks! > > I guess we won't see too many new diag 500 subcodes, or would it make > > sense to implement some query subcode? > > In the context of STORAGE LIMIT, a "query" subfunction is not really beneficial: > > it's either one invocation of "query", conditionally followed by one invocation of "STORAGE LIMIT" > vs. one invocation of "STORAGE LIMIT". > > Once there might be a bunch of other subfunctions, a "query" might make more sense. "If only there would be a query subcode available, so that the program check handling would not be necessary; but in particular my new subcode is not worth adding it" :) Anyway, I do not care too much.