From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AAFFCFC276 for ; Tue, 15 Oct 2024 08:30:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86C2A6B008A; Tue, 15 Oct 2024 04:30:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F6246B0092; Tue, 15 Oct 2024 04:30:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 648ED6B0093; Tue, 15 Oct 2024 04:30:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 402F46B008A for ; Tue, 15 Oct 2024 04:30:52 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7F22A814B7 for ; Tue, 15 Oct 2024 08:30:44 +0000 (UTC) X-FDA: 82675165524.20.66ED9F2 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf18.hostedemail.com (Postfix) with ESMTP id 975651C0022 for ; Tue, 15 Oct 2024 08:30:46 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=C5Pr17Sh; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf18.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728980933; a=rsa-sha256; cv=none; b=BT6YikLCLWUGrw1KN1tFzSW+dtwBqrDF44arQoLrf7LcDf7eV2+WN6ng7slEbvF5aqsXIq i9GMhj9gtDLjkCOfzAuF0rYUlMzi/hXYnmEghYtnusfrovWWIiesDJ29IKhRGZf6QV/GoN tKh+8/NioSUSPC7hKjY5vtMadXqbIDw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=C5Pr17Sh; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf18.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728980933; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IE4Ofqj1wFLXj4ZSqKW5+xLXr/77OsziB9/RuCpA9XA=; b=5wmnJRPs1vNqmpOpbyIrXD4nxhB7k66jtKdrCZZY0WxccXJ2VpyD6wpKnVTFTqvmtGnhNo xt2M4P3M3zmaxoxgJDGul1HeDm758KXhev2NIwM5k2tz3iRX/BIYC/TUc/C2D9+V7Xx/15 eGjN8AuNQC39YNgeqxb749HYEqHXOAk= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F8PZcA024028; Tue, 15 Oct 2024 08:30:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=IE4Ofqj1wFLXj4ZSqKW5+xLXr/77Os ziB9/RuCpA9XA=; b=C5Pr17Shb56/6mLJ3iERofYB//d0rtG9UucRGlloqJiyr8 fLy0oxFKu/4YNhPtUGWIvvUngrKaWT+yd/cUZW1A1Kjp/oH20AE+GQxXD0OHhh9Y M0pO2oIT8mJ8A0nrjCv+WygqZzFZF2CMvU1VApc3qWOIMYxiIf5SRogljPZdWFFC UAelL3AqHo+CtkTiuVH3hy1OCXAU32iU4AmN1WqRwxqbE5QWX/0Fc2TSmfqiW/jb aHbCEIbYnEW9kWgdDuFJNiUfOSCsMSbBDsJJAqqxPia1Ut8gaMKWn3ELJ9mz6nxV sj5nyB1QKlapcILSEDO6YgjCCYzTZ22Ol8lKlfbQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429mv4r0wj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:30:48 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49F8Ul8m003486; Tue, 15 Oct 2024 08:30:47 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429mv4r0we-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:30:47 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49F7bpIT027464; Tue, 15 Oct 2024 08:30:46 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4283txjtyy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:30:46 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49F8UgQ754133178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 08:30:42 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4DFE720043; Tue, 15 Oct 2024 08:30:42 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C69A20040; Tue, 15 Oct 2024 08:30:42 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 15 Oct 2024 08:30:41 +0000 (GMT) Date: Tue, 15 Oct 2024 10:30:40 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero Subject: Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel() Message-ID: <20241015083040.7641-C-hca@linux.ibm.com> References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-2-david@redhat.com> <20241014182054.10447-D-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: -AyqpN-uN4c-bHJlXc5K2WqcxF25sGU_ X-Proofpoint-ORIG-GUID: FOpmIxPaiaZwA4qPJKRUNqvsir83gI5C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 malwarescore=0 mlxlogscore=515 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410150056 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 975651C0022 X-Stat-Signature: g4nr7r9szbj11n7uuoccj93tq3xmbeph X-Rspam-User: X-HE-Tag: 1728981046-294012 X-HE-Meta: U2FsdGVkX1+7/cJYi6ZdtSKTbpwqpqCZe9RuFwthie503hiJxjmKHGmgy+SM6jzXSjSqOK1wLhrV+e8wxORzj62dYuZ7xSt+dk6g9Gwzn/vdl9ra1oQsSyhIvbC+UCcGWAxK/BRAiKRsIZFhPnmVQqVgnxYIv4SCYxP5/opa9xm1B/jqnDIWeKuNicqwyFuY0a0ATrEpkHo24RF80yx/GaLiqLoO7MmCsSyB/rsvVimIi9TGlInfrG6nVZriHMD79mkeRZLUnoGQo3zdjnax+M8X96uhYcytCyihDPQwIi31g3PDmMbXRrPsPRehit8FYPwrDnVBiTAhoKk4wxLyQLE446542taso3387m4YQe1tx6qPszd9PLgCX60vXRmeH1wHpWhv3aOxQQhJymOqhweAGrnC2/CH5e6KTRQ9wCCj32l+xi5EQyM7MW/7lSrNAW1wHoh5KbE+zsc6QGfr3+yQkXVncSokRb8fWR+G4yQ/cFB+f/rcD4RqKpLx9v2dAyZM+1TRls0EPtSECIBtXvtV/vE6AWpkyYcrKeOsuUgM4WKZQKu8WZFK0o1tH2ZAEQ8iWEZZoiF0oOpAZ/2H8D6T2F0lXSOVxWrOz6kVdN56/Oo57QmwRmvK+tIAEGYGQJAOLUXPX/833SPDulhTHcpOpeUZuIutKwSgVbSgAj5vBzAWTGgOty7lFiH93ObN81nu0/tXZwWwkaLLXUXxaNiaDteMEvMwaBhEsvWnAC8hIaqhKuqEJ5d8SNegu9FUE8beCY5a3O4YOL6EfQQsQfUzeCmojKoWIg7az0aizjr6Kg4mHm4TqS30lPBUQQurj2zYyOcGAI/Kf3LcSc8WRD2tPIr9/wvNZrUIjWsrc6IAp1CSMIP36ikMnqyzL05KgcyN7V8PEIsmN8yJS47nROuPbKrxIii1U6TlUwLPkrjIViPL8Y1n26t27LVLRLRLaSk/0/cZRchCoCZZPSr 4iK/9sTc Wx+PzOIFhDJprAWWcr+63j5ZxADKSE0FFLytZn43RgE8giXq1QcxWGFRsNjb5pOP3gIFGtzQ7aM7CGgNrbkTYi0XasQJt49fAXj8fuVHpxDsIyORvaTfxrqqEfBjHeex1t6fRczA4pmbvv/MjxcCG0e+kpkm4vK0QCMe+YQmAQOzjCfaYzl4eL3s8+AsUyL4dCI6rrtyOiu6ybeVbMs5N+PExpt0/uOX9Q3lYejyOPZVGv0f9Nl0ilCq63Mjca1orrD8n58rCrEQpGf+vogcrp9WC/A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 09:26:03PM +0200, David Hildenbrand wrote: > On 14.10.24 20:20, Heiko Carstens wrote: > > Looks like this could work. But the comment in smp.c above > > dump_available() needs to be updated. > > A right, I remember that there was some outdated documentation. > > > > > Are you willing to do that, or should I provide an addon patch? > > > > I can squash the following: > > diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c > index 4df56fdb2488..a4f538876462 100644 > --- a/arch/s390/kernel/smp.c > +++ b/arch/s390/kernel/smp.c > @@ -587,16 +587,16 @@ int smp_store_status(int cpu) > * with sigp stop-and-store-status. The firmware or the boot-loader > * stored the registers of the boot CPU in the absolute lowcore in the > * memory of the old system. > - * 3) kdump and the old kernel did not store the CPU state, > - * or stand-alone kdump for DASD > - * condition: OLDMEM_BASE != NULL && !is_kdump_kernel() > + * 3) kdump or stand-alone kdump for DASD > + * condition: OLDMEM_BASE != NULL && !is_ipl_type_dump() == false > * The state for all CPUs except the boot CPU needs to be collected > * with sigp stop-and-store-status. The kexec code or the boot-loader > * stored the registers of the boot CPU in the memory of the old system. > - * 4) kdump and the old kernel stored the CPU state > - * condition: OLDMEM_BASE != NULL && is_kdump_kernel() > - * This case does not exist for s390 anymore, setup_arch explicitly > - * deactivates the elfcorehdr= kernel parameter > + * > + * Note that the old Kdump mode where the old kernel stored the CPU state To be consistent with the rest of the comment, please write kdump in all lower case characters, please. > + * does no longer exist: setup_arch explicitly deactivates the elfcorehdr= > + * kernel parameter. The is_kudmp_kernel() implementation on s390 is independent Typo: kudmp. > Does that sound reasonable? I'm not so sure about the "2) stand-alone kdump for > SCSI/NVMe (zfcp/nvme dump with swapped memory)": is that really "kdump" ? Yes, it is some sort of kdump, even though a bit odd. But the comment as it is doesn't need to be changed. Only at the very top, please also change: "There are four cases" into "There are three cases". Then it all looks good. Thanks a lot!