From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06127CFC274 for ; Tue, 15 Oct 2024 08:38:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 785C06B0093; Tue, 15 Oct 2024 04:38:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 735FE6B0095; Tue, 15 Oct 2024 04:38:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D69A6B0096; Tue, 15 Oct 2024 04:38:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 40EF56B0093 for ; Tue, 15 Oct 2024 04:38:01 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 22FE51214BB for ; Tue, 15 Oct 2024 08:37:53 +0000 (UTC) X-FDA: 82675183500.17.4B65958 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf19.hostedemail.com (Postfix) with ESMTP id A4AB41A000B for ; Tue, 15 Oct 2024 08:37:49 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=JEjWhIpj; spf=pass (imf19.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728981335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QUa+46E8NUZzcXxa505gxyZiwH0Jg/Ul9dVsztozd6I=; b=uvwmAA4aQTT8wijC1V+5mRBU+zsgeYwf964F9edU3mZy8iuF6pAoyDbuR22MwdDtWN/Py8 IYDe0ValkKMKk65Fa10u2XSATKrtXKk0+jwwr5uOEdDoL06W9br9JOSlc1Yzw+b1dgNNxc 9XzErCIzJcorgmnfpPLZU3znZp+DDDU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728981335; a=rsa-sha256; cv=none; b=5JIdMrz97CHz5mkAK6xlbcAaTkm0iwAzz/YUZod/Rk8+ileSKG57RJJLhZu0Qtbw8tExCo XDwvCP9bw8htTyLc/JlCn+BlbQVEeBf9U/FOc60jNakybREfwqOL/lJF+a4xdNH8Uf5oij ogBa/V3GXZPkDsa97rkLhv15uoaGqII= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=JEjWhIpj; spf=pass (imf19.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F6Ppvn026537; Tue, 15 Oct 2024 08:37:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=QUa+46E8NUZzcXxa505gxyZiwH0Jg/ Ul9dVsztozd6I=; b=JEjWhIpjVfTfi7z8OrTAhPneHnsuC4U6IitiIygejiksTc pDxJxkYqF0VMxrNOytzrqHQOOxZECextTJTQa1KSTnVHAPoqf0MU0tEsd+ote66H c3uLwvz8zqvnyw8/RxC7TnQ0qamZ+I1Tpsrcdzdq1nbr/yUYDZeRqjxct6Kf1TyM R1d1Rael0AvJFsk7ypTEsx/ODbSBI1aIN8nvmEk5nbxYY1K6UlZEF8cJdrmdCPXY 5p1mHWG1mJ2cwB1nFjfPH+ruXHrajo0Hapgk+YPnyswWnSxnT8ra9ryZ/NP1QmDD jWV33tJc3zrLsmg3h+3iFvZaYiIsXF7NQ8WPs/Kg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429k3xrkwv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:37:57 +0000 (GMT) Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49F8burM018568; Tue, 15 Oct 2024 08:37:56 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429k3xrkwq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:37:56 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49F5aS24005951; Tue, 15 Oct 2024 08:37:55 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 428650tdx2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:37:55 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49F8bphN56623400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 08:37:52 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE97C20043; Tue, 15 Oct 2024 08:37:51 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9F3AD20040; Tue, 15 Oct 2024 08:37:51 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 15 Oct 2024 08:37:51 +0000 (GMT) Date: Tue, 15 Oct 2024 10:37:50 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero Subject: Re: [PATCH v2 5/7] virtio-mem: s390 support Message-ID: <20241015083750.7641-D-hca@linux.ibm.com> References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-6-david@redhat.com> <20241014184824.10447-F-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: EXXMZwwgVWyiaGSiPXsoCFFtmuGvYVXs X-Proofpoint-ORIG-GUID: Nmz2DOBP5V42-CA2w3FaC3Dux5ZSF5pS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 mlxlogscore=418 impostorscore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410150056 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A4AB41A000B X-Stat-Signature: z75xn59oymi1ob8n5p76hrkdhpb9y9mp X-HE-Tag: 1728981469-89693 X-HE-Meta: U2FsdGVkX198qGRN9He721QUINaQDVfYZFA2KhS9lDi3ugs9WR8WyllX0daWVX5TCRqxgz+2vKzyZqK3kxdUswJwp5/0/ZoafCjR07NosLW5mCyBBu4+2qN1Q2s0TYB343SJl+Xup5PSwfmiLNgSIpzM+kDOWiCQ44r2dic1M9BInkDZYBeOt8eAYpznptsPyotMxp4c7K98fXXoZGYdAtCpa0DyZLINhNs84PACMei+PgYA4vsAPC5rpPulKYuMcEG8FdYOHYQE4EiL9g+zMGfCe67wTkxd5tCyz2V12afXKLLpvzTsGHIpjqiojRlqWOq0rmIN22X5i1Pw4roMnn+BWPw07XqTaunyTthkVnSpz8fG98vNBTxINSdu+GjpeYBWLN2+vmRwjsMWfj13s7Zn7bumv/6UCrZnyUMbGTwAgPwZwxqDUdLCfIlSFN4zjNvwOXgjM0sRan/X/Aj00mUlo9Dm80ZzbQzDXPgtrgB6vKNAZdNLG3V3IfMoHJW+UQ+uaOqGTSxvrCgNbQDl5WMsX4y5YibxOBpLXYUB1sVOAFaoaWzVE0AnNCYzvM9uSt6DJl+CGeBpMtFm+o+sFkh6rwYc7hOG/1FHOZONrXg30cEE8Zn1JYKgjQZmMHoXYbZbSB5bGSbSkYdybiokY0fPt7VxtRNZg7U4BUk0W4SNvop0vlGkf6aJ65HKxTeosO7t/JMxXia/yJNxh8oCy/z3sf+qHPY5nmF0Sc8jNQBWzUwrWrkXYwaFuusyJXByxIOUML6qLECM04JOBSDvdI2MFqFLi82NdgqXS4sXagKR020/TWvBoZyqJEhcIQeg5XDy5eSU883zKACgz1SOnan4QFsMP3QcG/m6BGFJxfW2VMMOaVVlP6u6BfRf7hHljk8YGaIYIHX2rhMI1Ol/Jf7oOp10kxKqdR+a+yyuDtb0wqc6viLyrM2AbX0DVrjeEXwcrBjSZylcvZryQbZ xjWVRf6I jM3lP6CGpDUlnvdTlHklTmigc+m2LGZfJ9JSDLXPjlO16WUPRmOd+In2oyuM0WXwGwRbWYyXBRVDMIy+ltG7HhkUuGgfo+q5P39osmNXbUMk/xBkXiNk/teqFKjjiXkDgh9lzSjzHL64m48/5/CcgD+WfA6nIkSVSGBKdMaDGqJ7Rl1r1I+Wqz7mRZljo5cEk25tbSwHiVYLLhyMA5K9eaDSh6taGkErFp4GLei4KLLireCAX2xZ+XIq/n6K2m4S2dzLTHJpkWqaJF8sl8h9sTqJPN19IT2V8j3j331GFHNJNc/EZFB0hbsB0MMB56zSPrptB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 14, 2024 at 09:16:45PM +0200, David Hildenbrand wrote: > On 14.10.24 20:48, Heiko Carstens wrote: > > On Mon, Oct 14, 2024 at 04:46:17PM +0200, David Hildenbrand wrote: > > > to dump. Based on this, support for dumping virtio-mem memory can be > > Hm.. who will add this support? This looks like a showstopper to me. > > The cover letter is clearer on that: "One remaining work item is kdump > support for virtio-mem memory. This will be sent out separately once initial > support landed." > > I had a prototype, but need to spend some time to clean it up -- or find > someone to hand it over to clean it up. > > I have to chose wisely what I work on nowadays, and cannot spend that time > if the basic support won't get ACKed. > > > Who is supposed to debug crash dumps where memory parts are missing? > > For many production use cases it certainly needs to exist. > > But note that virtio-mem can be used with ZONE_MOVABLE, in which case mostly > only user data (e.g., pagecache,anon) ends up on hotplugged memory, that > would get excluded from makedumpfile in the default configs either way. > > It's not uncommon to let kdump support be added later (e.g., AMD SNP > variants). I'll leave it up to kvm folks to decide if we need kdump support from the beginning or if we are good with the current implementation.