From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A68C1CFC278 for ; Tue, 15 Oct 2024 08:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DE606B008C; Tue, 15 Oct 2024 04:46:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38E486B0092; Tue, 15 Oct 2024 04:46:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 207E16B0093; Tue, 15 Oct 2024 04:46:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 00A6E6B008C for ; Tue, 15 Oct 2024 04:46:45 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 79D37C093A for ; Tue, 15 Oct 2024 08:46:36 +0000 (UTC) X-FDA: 82675205760.06.7BEAD59 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf27.hostedemail.com (Postfix) with ESMTP id 660A440002 for ; Tue, 15 Oct 2024 08:46:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=InFSyYf4; spf=pass (imf27.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728981930; a=rsa-sha256; cv=none; b=Pab5N28xzX4KqcXv1W5+I5VWrMzJPTsqK0XXkyRusql7bzes32a/ug0ik6H9z2OLDZUMcm rZIqh9Oes7ix5fwvF+jyl80AsA9CWBm5cMDV8AgGmqgh0uRAl5cBV6JpLtBen5ADDraIV+ LZtToz+01f12Zxa9SVRqvURZn9k9RPg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=InFSyYf4; spf=pass (imf27.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728981930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2O8GnyJm4G3jGvPQJzneXovEocBj+fNJloVLUU/yom4=; b=in/mzYaZE+7vj6sasaIiC/fdjRVzOPnb0c0BbkeLPy/zLC0hEexavOvZxV8OzIZKS/XBwE /MEM4H8l2DylIHSski9GVcY6SU26D8LWnynfabmskC3TsKNlF/SeuKYzrPrjkAcdemaFSk GXUMIs9qbns+D1Z3V1vmngaCz42m+1o= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F7teQ3025076; Tue, 15 Oct 2024 08:46:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=2O8GnyJm4G3jGvPQJzneXovEocBj+f NJloVLUU/yom4=; b=InFSyYf4TD/FUicAQBNVy2EH6YhWbMoFpfM8I7B7t6d8GX QkbVvDBgC+YbA02E9/SFuCK9T/7SCecnSUcehBKB9iUwq1DVxXkURcVIgW05EFOR jgfVdlU5UAWUuibXdCJyjuI7fYvGvCFzSqalpD6HXWYOp3WUDTKnus12iMV+e5T1 g1HJGfWmbcYKPZasQA6x/SIZXwf9sJ7qOuaz25k9bxrqqvgBYQuX8MZyNt0U7nGj DiKTnpABJpVTlukTR56PIXNX6mWU/UFCcgwDwqCbS3xpyUGV+XnXwYUObXdo+hjY HJFdZiRMUs3dA0kVxvjUts30mmxocYe9EMxMJmKg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429me108ap-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:46:42 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49F8jB4A014163; Tue, 15 Oct 2024 08:46:41 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429me108ah-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:46:41 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49F7TuNN002473; Tue, 15 Oct 2024 08:46:40 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4284emju4d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 08:46:40 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49F8kbVa25559804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 08:46:37 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3E6462004B; Tue, 15 Oct 2024 08:46:37 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A47C020040; Tue, 15 Oct 2024 08:46:36 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 15 Oct 2024 08:46:36 +0000 (GMT) Date: Tue, 15 Oct 2024 10:46:34 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet Subject: Re: [PATCH v2 2/7] Documentation: s390-diag.rst: make diag500 a generic KVM hypercall Message-ID: <20241015084634.7641-E-hca@linux.ibm.com> References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-3-david@redhat.com> <20241014180410.10447-C-hca@linux.ibm.com> <78e8794a-d89f-4ded-b102-afc7cea20d1d@redhat.com> <20241015081212.7641-A-hca@linux.ibm.com> <8e39522c-2853-4d1f-b5ec-64fabcca968b@redhat.com> <20241015082148.7641-B-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 5SQSHlUPWxfh2tLy-cwM-LSq5IpV_QTl X-Proofpoint-ORIG-GUID: 9aniXcWNp1HHXnm-P4vux2xj9Q6hltgG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 mlxlogscore=313 malwarescore=0 spamscore=0 mlxscore=0 adultscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410150056 X-Stat-Signature: 9ess4tf6pthrtgfqu9hp456hqdntc6tm X-Rspamd-Queue-Id: 660A440002 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1728981996-736058 X-HE-Meta: U2FsdGVkX18eMH/6/WZUYp3Akj0NN1fm0nGOX18o69VmtfpPo3u4zx65OU5WWFlHzTo3Linte7MwDKdvf9zS1Dv4CiXqiheJ2ysILysRqDE1FNMMq8VKmBxzaHPBtd7TNSqpNCC57AfYy129axwGEcUB9n3aLKrHoRuV59kGngxE0sjNk3/byUBuJrkwXH4XdTC/6mmq5/8RN+wQe1evHUsyqsvA1RsEImmXohj21+SyZelbvZt9m7a0sW38mkCTFXBFMGMfANmsJQ5OYVBpv1LyqSr8L1DYzDUT/dHlDxOieh+gkxmJKRZFqoq7hNtOHZgMG73xxkrWhGjNdRXy+e2K6wGC8UktgT5NHJzLVJMOwSZc7lTMqsht/3nKIPJUQfTzUqqTgX3f9NECd4AkygKMfpJx9Ea6KaFH+gpOLrJaRxTNhRKNDSH8/fho5Rja2fReQSiCzYMeMVBL3GfK4V3wRGU3qeLJh3fWLN6bZTo126z0sC+jSzFCX497EmDT7n4W0g/9675r2BIIhW2oMYE3HdGYgD7wa/gGSNKRIfvmCKy44nvJaASgBJ6l3JuOyUWNwx4QH3UTyO6zU6P+gbnbcAZ5bf7mlYpB5LjeYPfZRncPu1TxMXTGeEiFtJNZeRr9inscGwHJlUAuNLy1oOOfNQrpE2vL7esSqbWtGM5q845j/MQdgcBMhTX9kOJiPQaLPirLl6tB8KUBhm1uWyWrterimGtie+C3B0V7MRIW7TnWlcYJ4f+e3orm05HDHKkLgYdkI2mz4EMkCPuxv82HgwshxHm49qv2oYqhcbT9yYQmFw828A1e57C24TN6JkP3xjjzXVRc6kY0U5Jp36X3SS71IuCbQznYmuTF45+nzlv7CkEgwdHyG7OTG6cNvoD2iFEedBb+rEbg4rOQ4Kj1PfSGuo3jKn8wr64m5vI27CDPOue+3zupEYSUvePmh/cyVsTyzDL3sH3qraj fyVpYSUI KI6cuoj+aKplM/x381oxv3gCNCPFEEwZz1gMLFesvJZ7TZwZ9oEpJgbAiHx2aV0croklh/fErSvoR95QaMHOBmetyeXrr9yT2wk78NJftUn1f94QYpw7lohEWoGtNVdrMAdwyzzWL5YIIZ38heQJ2ne0UfgPmN5UrFK6AdJXSRX01kU6ZSjVSD8i2kNDKkM32/l/UCUyNW1Yu39UQwCrWRpmtRkZ5TG4h75hl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 15, 2024 at 10:32:43AM +0200, David Hildenbrand wrote: > On 15.10.24 10:21, Heiko Carstens wrote: > > On Tue, Oct 15, 2024 at 10:16:20AM +0200, David Hildenbrand wrote: > > > On 15.10.24 10:12, Heiko Carstens wrote: > > > > On Mon, Oct 14, 2024 at 09:35:27PM +0200, David Hildenbrand wrote: > > > > > On 14.10.24 20:04, Heiko Carstens wrote: > > > > "If only there would be a query subcode available, so that the program > > > > check handling would not be necessary; but in particular my new subcode > > > > is not worth adding it" :) > > > > > > > > Anyway, I do not care too much. > > > > > > > > > > Okay, I see your point: it would allow for removing the program check > > > handling from the STORAGE LIMIT invocation. > > > > > > ... if only we wouldn't need the exact same program check handling for the > > > new query subfunction :P > > > > Yeah yeah, but I think you got that this might help in the future. > > Right. Adding it later also doesn't quite help to get rid of the checks > here, because some user space might implement STORAGE LIMIT without QUERY. This would only help if the diag500 documentation would state that implementation of the QUERY subcode is mandatory. That is: for every new subcode larger than the QUERY subcode QUERY must also exist. That way we only would have to implement program check handling once, if a program check happens on QUERY none of the newer subcodes is available, otherwise the return value would indicate that. Otherwise this whole excercise would be pointless.