From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C426E7716C for ; Thu, 5 Dec 2024 15:24:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC8DE6B00C6; Thu, 5 Dec 2024 10:19:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04D696B00D3; Thu, 5 Dec 2024 10:19:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 704F76B00C9; Thu, 5 Dec 2024 10:19:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9B59D6B0082 for ; Tue, 15 Oct 2024 06:09:06 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4860F1214D5 for ; Tue, 15 Oct 2024 10:08:58 +0000 (UTC) X-FDA: 82675413408.28.0F86116 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf20.hostedemail.com (Postfix) with ESMTP id 0839F1C0022 for ; Tue, 15 Oct 2024 10:08:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=orD2fuzx; spf=pass (imf20.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728986800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/c7LV/XQCFoM90nvgmsgvrUkllUDo6cElhrXfABkZfQ=; b=SNuqZhhcmezXOgL1lFxdqh0LtJ6dn/bztKwMkFjtHYtkhG/upqp0waJCzmE/yY0h12UAxD mr3YWopepY727EKf1HBVe4HaC06DJ6AyRgryScy9+HfRq0uSnlqJNVbqXo1cYPwD7kEk9h is6+8EwXE+OtzatUmeq2J3BZLDgxmvg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728986800; a=rsa-sha256; cv=none; b=xYb9QJQ8xHlu5EghprkHAqc7lDGcxN3FfoaLr6aay7m6IpUIaqH77qCPgS3wYagDiZnGcU FouqdZ3VXTIKssP1V89uJTo8SlI0jQgGsANKq47fStcxTpqsqtWRGhlNXc4MynPr/KlS+C uRuQNUdUk7QHBwJARU1kU7WEbfvtU3o= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=orD2fuzx; spf=pass (imf20.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F8PIdt023808; Tue, 15 Oct 2024 10:09:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=/c7LV/XQCFoM90nvgmsgvrUkllUDo6 cElhrXfABkZfQ=; b=orD2fuzxADOT2+HxgEydnL3W+PkhEdGjS5UKKVau1xhD5b EgtbAK4cINCp6W7feBhvjPexGoQbNGSBMg4Niu20J3NYWfq4ti551CFDS9F7UUs4 uJI6QQgPmfNYxb8ejTqzwUby7nEIfRJaG12732FzvJ9RkqL6t+fWS0kMANy5ss/E olzppJ2JbaqWLgxLdiG4guUDpoRWRYSpBmIjjHw6ahq69x6/xv08Q5rV4ekCr6fu jFK/7dSCrKf6xaML6LtYFhz9dxxBnfUoS7zOBhVRnoE4TfZ7PVFEckqULqo6Z3ej 2iDVmL5pjdwfZBhIGkxCw/D4iKme8VVz3FkbS8iA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429mv4rh6x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 10:09:02 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49FA91wf019574; Tue, 15 Oct 2024 10:09:01 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429mv4rh6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 10:09:01 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49F8hDOg005377; Tue, 15 Oct 2024 10:09:00 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4285nj2w6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 10:09:00 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49FA8uJs53608814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 10:08:56 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75FC52004B; Tue, 15 Oct 2024 10:08:56 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3088B20049; Tue, 15 Oct 2024 10:08:56 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 15 Oct 2024 10:08:56 +0000 (GMT) Date: Tue, 15 Oct 2024 12:08:54 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero , Alexander Egorenkov , Mikhail Zaslonko Subject: Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel() Message-ID: <20241015100854.7641-J-hca@linux.ibm.com> References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-2-david@redhat.com> <20241014182054.10447-D-hca@linux.ibm.com> <20241015083040.7641-C-hca@linux.ibm.com> <0c7e876f-5648-4a82-b809-ca48f778b4a6@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c7e876f-5648-4a82-b809-ca48f778b4a6@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: B4FoBzXg4xRB3GzcXvcGiFpFwcYSCEoJ X-Proofpoint-ORIG-GUID: ydJ8NcHofxE6nimFbJhOvYGvELg379sK X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 malwarescore=0 mlxlogscore=468 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410150068 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0839F1C0022 X-Stat-Signature: b7gx5ghhfzr8mjxt1y45axc7yi9ntmxx X-HE-Tag: 1728986934-73530 X-HE-Meta: U2FsdGVkX1+b+6E3oDhhxvTQAEMOXeUFqAGlIj6rmzHEPVu4hPMzLgiUvSAUDZ5j5pdmQSydmGKpJ6nSwi4oQbauklF0t2VmyU88Zv5lKR/euL4TpB7kf4RRLscBHiG9fZ+ZjVhIKJUwRoL4YBEnCE3NxiQwFEy82ZxMeUhbl8SxB0MhkxWo3z6FMoMsuFbEYRMjszBwCiQohEUuyk4t0azyShz/UBJqQf/muGK362WZlK+kgFNz+ROo0OSZwkr+qtRsr+fwMkthUGYvsPIME7LJg1ZbaVE3Ue+J/wSVpPHrZ395RXelL9D/2tzo5q5Jf5O3dvEHy4H1/VxQ3REQbZWscG22rZ1EL3xy7YVm+tp5MPMl/PwE3Vob4Uyk3pneys26Ca3BV2DRwPDOrMAOSWDhtyRlobMQPdKsFJrNmAGfWH+8+IxlutZIuD/vgrJfKJgpp3UgfCKuunAsc+bZoN99hyeORY29PkYffkiGTjMrkOHDt6cbT7gqszFYeggZfx+1WmwT7Q80GYBn2enJi/Ocq0rz2HxNkS3SaNnZEdjqjqI/ZplvW0Jm18uMrE2irGCI1a/USAy2M/Xu9q7zQMyrlP0XWLKxJDBUxf3op+q6Do8eKaMX4SXoKbMw/gY10Gd6/NPPL8rpUho9huoCC3eZusVSCrCM4Yfy3WYYuxMDZ7fCAGeyMhbC44VaRuMD+IVFNctpSxCXyGWScAlHfc7e1wQFkscioGM8NbojQRmUn6sSCAb8w9J/ZSYISUotGGdUTpJNNRHvRIPjFrbQH8nG8JF/h7vyHhqijlVMGaRc+C7TkEYT9pPh1LAuwr0/0hbFIRrVxKNxMdR6X9sMIfCgNzPK6fmVUN5x4eaDfV+//QOdOwyivJ9egr6UNf0z77H3lpUFsOe3h49k3k17MPIBIqcak46NBcDR3UCsUbbjO327LY2zz/NRuqX4fzjEMpX9atULihg3JEwK615 MaNNNZO0 ExFgzR6ckh6Mi3qBdzOyDpMZnVgwZ3JZ6V5BBUviVzUS7Bjm+Wa3sASGIQufffZRwpL0KwNLtJx5LQlyhsPpUOwnUpyeRUGM+oKRuC0esuUs61AK0WZ30h2wE0wHGU24bBsNLjqsJvKSNjtgkXql0ghhUcsmew7qh5KFsIr92v0FaEn0GBaVhxdUW4x45ijvEZsYEzDOqjqLWhqeL7CoazjPeAogkB4QUfwVjPIR6ilgtuImcKQhfuR9Uc+dIqGQg6OHUX6oh+xQ9C8LRf3hewBKRhofof+h+A+U3+Cu0DzvlHB80p3YH+9vtSx/egYcg8TTa+SseqxozQxj+F3wqC9h4jIHEgXueeUscIN79zSBcuTHyRqPIZCuUPNErJFXavaZ8GcvPr06B0W7+vXKhTBs8Y4Sx5eqUxspdrQAoJJHf9l0WL9UmHQU7hy1jfEg5su1Y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 15, 2024 at 10:41:21AM +0200, David Hildenbrand wrote: > On 15.10.24 10:30, Heiko Carstens wrote: > > On Mon, Oct 14, 2024 at 09:26:03PM +0200, David Hildenbrand wrote: > > > On 14.10.24 20:20, Heiko Carstens wrote: > > > > Looks like this could work. But the comment in smp.c above > > > > dump_available() needs to be updated. > > > > > > A right, I remember that there was some outdated documentation. ... > My concern is that we'll now have > > bool is_kdump_kernel(void) > { > return oldmem_data.start && !is_ipl_type_dump(); > } > > Which matches 3), but if 2) is also called "kdump", then should it actually > be > > bool is_kdump_kernel(void) > { > return oldmem_data.start; > } > > ? > > When I wrote that code I was rather convinced that the variant in this patch > is the right thing to do. Oh well, we simply of too many dump options. I'll let Alexander and Mikhail better comment on this :) Alexander, Mikhail, the discussion starts here, and we need a sane is_kdump_kernel() for s390: https://lore.kernel.org/all/20241014144622.876731-1-david@redhat.com/