From: Heiko Carstens <hca@linux.ibm.com>
To: Eric Farman <farman@linux.ibm.com>
Cc: "David Hildenbrand" <david@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-s390@vger.kernel.org, virtualization@lists.linux.dev,
linux-doc@vger.kernel.org, kvm@vger.kernel.org,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Mario Casquero" <mcasquer@redhat.com>
Subject: Re: [PATCH v2 4/7] s390/physmem_info: query diag500(STORAGE LIMIT) to support QEMU/KVM memory devices
Date: Tue, 15 Oct 2024 17:20:08 +0200 [thread overview]
Message-ID: <20241015152008.7641-P-hca@linux.ibm.com> (raw)
In-Reply-To: <8131b905c61a7baf4bd09ec4a08e1ace84d36754.camel@linux.ibm.com>
On Tue, Oct 15, 2024 at 11:01:44AM -0400, Eric Farman wrote:
> On Mon, 2024-10-14 at 20:43 +0200, Heiko Carstens wrote:
> > On Mon, Oct 14, 2024 at 04:46:16PM +0200, David Hildenbrand wrote:
...
> > +#define DIAG500_SC_STOR_LIMIT 4
...
> I like the idea of a defined constant here instead of hardcoded, but maybe it should be placed
> somewhere in include/uapi so that QEMU can pick it up with update-linux-headers.sh and be in sync
> with the kernel, instead of just an equivalent definition in [1] ?
>
> [1] https://lore.kernel.org/qemu-devel/20241008105455.2302628-8-david@redhat.com/
It is already a mess; we have already subcode 3 defined:
#define KVM_S390_VIRTIO_CCW_NOTIFY 3
in
arch/s390/include/uapi/asm/virtio-ccw.h
which for some reason is uapi. But it doesn't make sense to put the
new subcode 4 there too. So what is the end result?
Another uapi file? I think resolving this would be a project on its own.
next prev parent reply other threads:[~2024-10-15 15:20 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 14:46 [PATCH v2 0/7] virtio-mem: s390 support David Hildenbrand
2024-10-14 14:46 ` [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel() David Hildenbrand
2024-10-14 18:20 ` Heiko Carstens
2024-10-14 19:26 ` David Hildenbrand
2024-10-15 8:30 ` Heiko Carstens
2024-10-15 8:41 ` David Hildenbrand
2024-10-15 8:53 ` David Hildenbrand
2024-10-15 8:56 ` David Hildenbrand
2024-10-15 10:08 ` Heiko Carstens
2024-10-15 10:40 ` David Hildenbrand
2024-10-16 13:35 ` Alexander Egorenkov
2024-10-16 15:47 ` David Hildenbrand
2024-10-16 15:54 ` David Hildenbrand
2024-10-21 12:46 ` Alexander Egorenkov
2024-10-21 14:45 ` David Hildenbrand
2024-10-23 7:42 ` Heiko Carstens
2024-10-23 7:45 ` David Hildenbrand
2024-10-23 11:17 ` Alexander Egorenkov
2024-10-14 14:46 ` [PATCH v2 2/7] Documentation: s390-diag.rst: make diag500 a generic KVM hypercall David Hildenbrand
2024-10-14 18:04 ` Heiko Carstens
2024-10-14 19:35 ` David Hildenbrand
2024-10-15 8:12 ` Heiko Carstens
2024-10-15 8:16 ` David Hildenbrand
2024-10-15 8:21 ` Heiko Carstens
2024-10-15 8:32 ` David Hildenbrand
2024-10-15 8:46 ` Heiko Carstens
2024-10-15 8:48 ` David Hildenbrand
2024-10-14 14:46 ` [PATCH v2 3/7] Documentation: s390-diag.rst: document diag500(STORAGE LIMIT) subfunction David Hildenbrand
2024-10-14 14:46 ` [PATCH v2 4/7] s390/physmem_info: query diag500(STORAGE LIMIT) to support QEMU/KVM memory devices David Hildenbrand
2024-10-14 18:43 ` Heiko Carstens
2024-10-14 19:42 ` David Hildenbrand
2024-10-15 15:01 ` Eric Farman
2024-10-15 15:20 ` Heiko Carstens [this message]
2024-10-25 10:52 ` David Hildenbrand
2024-10-16 10:37 ` Halil Pasic
2024-10-17 7:36 ` Alexander Gordeev
2024-10-17 8:19 ` David Hildenbrand
2024-10-17 9:53 ` Alexander Gordeev
2024-10-17 10:00 ` David Hildenbrand
2024-10-17 12:07 ` David Hildenbrand
2024-10-17 14:32 ` Alexander Gordeev
2024-10-17 14:36 ` David Hildenbrand
2024-10-30 14:30 ` Alexander Gordeev
2024-10-30 14:33 ` Alexander Gordeev
2024-10-14 14:46 ` [PATCH v2 5/7] virtio-mem: s390 support David Hildenbrand
2024-10-14 18:48 ` Heiko Carstens
2024-10-14 19:16 ` David Hildenbrand
2024-10-15 8:37 ` Heiko Carstens
2024-10-21 6:33 ` Christian Borntraeger
2024-10-21 12:19 ` David Hildenbrand
2024-10-14 14:46 ` [PATCH v2 6/7] lib/Kconfig.debug: default STRICT_DEVMEM to "y" on s390 David Hildenbrand
2024-10-14 18:53 ` Heiko Carstens
2024-10-14 14:46 ` [PATCH v2 7/7] s390/sparsemem: reduce section size to 128 MiB David Hildenbrand
2024-10-14 17:53 ` Heiko Carstens
2024-10-14 19:47 ` David Hildenbrand
2024-10-14 18:56 ` [PATCH v2 0/7] virtio-mem: s390 support Heiko Carstens
2024-10-14 19:17 ` David Hildenbrand
2024-10-15 7:57 ` Claudio Imbrenda
2024-10-25 10:54 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241015152008.7641-P-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=eperezma@redhat.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=mcasquer@redhat.com \
--cc=mst@redhat.com \
--cc=svens@linux.ibm.com \
--cc=thuth@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).