From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5F1E7716D for ; Thu, 5 Dec 2024 15:21:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 054496B00F1; Thu, 5 Dec 2024 10:19:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F19136B00CA; Thu, 5 Dec 2024 10:19:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E9306B00A5; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 969A96B007B for ; Wed, 16 Oct 2024 06:37:14 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2B51914088B for ; Wed, 16 Oct 2024 10:37:04 +0000 (UTC) X-FDA: 82679112810.03.F2F1DE3 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf07.hostedemail.com (Postfix) with ESMTP id D2ACC40016 for ; Wed, 16 Oct 2024 10:36:59 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Q45K40cU; spf=pass (imf07.hostedemail.com: domain of pasic@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=pasic@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729074888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zMeyJS0z7cn5JjFKCkgSbMvXgBCHzt6or6qpLiwiFAU=; b=wRBMRi/1bOa3MnHSL/szBaiMEB0vzpvL7DdSFwLMb1YoVbfzOKqxmwe5Znez1G2qZRiVCo ioEJUSshGw6bebEiTfJ+I6510j8GffWTptZrmfIjThNjcP7iRrabVyDiccNiOk2Ubmc6QC 9xZqclzRYULk15tNBsF253hCRcvQIDg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729074888; a=rsa-sha256; cv=none; b=K5UgGJpYgpg3zE65Qft1nTaYKOybheA7TdqKsOW6fDNf6stWhFyLk7KVO1FlhpTvvFg82o fjvMDX0H/37pbmS5vf0aDYpHO34gmA5+QXnwAvWbu4zl/0oWqC9RaMd65E85LeLojbhQSu JRjCPsduff1OBt6YVL3NjBt5dRDE6Vo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Q45K40cU; spf=pass (imf07.hostedemail.com: domain of pasic@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=pasic@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49GAKEWI023035; Wed, 16 Oct 2024 10:37:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=zMeyJS 0z7cn5JjFKCkgSbMvXgBCHzt6or6qpLiwiFAU=; b=Q45K40cUR2vLXWMfC1NfAw 3W9w4L+9Wmtz7d1DOvF7KIZrrQHVUkrrP+0zBcp16g34JBH++2G7ot7vQY++mQgS 5bWRJojDib/0i1n1YVPJ4WNZ8N74YLnQkZbKkhI5RsfLGPv4nO3XYMc0rzdBYyQA tg53sJwG5m6bhZlm8C6OTIfm4bekpYXr0ZacrXcQC4HY0YPhBuuOacC8zNX/nqRg dU+cppVGBrL7ApVDQdEBv2sxL9hNI1uZeOOmITYquvwWtXxVBxC/NR98bZgLT0fK Xay0Mr+nrttKPuensrB4bqaX4PWWyyIzcHzNgBeNBWzSJLjN848iN8RO/5V8mBNg == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42abn0g2wk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Oct 2024 10:37:10 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49GAbAcC030714; Wed, 16 Oct 2024 10:37:10 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42abn0g2w6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Oct 2024 10:37:10 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49G81Lrc005215; Wed, 16 Oct 2024 10:37:09 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4285nj8kqt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Oct 2024 10:37:09 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49GAb5vm54985128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 16 Oct 2024 10:37:05 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7ED8F20040; Wed, 16 Oct 2024 10:37:05 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3953A2004D; Wed, 16 Oct 2024 10:37:04 +0000 (GMT) Received: from li-ce58cfcc-320b-11b2-a85c-85e19b5285e0 (unknown [9.171.7.78]) by smtpav07.fra02v.mail.ibm.com (Postfix) with SMTP; Wed, 16 Oct 2024 10:37:04 +0000 (GMT) Date: Wed, 16 Oct 2024 12:37:02 +0200 From: Halil Pasic To: Eric Farman Cc: Heiko Carstens , David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?UTF-8?B?UMOpcmV6?= , Andrew Morton , Jonathan Corbet , Mario Casquero , Halil Pasic Subject: Re: [PATCH v2 4/7] s390/physmem_info: query diag500(STORAGE LIMIT) to support QEMU/KVM memory devices Message-ID: <20241016123702.04688e2d.pasic@linux.ibm.com> In-Reply-To: <8131b905c61a7baf4bd09ec4a08e1ace84d36754.camel@linux.ibm.com> References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-5-david@redhat.com> <20241014184339.10447-E-hca@linux.ibm.com> <8131b905c61a7baf4bd09ec4a08e1ace84d36754.camel@linux.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) Content-Type: text/plain; charset=US-ASCII X-TM-AS-GCONF: 00 X-Proofpoint-GUID: H5ULsniXk0Rfka_9RRyv3agVS3JiWal7 X-Proofpoint-ORIG-GUID: FKcGPPcfDhFwjLM7_HrSq6Zn3U2EPmeB Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=919 lowpriorityscore=0 clxscore=1011 bulkscore=0 malwarescore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410160065 X-Rspamd-Queue-Id: D2ACC40016 X-Stat-Signature: nnujxeaxe37ojejdadcq6uoefm4gnw9z X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1729075019-64754 X-HE-Meta: U2FsdGVkX1+KFg7WgP0fNKkBsqFBckEOw+M2NK1lphcoN83ZeyPi2DzU0RJ0QF4soPJQ6IWj4o+r235gaF7FLRfqFvpy4KX7PBhzufI+j8SSfjhHAXBe4BHw1xgMXNYd/tHsSUqhhJ5zQkKgPlynr9mMSeNBlOudaO3mo+HygcZz67LeCZlZXe1sS2K26eDkK2Ab3bi1sYFa5z6pwUL20L3a3qH76QI+P27v32X7Da7BbtJkVuPRDfjXpBm07hElU+AR7MEkEjRkub4jYL6JKbTVz1RPeuhJYdrC+HrcfzhVQXjvQ1x+gh76LfD2TOmRXMNkHW0iQ4Ukt68N9sQEs1CRa3agYkAP0vbbL/Sy2NGiyC+4KwFFwC3GurKEeCrpgI2E7bABOvkF2bJMN3k+opMO505djrhBu96TbUXq19iqMwOV97r2KhskpI5QqZNE1XgHOycfwCb3H7BypY4N7ekIRj3qE7xiSAxwihyEWoMIOselH46u+MwBNM5Ys0Lsk49C3zTNOXtYal1UjRsOQNwFcgjj8C7uaoGqOjBXbYqWJslscqn6trRmisrNyubNmxwll+WWrQITZCYWVEIsV0EB7SO+41VAfjtL2wwGYnYWuN9v1tzbzBW55w87eC/9fkLhFemBwm03VRYwRDkZwa8kZozXv/1j+E38Vl9wYI2E1bZfdxwgW+GOtUVQ0d9asXd8DaQew/A7PnhxfBBdcC+gEZPhreB18epEQ4RJaaSJIIKTyuN35st13MsogDGB294WmUE/N2Wa3ZaF9FawF6GU1OsGWqbbFmTOx7ttKyzZ/6a2HQeoAzJDj28mLa3YDIwioqqK/covp4p4ovOx1GChdoRAjlNGdC70E6nLc4z+a2Moy/wex2SeUiPI2UcN+soZYn2SY55AG9S0mY1HwVQ48YEcKd214coHgn7fW/TMqzcpcAAvJOSRTqjXU/O171JmtpWc7s8l4l0Axht pEFhYirP htBlQR5Az/g3WCpr2fwS83SV+XE3k9HqMhjDhmpPeQtJyQ/4UqSomZ3N1g0r8yVD+SrHiCsmRUaay4PAuHKyx/mWg6ViiL+5zVbZk+xlLqOvQQa6krnuHnzCegeCyzrc3wwLrPHLPQK591hPW6OBae71+4Donn0RnOcsnmnhVAoEzCrqvsQhiSD2pk3tryHmvhBg020fBTRWNL4CxmfBGaZB/2fGYrrb3qXJb8/nuELdP3ceP+HgJBleQLACwZuTCxSjj8WC80z/e+LFIfYQgz2cTM3b/AC4uqhx7q9NT/+O+HoWnRVLW5AaI/vXIKVtgu5NCWvzO9+QCoLqi7D+PL0q/lUOq9ld4YTGQCuKl7L0cwflPkGBaauaMQJCftUxbm6aqHT12AAMcHXyQlzQ8yXfSaa96oa7H/nav7xwjx5P0vc9zTmays++ZocD/vqUiakUBmPfbqbfRMIwwWXrfFJbuVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 15 Oct 2024 11:01:44 -0400 Eric Farman wrote: > > + [subcode] "i" (DIAG500_SC_STOR_LIMIT) > > + : "memory", "1", "2"); > > + if (!storage_limit) > > + return -EINVAL; > > + /* Convert inclusive end to exclusive end */ > > + *max_physmem_end = storage_limit + 1; > > return 0; > > } > > > > > > I like the idea of a defined constant here instead of hardcoded, but maybe it should be placed > somewhere in include/uapi so that QEMU can pick it up with update-linux-headers.sh and be in sync > with the kernel, instead of just an equivalent definition in [1] ? > > [1] https://lore.kernel.org/qemu-devel/20241008105455.2302628-8-david@redhat.com/ I think it is fine to have equivalent definitions. This is more or less an ISA thing we are introducing here. And IMHO it would be fine to have such a definition even if the emulator was supposed to run on an OS that is not Linux and without without KVM. Regards, Halil