public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: Liam.Howlett@oracle.com, akpm@linux-foundation.org
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
	Wei Yang <richard.weiyang@gmail.com>,
	"Liam R . Howlett" <Liam.Howlett@Oracle.com>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: [PATCH v3 4/5] maple_tree: refine mas_store_root() on storing NULL
Date: Fri, 18 Oct 2024 02:39:42 +0000	[thread overview]
Message-ID: <20241018023943.13860-5-richard.weiyang@gmail.com> (raw)
In-Reply-To: <20241018023943.13860-1-richard.weiyang@gmail.com>

Currently, when storing NULL on mas_store_root(), the behavior could be
improved.

For example possible cases are:

  * store NULL at any range result a new node
  * store NULL at range [m, n] where m > 0 to a single entry tree result
    a new node with range [m, n] set to NULL
  * store NULL at range [m, n] where m > 0 to an empty tree result
    consecutive NULL slot

This patch tries to improve in:

  * memory efficient by setting to empty tree instead of using a node
  * remove the possibility of consecutive NULL slot which will prohibit
    extended null in later operation

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
CC: Liam R. Howlett <Liam.Howlett@Oracle.com>
CC: Sidhartha Kumar <sidhartha.kumar@oracle.com>
CC: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>

---
v3: move change into mas_store_root()
---
 lib/maple_tree.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index db8b89487c98..03fbee9880eb 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -3439,7 +3439,11 @@ static inline void mas_root_expand(struct ma_state *mas, void *entry)
 
 static inline void mas_store_root(struct ma_state *mas, void *entry)
 {
-	if (likely((mas->last != 0) || (mas->index != 0)))
+	if (!entry) {
+		void *contents = mas_root_locked(mas);
+
+		if (!mas->index && contents)
+			rcu_assign_pointer(mas->tree->ma_root, NULL);
+	} else if (likely((mas->last != 0) || (mas->index != 0)))
 		mas_root_expand(mas, entry);
 	else if (((unsigned long) (entry) & 3) == 2)
 		mas_root_expand(mas, entry);
-- 
2.34.1



  parent reply	other threads:[~2024-10-18  2:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-18  2:39 [PATCH v3 0/5] refine storing NULL Wei Yang
2024-10-18  2:39 ` [PATCH v3 1/5] maple_tree: print empty for an empty tree on mt_dump() Wei Yang
2024-10-18  2:39 ` [PATCH v3 2/5] maple_tree: the return value of mas_root_expand() is not used Wei Yang
2024-10-18  2:39 ` [PATCH v3 3/5] maple_tree: not necessary to check index/last again Wei Yang
2024-10-18 17:43   ` Liam R. Howlett
2024-10-19  0:28     ` Wei Yang
2024-10-18  2:39 ` Wei Yang [this message]
2024-10-18 17:57   ` [PATCH v3 4/5] maple_tree: refine mas_store_root() on storing NULL Liam R. Howlett
2024-10-18 18:00     ` Liam R. Howlett
2024-10-18 18:12       ` Liam R. Howlett
2024-10-19  0:59         ` Wei Yang
2024-10-19  1:55           ` Liam R. Howlett
2024-10-19  2:38             ` Wei Yang
2024-10-18  2:39 ` [PATCH v3 5/5] maple_tree: add a test checking storing null Wei Yang
2024-10-18 18:03 ` [PATCH v3 0/5] refine storing NULL Liam R. Howlett
2024-10-19  0:27   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018023943.13860-5-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=maple-tree@lists.infradead.org \
    --cc=sidhartha.kumar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox