From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53BC1E7716C for ; Thu, 5 Dec 2024 15:25:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 490356B0122; Thu, 5 Dec 2024 10:19:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BB8E6B00CC; Thu, 5 Dec 2024 10:19:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F9B06B00DD; Thu, 5 Dec 2024 10:19:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34D1E6B007B for ; Wed, 23 Oct 2024 03:42:49 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 517F51C4FA2 for ; Wed, 23 Oct 2024 07:42:29 +0000 (UTC) X-FDA: 82704074334.09.DC836BA Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf13.hostedemail.com (Postfix) with ESMTP id 2CB9F20011 for ; Wed, 23 Oct 2024 07:42:29 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=f19CBwJC; spf=pass (imf13.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729669315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wXo43uDtjC7AWD0EX+yzMqBe11KZsQBWpM2baTsQIq0=; b=wxj1k33J81oIHwQ3todfmbHiUcG8BsGJ4sg9NOcTLSFm3/z5J2DWezFITSbVfC80g4W8jU 7ybYtJOCXS8UAKhN6GF0VeZ93SYY0FO5D4qZ2+d4kFbs93cJu5cYGkRzDFemcJWNHlvEhy GFyHdEtWeSZMI4bq+Jrz8GCrKt1uQHY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=f19CBwJC; spf=pass (imf13.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729669315; a=rsa-sha256; cv=none; b=y6iSXFnsF6r5oGVPsEzVX141y/oez4XfAIIl1QnLFFDnRWcBRkeIvDgwgACh/l83a3o3h2 S8bH8GGxJm1m8cChD6a/E/u+tVBDOCYMMBQzu8EwCKXaWzU31jaK8azTlE47KWThRKjxB1 yxG9qZPsaOCMIfHCNrBaUFUw7c22VjY= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49N0N3UD016719; Wed, 23 Oct 2024 07:42:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=wXo43uDtjC7AWD0EX+yzMqBe11KZsQ BWpM2baTsQIq0=; b=f19CBwJCe/YpMADqjM8IM4JHazG+LF3ZoULXe9LwM55mTA ySSmBfacZFfV7Th2W6cdx2mW286qOrShf+WS/B3jIKsB5VarOYtmJUmVW25aKWTK vVhMGzD+xn/NYyTuwUJWZXeNBztZ1dk6qz3EC1xyJGuxgCqujOgm9vMZvx9tSIjU v/yAMhMmzGKlB4EfRORrgMzLi79M4N+2bxHTvMFYQQgZbzwgehYkmxQWv0e5+pr+ vmaqr0SMDtOyJ/5UT8l7L5C6+5Mv/b2dlbVkvW/imNxHItIr0+weJjGtmCvt4NlF 1CsloGnPisq/tIx//XwtSupHXsla1J6/Ol7uQppA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42emajhug0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Oct 2024 07:42:45 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49N7dkuX031287; Wed, 23 Oct 2024 07:42:44 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42emajhufx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Oct 2024 07:42:44 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49N7UPss012603; Wed, 23 Oct 2024 07:42:44 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 42emhf9tfe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 23 Oct 2024 07:42:43 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49N7geZ334472700 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 Oct 2024 07:42:40 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48BE42004B; Wed, 23 Oct 2024 07:42:40 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2532820043; Wed, 23 Oct 2024 07:42:39 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTPS; Wed, 23 Oct 2024 07:42:39 +0000 (GMT) Date: Wed, 23 Oct 2024 09:42:37 +0200 From: Heiko Carstens To: David Hildenbrand Cc: Alexander Egorenkov , agordeev@linux.ibm.com, akpm@linux-foundation.org, borntraeger@linux.ibm.com, cohuck@redhat.com, corbet@lwn.net, eperezma@redhat.com, frankja@linux.ibm.com, gor@linux.ibm.com, imbrenda@linux.ibm.com, jasowang@redhat.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, mcasquer@redhat.com, mst@redhat.com, svens@linux.ibm.com, thuth@redhat.com, virtualization@lists.linux.dev, xuanzhuo@linux.alibaba.com, zaslonko@linux.ibm.com Subject: Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel() Message-ID: <20241023074237.8013-B-hca@linux.ibm.com> References: <87ed4g5fwk.fsf@li-0ccc18cc-2c67-11b2-a85c-a193851e4c5d.ibm.com> <76f4ed45-5a40-4ac4-af24-a40effe7725c@redhat.com> <87sespfwtt.fsf@li-0ccc18cc-2c67-11b2-a85c-a193851e4c5d.ibm.com> <64db4a88-4f2d-4d1d-8f7c-37c797d15529@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64db4a88-4f2d-4d1d-8f7c-37c797d15529@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: kv4ZkB2-Mf5jHWjN5aziPIG7M60YrAaq X-Proofpoint-GUID: xdOQijmQwUZDsrA_f6jHNlHs_qGV4-Kl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 mlxscore=0 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 mlxlogscore=643 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410230042 X-Rspam-User: X-Stat-Signature: 1zsn33z1ojedjy7dh1zdhtxbxo5i5z5d X-Rspamd-Queue-Id: 2CB9F20011 X-Rspamd-Server: rspam11 X-HE-Tag: 1729669349-693955 X-HE-Meta: U2FsdGVkX19qB3tknV8pcXDvWrA3gfEThfZhxGiwO/ogMr2kB1GeRK3A844RlT+bkDPq2OLGPyZBc2FkiYbJK1dCfTIs10tn+80qcCHk7uGbSwrg8KsKS2vGVjcyLyRmQSEJXYLg1mRs9B61fldNDqCcRy6ntRqSfQpVXIiZlZgqpjY1w02YgVIAktU953HZtruN0x+bLwtk94kCZSsPK17IDIh4+/3auCNHXQbR3Q5RkOx0/B4f4irEePLUU+2IdorELh5qfjrfRICWYT2gxPnJ4IsUMty1N7Yhz/Ru2NCMAy4p4rQZDAk33Jqyr40lhnAVpJ1G9/ISwiEL7JPKuJLFXY3gUEwXee8ArAa9Tf9SvtDTvbzJQhGNYVo9W1qMxQAA9EbRDv2ToR+QIXZgdDUy5n5DkRrVFIfL+K9osne2KPlCniYrXpFs2ZLrJXEiFmFUNR2JUOTcOS9rTZPSEwbf7qwN0gFG1L5942rrtXSRqsYRIzaKrfoBEiO9hvh0IVRZXM1kGBFSh6FO5q+h/VOhsuNY+hs68rtd0wAyNlJ1UfFz4HTtlc+PXkaGlWFlq8BPmkH1b2Ir5xeDI3GsxnmD/6mwmxr6h8SDtvMbPMKgg8zKpPzgF3OYQhwGvtWoZkV5RLdpQgRDAaTmOnV2e5WJ4PECkN5BvMVtaVkqAnnfpgXuY1AskReS2LQDHBZ84kDsZA6eZ/oeYY8g2y001jX8ogjTjEVGGQ0mglvf+g7CfQpfQMKGZhzJXlyly3Zz9kCcmqiBZKN5iqBk83DxZy0t0HzZrxW8d+UlMOwIWS+eSDyna9Ru7kZU/HMQOx93m940s7/ialbvPcAOntfrUJxeYqv2znXvgVV88OBzI8xXgzL3cEbYKSww+vSD1biPDRFsuofL0MwEreBI8lYGlf02bKKvNv+zmwTy1v4H39CpLLWwT0NOhxw7dIFaFtUCFV+V3oemtQaj6IhP5B3 vtvAFBZQ 0ZyboFXRgwFzY0hHpPoa/5BEnMCymaPoEpTP91qxTD3kQtl9T3Rvr2tO74e+0dstfJKxMue+y2NBjmAT1v2uzTGMwh4S1h+9ZaWZl3wDmnmMQkr4O3Gywhbe4rBg0TwpI+SWFb05TfYR4LeMpZ4McPmQ1t2ujKlnRsSy5rNz/P2am8EfLvBBt1F0nf4M0moVXSr57V8puyIHI2OCVH1q7fq4Rxn4pcEi4BJphAgI3zZUhU6GbxKi6zt0ToaKNU+QtcSzSKFzriyQNc4VkdtQKkNGPakjkfwMGr6AKnit//Pt2kII29dbnOl6t2N6u2SUtz2KFffrasDXpJi9trnAihK+K0xbkHT3x0hgPMVi4wdmMfKqn8K6STXHXBARtwT1AxEn4uZzCLHflHwA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 21, 2024 at 04:45:59PM +0200, David Hildenbrand wrote: > For my purpose (virtio-mem), it's sufficient to only support "kexec > triggered kdump" either way, so I don't care. > > So for me it's good enough to have > > bool is_kdump_kernel(void) > { > return oldmem_data.start; > } > > And trying to document the situation in a comment like powerpc does :) Then let's go forward with this, since as Alexander wrote, this is returning what is actually happening. If this is not sufficient or something breaks we can still address this.