Re: [PATCH v3 00/17] Provide a new two step DMA mapping API

Leon Romanovsky
2024-11-14T16:49:05Z

On Thu, Nov 14, 2024 at 05:36:22PM +0100, Christoph Hellwig wrote:
> On Thu, Nov 14, 2024 at 03:30:11PM +0200, Leon Romanovsky wrote:
> > > All technical concerns were handled and this series is ready to be merged.
> > >
> > > Robin, can you please Ack the dma-iommu patches?
> >
> > I don't see any response, so my assumption is that this series is ready
> > to be merged. Let's do it this cycle and save from us the burden of
> > having dependencies between subsystems.
>
> Slow down, please. Nothing of this complexity is going to get merged
> half a week before a release.

It is fine, but as a bare minimum, I would expect some sort of response,
so I won't sit and wait for unknown date when this API will be acknowledged/NACKed.

I would like to start to work on next step, e.g removing SG from RDMA,
and I need to know if this foundation is stable to do so.

>
> No changs to dma-iommu.c are going to get merged without an explicit
> ACK from Robin, and while there is no 100% for the core dma-mapping
> code I will also not merge anything that hasn't been resolved with
> my most trusted reviewer first, not even code I wrote myself.

And do you know what is not resolved here? I don't.
All technical questions/issues were handled.

Thanks