From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A370D6A228 for ; Thu, 14 Nov 2024 19:02:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68A296B0088; Thu, 14 Nov 2024 14:02:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63A6C6B0089; Thu, 14 Nov 2024 14:02:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5281B6B008C; Thu, 14 Nov 2024 14:02:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 39CF76B0088 for ; Thu, 14 Nov 2024 14:02:10 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E7B04AC466 for ; Thu, 14 Nov 2024 19:02:09 +0000 (UTC) X-FDA: 82785619350.21.7966B3F Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf25.hostedemail.com (Postfix) with ESMTP id 201ABA000F for ; Thu, 14 Nov 2024 19:01:35 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=be5W9GL3; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731610749; a=rsa-sha256; cv=none; b=J2XDXq/hIubAuFf0TsGUrGXeZO9WWg0/eltCrXuK/LwPoA9cN0LCnY9sMBYmetx1JU6tga o2oc9WtOlpjST7sMLPI/262ZXcnCRvKiOKUVnUTydBCgwPOkGrKYrtajitjo9c8Yn5qVAD PflIypc7iCxnQVi+m1U8vVeSqOiM4zU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=be5W9GL3; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731610749; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HZdQVFY93oH3zqek4RCXUBOZCfLTV52y/m5a2M+AnvU=; b=5z8FL5VNiC3lWFKe2loeC5SElyYy4P9XMKhvr08/3SacNHon3dh4nxLV1ywy8eA3en40Xx Y9Yv9B0ZUerOvBhSiLtBUrxckkSXSAzPvFbJb9CERMByGbx75d+ehU782pxM2XIZZFvH6E Omrpt3hzqUTwzElQBkKlWANarvVQhiM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 5A352A41A82; Thu, 14 Nov 2024 19:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC73CC4CECD; Thu, 14 Nov 2024 19:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731610927; bh=04uCFxNnoXHw8ZJOUz+3cpJZ7fV3XVyz75fxmcXtF8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=be5W9GL3BM4deoppqgH8P/rvqgjUlEVgER+YlMyTfRLegf8K/lLEK0BoSlOnB31CW KR01qC/dWq8rBf4jtKLCRkz9CT7GQZEAI8Xa/4sGAHtBsVRxKj71QWnb/6/xu2TJzP ww7ZJzEbRpc/dorJRrQ837+1SDERkWtqPD/8trcuDl8yYaY4ivNB+Cu1zKZnlCn5sH UGv/OaLARzEfrMmZukkppccakyXMZB3JTnLujxKU3lLFYy2nNJUkFGJ5i0ZxvU9SrM ifE/a+3ysYhdmjB4btmFfDGyO41/vgZzq+LqFB1fZhckTr+qZefSmcPU2o9BB3Pkid tWz2V5xLKUctQ== From: SeongJae Park To: Oleksandr Natalenko Cc: SeongJae Park , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Wladislav Wiebe , motiejus@jakstys.lt, vishal.moola@gmail.com Subject: Re: [PATCH] tools/mm: fix show_page() build error Date: Thu, 14 Nov 2024 11:02:04 -0800 Message-Id: <20241114190204.1486-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241114100140.406416-1-oleksandr@natalenko.name> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: gj8innr4mmuqs8r9uic7rr1wjhamrcth X-Rspamd-Queue-Id: 201ABA000F X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731610895-182640 X-HE-Meta: U2FsdGVkX1/QnU7mWNNPyMaWN0nrX77hN8Wt2kVCcAmVIzs5/B+TLBwI78qNko05pQw9vfQ/3vvt4jZ0iMjKaM50ad5ic3RKYhoVDVReMbT8fmxDQBpSBvJSwn8Z0e5pOKL+mr1VhrBirbd/qToWmaBi2DQnnlGrjTJgQH4FjLxs4rkh/5edR8+Sagh2QkO0D+5eYJP1URTjMIrX9u+jJu75N+aSEcXoAgE4mrw5gX7ngoYxe73r97MsTREkEAvFTchPqlULHLD7S9jaemEGCM5uLJ/mE+C/C/G3mZ8/wINDeOtokXgnj2WkRgw21tMAl27Q379Q65Krwk9R9K/UV3XMP4/zKbqAFEoVLqtfv2dZJ+5WVkncJikZYaqzP0yHr4Q+xzp3cctbGs7Vkf6eDeDgZbVEQoOUdJHsFNDzh5+Uc0HOXg2hAH0eMG1ciPFsyoUXinvu4qGLokSX/eIGtscaAhIrkaqlBDHee+stBLAqM7DRW2ctaZVMqzq3xBosAKQ9EL818ZrNOMUDmNJ3KSdiv3M1aWzo3anNq2wXDQPR8lR0XjZjT0qkE8DF1YBHycVkqU5oq1x7KidCIPNx0J/Kn470ANOy3chuvkMn5BMhgIzd9Gki+PDjP0rFxmwqBRK83uq3k+q4Pp1nWLsN7iMJKgTMtTIBP41N/IDiL0uNbuI2DmsPIoIFrZN5UPb168AvcBm8IuWAn7sH0Ixb1TQEj6q56fwpXuYb+5AzTkaaUoPSUH6AZ534FRrMKPe72G/kPu3fIJrLeC+jutLxeo5FP+Xv5nWbkMdHbtn70VihJaE1WUcpbSNRNviJQSGLuBq9YyIXu178fo6xtGQuxoXIo87KxuxRu7CM+2O9a2wrCnsWh0RrHhEKVo1WZ2d9paFELDaXnSQHmWe5EP4cJK7ETuVC3uVehCSmbTdW0xS4Ne+bQsIuFvucqXHU8ObQTK2gTd+EmnbcfDpR/DP mQBKhZGA 7qkghrhEtx4QW+UwWpc8KpQuSDghu1WCH4Unibetf4gfKz7nJyju1rJz/JvCxu9keCkQqVZKvjmpAHBoKCjpZYzOHfWbdH2ZtEpYSOh3P1Q5SM6kKrQzRqTsI2ORLyequjVn6wIzPqOG2lDE02+a3hKEiNu/n5AXTRU3ojxHbk3as3w79jGwnMI0vqM2aNfk4OdWrSNUfw4Zy4/nIJFlNQOunphJOEDjp7KWDEvaYbG1RycyI3VvDp96OAcPfH881sqskS1LjJGzjM0qs2ALFgbUbwucdz/aw0ymIQFpTTLfbtUqy2+4XdJzUhFO4dJMMeG/fCBnpFNxg+hwDvIsyjubQwfyFewCgd2+r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Oleksandr, On Thu, 14 Nov 2024 11:01:40 +0100 Oleksandr Natalenko wrote: > At one point I needed mm tools for debugging but couldn't compile them due to the > following error: > > gcc -Wall -Wextra -I../lib/ -pthread -o page-types page-types.c ../lib/api/libapi.a -pthread > page-types.c: In function \u2018show_page\u2019: > page-types.c:423:49: error: expected \u2018;\u2019 before \u2018if\u2019 > 423 | printf("@%" PRIu64 "\t", cgroup) > | ^ > | ; > 424 | if (opt_list_mapcnt) > | ~~ > page-types.c:416:65: warning: unused parameter \u2018mapcnt\u2019 [-Wunused-parameter] > 416 | uint64_t flags, uint64_t cgroup, uint64_t mapcnt) > | ~~~~~~~~~^~~~~~ > make: *** [Makefile:23: page-types] Error 1 > > Trailing ; was forgotten, so add it. > > Fixes: ece5897e5a10 ("tools/mm: -Werror fixes in page-types/slabinfo") > Signed-off-by: Oleksandr Natalenko > --- > tools/mm/page-types.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c > index 6eb17cc1a06c5..bcac7ebfb51fd 100644 > --- a/tools/mm/page-types.c > +++ b/tools/mm/page-types.c > @@ -420,7 +420,7 @@ static void show_page(unsigned long voffset, unsigned long offset, > if (opt_file) > printf("%lx\t", voffset); > if (opt_list_cgroup) > - printf("@%" PRIu64 "\t", cgroup) > + printf("@%" PRIu64 "\t", cgroup); > if (opt_list_mapcnt) > printf("%" PRIu64 "\t", mapcnt); > > -- > 2.47.0 Just FYI, a very similar patch has posted a few days ago: https://lore.kernel.org/20241112171655.1662670-1-motiejus@jakstys.lt Thanks, SJ