From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE04D6DDD1 for ; Fri, 15 Nov 2024 05:18:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D9886B0083; Fri, 15 Nov 2024 00:18:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 989BB6B0085; Fri, 15 Nov 2024 00:18:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 878356B0089; Fri, 15 Nov 2024 00:18:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6A7546B0083 for ; Fri, 15 Nov 2024 00:18:04 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EBD5B80179 for ; Fri, 15 Nov 2024 05:18:03 +0000 (UTC) X-FDA: 82787170536.07.BBF52A1 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf03.hostedemail.com (Postfix) with ESMTP id A25D020004 for ; Fri, 15 Nov 2024 05:17:41 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="h/u8Wnox"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731647818; a=rsa-sha256; cv=none; b=Y+m6xgYAtAVim3M8q32mct2ApTLfCNMogIfpYbnlHa+QUJQqA3PPOnRHq8K78ZpbPzLdvb uLInVmCXeBBAGtQCwGrKHt+TGVamK47WeJkfAYs0L35UykAPB4N/5njvB3C8uEiGNFUwI3 LIKkSk5xMGYaoDAnQw0dMMVFDdUAA1c= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="h/u8Wnox"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731647818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=me4snRXXF9CmZOhp8OgypQvWE0DJwZx3cMjOAaR4BRw=; b=0KpX3n5v66vbwMi/N7Iy4ah0dIAMyOb2kasAYmSZmlIV3WrYVgY9zkO3f/4zoUyjrt+wwQ T981S7uNusM4p/G6RD0oGGe0PCTt2NlKv/rVmDlv7MJl37PgQ/DlSfqz5yk0PrsFt26Tq4 IGokxRDnlPbPfUtUILGVtOuMU4TrZsw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7A40DA41E15; Fri, 15 Nov 2024 05:16:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84B0CC4CECF; Fri, 15 Nov 2024 05:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1731647881; bh=Ehk4DKAlNTYCDMCa+Ww5BRZ91YOtiCmTpS6hA99VBx0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h/u8WnoxdI9XUbGKKEPv/U/7DnOMufmGhzbSIg8cooEuFD6sRJ9mVW0AgKofDzJtq oJxfkrutSEh/d875Lh03JoGfM2YWHdScMzagDPIRAmd3bULtlyAADBaqyaDhYvU1KM 2zqPlsPhfWRUVdYv0VJ0cNcBSkZeIU49Xk8tC3PA= Date: Fri, 15 Nov 2024 06:17:57 +0100 From: Greg KH To: David Hildenbrand Cc: Vlastimil Babka , stable@vger.kernel.org, Peter Xu , linux-mm@kvack.org, Yuanzheng Song Subject: Re: [PATCH stable 5.15] mm/memory: add non-anonymous page check in the copy_present_page() Message-ID: <2024111547-tying-selected-6a5e@gregkh> References: <20241113163118.54834-2-vbabka@suse.cz> <99a77c9a-68ca-4445-bcbf-4681ca20a482@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <99a77c9a-68ca-4445-bcbf-4681ca20a482@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: A25D020004 X-Rspamd-Server: rspam01 X-Stat-Signature: g6qmw84fnu5i5yiqmjnr78s51yda1u38 X-HE-Tag: 1731647861-191582 X-HE-Meta: U2FsdGVkX18S73NKpPcT7MA9WuUMuzEKBTyuFhUtz7Sosxh0YmU4BefDJNRk5a2rXJALzN90kZEo4V3Uzg2VfRcluT2dRWqUoE9t9aUMk9Ca0niasMH51r8TKE+DvE0AUgRncL4ut2lu/pCLRa1EukDqDlgiFgQpoNU8riYcVW5rGzucSj+w6Y7INfnn0FE0zHUZrGddXokqrsKfU3qf8aDOQV8hBY/nWDnajRscwh0TLLotecewUn5baYvb8GDDGZKKq5d4PZf/M1NBe0amOAU7rwrcxuEaTzbzcVqx8GyPsqni9fUi4XpgJwSQzktU3dFV9VOCpo5BGwF01uUVn97kdHIwHSC08jr5ZgZL4PmDv6x9LX/3dDhqWBH3IewHnVpFf2ZuU5B2a7yGjSZd6ejQ3WMzo9YzFDj+HLNfIwMngqWjdOUtvD+UHhlo2Sn8fxMBH0P7C3tmzWcs7cGUFsWLtrRilnlQyAsBsE58W31Z+LyV31QJ12EsSwrK8pZn8Qzvfbx+zGNGvOPHIGSYd9g+tISbGJVWOf8x92fuVNG419kCeXcXF6N2VdsPfBxhRCzxnY+VsMZv4vlRg7i7d9QepFyhMS70ok2oLnah20RC+lZLzWKQTG+dDxsm6HzUE1krc0fZLYsKi/UZZFW+BnCRt8qwKSOpzFXgR6xgWBBy4JWpuNhnECWXshVv+8z5ArAMmabVrPwSFM6aFQynmjR4cq7jh34JJ3INaGWA0gp77JVyR4Pc8bPf3IYLaavu1BcDbmWnucSNFICCpO3TGaJsSn+THkr6WzUfvmQz6ZWngqgtSk9a/gr22PFMg3AxeL8siwxgyoHwXTtEWoG8iiO4k7vzD/Cs+t/4pxcYdH/WeD0QJ3/RixRoSvosWclurRIL43Drx3umnvglaeUtjF3fT6aQcgrBDfbVe1yCCRDp2QgfnrbTSkkExQTOoEiu1bl1TwTuOCEGGhUQMHx m8tH7XYe hnkAdDLdNrQsNoNcNDVr3MtbBwXm8JEgQorB6FYArIAi7WUhm6bAHKpdjIoAN3pSb8cCBpI9IctWd8VQT/HO5QXGl7AHe715Fc9d/jA+1MTtNT6KuFdDQdw6FTEntxN6BKU7YF0RjJgV6+7r3eh9K2PZuayHmA7fy9IYp0ScbZ7txXqGWscUsOj62IH4Uq+D41Gc8ZW8Z6bgUjq0Rf5t3nHk4aMzNTDqjhI562HoPzEUSKaChN02H4AYT6vIFeAtZLbHBW9x1sf6GjhOgjpQBsAY3sSoFa439T24Gwj3pFCstM8cUcgLIs2OjaWurJlX/wLi1Z8iBbVbMksDdSN8TLdJMaDl6cuB8ufmlx1Kt1c6aJl4oZRzGhaw8PjNHNU65/QMEGkqEHafuggb5jfLSyhqMGLg3d+2NbjT+tU+u4sKxentm6WuTpQz9wA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 13, 2024 at 05:45:43PM +0100, David Hildenbrand wrote: > On 13.11.24 17:31, Vlastimil Babka wrote: > > From: Yuanzheng Song > > > > The vma->anon_vma of the child process may be NULL because > > the entire vma does not contain anonymous pages. In this > > case, a BUG will occur when the copy_present_page() passes > > a copy of a non-anonymous page of that vma to the > > page_add_new_anon_rmap() to set up new anonymous rmap. > > > > ------------[ cut here ]------------ > > kernel BUG at mm/rmap.c:1052! > > Internal error: Oops - BUG: 0 [#1] SMP > > Modules linked in: > > CPU: 4 PID: 4652 Comm: test Not tainted 5.15.75 #1 > > Hardware name: linux,dummy-virt (DT) > > pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > > pc : __page_set_anon_rmap+0xc0/0xe8 > > lr : __page_set_anon_rmap+0xc0/0xe8 > > sp : ffff80000e773860 > > x29: ffff80000e773860 x28: fffffc13cf006ec0 x27: ffff04f3ccd68000 > > x26: ffff04f3c5c33248 x25: 0000000010100073 x24: ffff04f3c53c0a80 > > x23: 0000000020000000 x22: 0000000000000001 x21: 0000000020000000 > > x20: fffffc13cf006ec0 x19: 0000000000000000 x18: 0000000000000000 > > x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 > > x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > > x11: 0000000000000000 x10: 0000000000000000 x9 : ffffdddc5581377c > > x8 : 0000000000000000 x7 : 0000000000000011 x6 : ffff2717a8433000 > > x5 : ffff80000e773810 x4 : ffffdddc55400000 x3 : 0000000000000000 > > x2 : ffffdddc56b20000 x1 : ffff04f3c9a48040 x0 : 0000000000000000 > > Call trace: > > __page_set_anon_rmap+0xc0/0xe8 > > page_add_new_anon_rmap+0x13c/0x200 > > copy_pte_range+0x6b8/0x1018 > > copy_page_range+0x3a8/0x5e0 > > dup_mmap+0x3a0/0x6e8 > > dup_mm+0x78/0x140 > > copy_process+0x1528/0x1b08 > > kernel_clone+0xac/0x610 > > __do_sys_clone+0x78/0xb0 > > __arm64_sys_clone+0x30/0x40 > > invoke_syscall+0x68/0x170 > > el0_svc_common.constprop.0+0x80/0x250 > > do_el0_svc+0x48/0xb8 > > el0_svc+0x48/0x1a8 > > el0t_64_sync_handler+0xb0/0xb8 > > el0t_64_sync+0x1a0/0x1a4 > > Code: 97f899f4 f9400273 17ffffeb 97f899f1 (d4210000) > > ---[ end trace dc65e5edd0f362fa ]--- > > Kernel panic - not syncing: Oops - BUG: Fatal exception > > SMP: stopping secondary CPUs > > Kernel Offset: 0x5ddc4d400000 from 0xffff800008000000 > > PHYS_OFFSET: 0xfffffb0c80000000 > > CPU features: 0x44000cf1,00000806 > > Memory Limit: none > > ---[ end Kernel panic - not syncing: Oops - BUG: Fatal exception ]--- > > > > This problem has been fixed by the commit > > ("mm/rmap: split page_dup_rmap() into page_dup_file_rmap() > > and page_try_dup_anon_rmap()"), but still exists in the > > linux-5.15.y branch. > > > > This patch is not applicable to this version because > > of the large version differences. Therefore, fix it by > > adding non-anonymous page check in the copy_present_page(). > > > > Cc: stable@vger.kernel.org > > Fixes: 70e806e4e645 ("mm: Do early cow for pinned pages during fork() for ptes") > > Signed-off-by: Yuanzheng Song > > Signed-off-by: Vlastimil Babka > > --- > > Hi, this was posted in [1] but seems stable@ was not actually included > > in the recipients. > > The 5.10 version [2] was applied as 935a8b62021 but 5.15 is missing. > > > > [1] https://lore.kernel.org/all/20221028075244.3112566-1-songyuanzheng@huawei.com/T/#u > > [2] https://lore.kernel.org/all/20221028030705.2840539-1-songyuanzheng@huawei.com/ > > > > > > mm/memory.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index 6d058973a97e..4785aecca9a8 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -903,6 +903,17 @@ copy_present_page(struct vm_area_struct *dst_vma, struct vm_area_struct *src_vma > > if (likely(!page_needs_cow_for_dma(src_vma, page))) > > return 1; > > + /* > > + * The vma->anon_vma of the child process may be NULL > > + * because the entire vma does not contain anonymous pages. > > + * A BUG will occur when the copy_present_page() passes > > + * a copy of a non-anonymous page of that vma to the > > + * page_add_new_anon_rmap() to set up new anonymous rmap. > > + * Return 1 if the page is not an anonymous page. > > + */ > > + if (!PageAnon(page)) > > + return 1; > > + > > new_page = *prealloc; > > if (!new_page) > > return -EAGAIN; > > Reviewed-by: David Hildenbrand Now queued up, thanks. greg k-h