From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 412AEE7717B for ; Sat, 7 Dec 2024 19:53:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7F356B0357; Sat, 7 Dec 2024 14:53:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2F396B0358; Sat, 7 Dec 2024 14:53:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91D9B6B0359; Sat, 7 Dec 2024 14:53:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 744E76B0357 for ; Sat, 7 Dec 2024 14:53:47 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 20BB1B0802 for ; Sat, 7 Dec 2024 19:53:47 +0000 (UTC) X-FDA: 82869212706.30.51E8C4D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id CC273140008 for ; Sat, 7 Dec 2024 19:53:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I91hPp31; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733601212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a0m9A+0TAntWx/4PnkUIWgBpP70wc0XkVB8T50G6R5w=; b=HAUPF9gCb+/xvk+4OYxWjdUh7eLZgTHH6ZatPmHJfFeOLvzctDXrV5GFxL4Qu3+VfXOeW6 w1muY0E43OpawVvgubDj3t+5T9HsaPcvjOMLuCKYhaUsGNjwWCteagyo7pPtNZ8z8h0FkS svGcPCEQ3iZI7tsbM649Mu9HoSYW5vw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I91hPp31; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733601212; a=rsa-sha256; cv=none; b=Yzg6a3M175I7kuITHIsSAWZBRq7F8Ij5DD9m12PY2IkAEHCuIIXpOmRl4BQ2OZITNYyveX oFMA1zrQ40QzHjPoVkriSNiBcvEJuJ6AlG3Yk/byVu38Mu8y6Yd05E9G1ZBJvk31Bt0r6e z81BsLYymazheX7Tq3Yd/wdMNho273c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C3DF35C54BF; Sat, 7 Dec 2024 19:53:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE75FC4CECD; Sat, 7 Dec 2024 19:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733601224; bh=uiWNwCAU1Ek1lr+t0M6XPgbDqA5vrC17dsi7zbgeCVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I91hPp314DXk4zsq/ROKlM6JiklpZEhUm0Gpyo5mFtGkUtzoJboF1tHB9R4rfE2Sm ekN8GZDYYJe9f4gHgAlSvuGigs1fvtRaNhFHkjczej6dEtZd7pIQH9qEXN9xCwXWDD /SgUpOl36jNm9+9MibQsDTcjCmLZR5nMXCCJdOB2XJVPU3oRA2QoX/rpVjCKtVrwW3 d2voHVERtJdMBc2phucZahlvQyyl0LiPN3sV7MDxhlBpnwixVoaneoNpHJhGY2z4MZ 3CQhjD8Qt+CrRrbjGcL51bdqqB4xrHToEDBYAB0e3b7dNEOg4ybTOfWvRgGDw7zUm/ 9z2yIJnajpvdw== From: SeongJae Park To: Junjie Fu Cc: SeongJae Park , linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, willy@infradead.org, mhocko@suse.com, gourry@gourry.net Subject: Re: [PATCH] mempolicy.h: Remove unnecessary header file inclusions Date: Sat, 7 Dec 2024 11:53:41 -0800 Message-Id: <20241207195341.279560-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Stat-Signature: 5b7uuh7sipujzrdpqwbz9q3p3a5sceks X-Rspamd-Queue-Id: CC273140008 X-Rspam-User: X-HE-Tag: 1733601212-702618 X-HE-Meta: U2FsdGVkX1+q4rlBZqH7M5uT9VaAeIciID+KsF1xOekQcYTQSHXKKiUxyl/fYYcMvs/DSE+GU1TEL/lvLpVPvKtU/a5i0VyLF6bHongWoZi1zhymYlmNJHrZM/Ld8SBc+UBB+86w559BeuyJLOct1wYe9RlmJkr1jjfTEO1Lm9MjHa0G+ay1LnPsRstseFQc3OCGzeKSWr7qHB6lu0IvYruCajN9lDJ0w5MuJkIumh+j22ddlQfjDkbYQGr+lH/WcfMhBGEJRcHD8XP6QCymkOGKdBj7hYx/pryx53Gv0YuHGpDLTK9+9zkOC4CZD/KnRH2kbbozeyOMyvK2lQKN0tNlP4fw0Uw8HVDDDUkhp8KIwRBwHwfAhDcuUBq/HBiN1TsdL/yuE/onYrOxb+3iB6DdmUWRHljNbprFO1DpTawMlG/KAdPKJhPeg0H/IB6C/bAKKs9AhWQQjqC/261OFLvxvvAE8bkBZh+oBQhjtlvtL+uIdjZIdSrz4MQkLN5tGEsAIXOcQJ6c4DEHMqMJcaHk6vFjI/K4LBHHVRc7WsOl74cWxGtGnKEKrGTVdPSesQEBbgV6WUIU5d8/3+NfTmx1kxy21kmLlrSvnzrsmiWQnmP1zwGJdUpM2oISEJkf37CRnYqMY4EHSS7Qe72lmtEBwA2lyNRvCEcS0YiBL7+J31S8+JlwPXzmihzW1MtF4Z2njy8b32tr14GxE+JJejaJfbCztNY7MyRbyk3Wsy9fS+Y/xxzM36555NXiBfnFIeS3gqsv5bmqJ93CVAsBcbg0V1MWOPVWyZC2ac5AGY/20DzN94hHaOe5og0XX7I2w0/PsXD/zNj8mQD9ZwupcWt+dh4IOi+0gaI3hQD6RYnRmOU4ousPXCPW3DoSEcLx4pMRBrisk5yVILjlSSr/KJ94hC6FLaF2VEOHW8SgVAj2EwUEFzX3xySYT1qRI0ymur/X1PglsKG+oTNSkr/ ZQC+G5JV Bj181D8VafxLoz+FiUakzp/3NMdsD7hMprdLht5+6EfB/nEIXXzpNpSpYLjXZ1HiT0r6moWMPnvIQqhuA15P7LVDY9ysYINizQCZlBuHzqwrwYz/9wgUC9D2r144z9cWaujodBmACv3fmcd1GJc94xHxo2NQAUTAgqHvIyP+iIavAoQbSHHWR2CWsgPYAU9/Qh41azu59/XnXXb5f1V8cfHf5Uz+TP6L2kirAuA0K2dI2PKW6coGzdpxuP6BvYwpZuvqdYg7I3l4Gqpg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Junie, On Fri, 6 Dec 2024 23:53:49 +0800 Junjie Fu wrote: > Originally, linux/mempolicy.h included linux/pagemap.h because vma_migratable() > was implemented inline within the header, requiring mapping_gfp_mask() > function to implement vma_migratable(). Now that vma_migratable() is only > declared in linux/mempolicy.h and its implementation has been moved to mempolicy.c, > the inclusion of linux/pagemap.h in the header is no longer necessary. > > Additionally, since mempolicy.c includes internal.h, and internal.h already > includes linux/pagemap.h, so there is no need to modify mempolicy.c after > removing the direct inclusion of linux/pagemap.h from linux/mempolicy.h > > Signed-off-by: Junjie Fu > --- > include/linux/mempolicy.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/mempolicy.h b/include/linux/mempolicy.h > index ce9885e0178a..d36877557b00 100644 > --- a/include/linux/mempolicy.h > +++ b/include/linux/mempolicy.h > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > #include I noticed kunit UM build errors as below on mm-unstable, and git bisect points this patch. $ ./tools/testing/kunit/kunit.py run --kunitconfig ./mm/damon/tests/ [...] fs/aio.c:525:71: error: ‘FGP_CREAT’ undeclared (first use in this function); did you mean ‘IPC_CREAT’? 525 | FGP_LOCK | FGP_ACCESSED | FGP_CREAT, | ^~~~~~~~~ | IPC_CREAT fs/aio.c:532:17: error: implicit declaration of function ‘folio_end_read’; did you mean ‘folio_test_head’? [-Werror=implicit-function-declaration] 532 | folio_end_read(folio, true); | ^~~~~~~~~~~~~~ | folio_test_head [...] I also confirmed including pagemap.h on fs/aio.c as below fixes the issue. I would like to hear you or others opinions though, since I'm not familiar with the inclusion routes of the file. diff --git a/fs/aio.c b/fs/aio.c index 50671640b588..9fad51dc823f 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include #include Thanks, SJ [...]