Re: [RFC v2 09/11] block/bdev: lift block size restrictions and use common definition

Bart Van Assche
2024-12-17T21:00:46Z

On 12/13/24 7:10 PM, Luis Chamberlain wrote:
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +/*
> + * The hard limit is (1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER).
> + */

A closing parenthesis is missing from the above comment.

> +#define BLK_MAX_BLOCK_SIZE (SZ_64K)
> +#else
> +#define BLK_MAX_BLOCK_SIZE (PAGE_SIZE)
> +#endif

Parentheses are never necessary around constants since the definition of
the constant should include parenthesis if necessary.

Thanks,

Bart.