From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8933CE77184 for ; Thu, 19 Dec 2024 18:43:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F422D6B0083; Thu, 19 Dec 2024 13:43:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF1416B0085; Thu, 19 Dec 2024 13:43:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDEB96B0088; Thu, 19 Dec 2024 13:43:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C3AAC6B0083 for ; Thu, 19 Dec 2024 13:43:07 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6288242B0D for ; Thu, 19 Dec 2024 18:43:07 +0000 (UTC) X-FDA: 82912579764.30.5E1FB34 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 9675D160004 for ; Thu, 19 Dec 2024 18:42:43 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="fW/L2Nsx"; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734633770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1P3YrQ9brdrHGT4fxFDdC1MSBldmO5RmS3tsZEo2gTE=; b=jGL4/rY9MsA5lkN9md+7TBctLy5UPQYUijpJSAIV7lZAUZSOMj6APxPYvmNpZnVdU8IDJU XxAC+UH/EUipAuuzL+teZd+4pjDHtR/rx7sLd/kDEQpPgLDkjy2vk9mYzQ3Ze3rLhxt2je zzJIDL0ReVjEMkld6ab0l4J5rtFeK+s= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="fW/L2Nsx"; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734633770; a=rsa-sha256; cv=none; b=68dkzFxTazIevYWn64zwzokoSNIjRtSr1BX5TwZ9U2+bhlvWnlH60I7OAVVmLa6YBgajX5 fHQTa6fgTd6FOBMQhyAuraMOxleVt7/HP6YkQJFqrpl5tOvATSrTgN90NqYvuO7mQn/MXt AH212AfCV8CUNPjROaxVE2Qrw3Is0X0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 63D74A42873; Thu, 19 Dec 2024 18:41:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BBD6C4CECE; Thu, 19 Dec 2024 18:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734633784; bh=mKNSTQ0nCK2Xknz+TuQ8UROuFq8WTO0dLrlz10TFyNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fW/L2Nsxf6w+J8agIFM1jHCwVwXmTkstwwrKI5xzRsWvlRdx34A7HKO8V1jkqAPxv 42yQvHzeEcQkd3ujQnTX1Yr8dmmqW/VYeuzZoYKj8pxM/ofXAkFbCq0ncaKlyCPp7q 8K8x4Ft1grDCKECOIm7Yf+VlkI3uAMHb8YiunvaGb6NZVyLgXH0Pw81plVyWW4/czZ rOmVYMuJz8vZzH2JPLiC9XxshG9MnmyDhU3G8cXZHTgj4+O5qPWYkoP+6S5PmA/Ape F1x61mwdD82bRrHGpNdKBO9ZwO5GY22xRv7Yt9Ciw87N+YDBs53N7/N/JkKBGBH9RA I937KzlVHs61w== From: SeongJae Park To: yangge1116@126.com Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, muchun.song@linux.dev, liuzixing@hygon.cn Subject: Re: [PATCH] replace free hugepage folios after migration Date: Thu, 19 Dec 2024 10:43:01 -0800 Message-Id: <20241219184301.63011-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <1734503588-16254-1-git-send-email-yangge1116@126.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9675D160004 X-Stat-Signature: at7qpprmzgbxt833oardbjqco3wknc5p X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734633763-289785 X-HE-Meta: U2FsdGVkX1+cypnR6K/D+TvkF1n21+BHYXWzyDnxP+SYQEkBFTOup/x65lcxK0ICXNDOwKEDcWt7yO4aMfP5ZlIcqEU5IWQ8KANY2rQlrO1F3tJlqYd8NXQqUBTNKQohVlUc0XYX5Yw/7plXrg8jOodzcfdCB+s5rYYDuxTRg+KzjtgK8XokYDS70cXJXW8FttQtkaEwzJ+0i2v/JaedSzBVwRBO8d0lstY9SVhnvOSwzEeOIFVgO7D+VGGSKC9O+ztF5MjJz1HDb/Q9vt8KbX+8KqVHaWnqxRKoraW4KMjCNquM0IZvzOzvj69XfKYd1Aj6ed7hfRI3G907puzkJT68MJ2yQdkpKZ+epKQg2feKLS6FG+Hk4ubQq2M3DXeLnV8zLwPHqr2E3fJqR7WEYwUfxDHgU9CLHRrMffuefrxidqjZuVw+CiAhUleVkYQBUuLt/nbnEgRNyfCI6oP4QDbWd6JHp4jlvPnEkK2rkRf7FDUhQwiZVSKKb7Zm4QdGPPZSr2pHg79D7qrpA4f73PcFuT1WUlZnh5ORNL/clx0GjJpC7v9A8jXl6kIm5Unmg1LQezUcrL3HEziDkplYpUzfR0iJsqfpfF4aur67PBYgIFmJ6KP5xvSt9mOat9R6/Ut4DYJOJE+g422J93qmNMnJLj+fRh031TiA6Ik+QPVopcoYyKyj1EMJfpf2mG6nEdM1ICZbewEr9FevOKyS2Ik2Sbi6tSUJzQj18/JRlu6JWNrHTIw8ZR+e+44a3acCQG3dW/Uil1iSdPy354s70fH/ZeqytZGDA4ccNaW6KLf3GOF227QmidgDyH0tJTX9oYa4zBIx56efmIqRFtQ4dmAbMuzAVSHmBKhlW05BS+yNOMx7+EUxe39mLFtqot1r5PNX+7plRCbbv+0a6ScHsvO6Fib1UyMBFEUDFr63Lm9v1mWyp7BrsD4Yng1oZYxRFZx8Terw/+7YF/CdOAW Kh1Wo8jX vMgsruMar/hGPymEnHI84QJmKKRRIugjK3jyAAbwgFqEi/HuX+FJaUCa81GLpe+ny5gdXnppbZujfRE8owGWN9nQaWhlQIwPxl6BTkX3I0aRIv+lP87vMdhA+1bR83BOyZmZGtvh75hpQitkrbRMaw2fGYxRbSJT8zhf0zQrWdnXLZzpn7RwIvCNzYeOKRkGYEpVaYtIqnjZY1es/FivMvKnjrgcWzrWyqN8Dg09ne9wq0rS/wKVLwMsVPdCiAJqgPcMXrpg32rTrlpn6mCjHMbUtAdmryisZ1dau X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Wed, 18 Dec 2024 14:33:08 +0800 yangge1116@126.com wrote: [...] > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index ae4fe86..7d36ac8 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -681,6 +681,7 @@ struct huge_bootmem_page { > }; > > int isolate_or_dissolve_huge_page(struct page *page, struct list_head *list); > +int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn); > struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > unsigned long addr, int avoid_reserve); > struct folio *alloc_hugetlb_folio_nodemask(struct hstate *h, int preferred_nid, > @@ -1059,6 +1060,11 @@ static inline int isolate_or_dissolve_huge_page(struct page *page, > return -ENOMEM; > } > > +int replace_free_hugepage_folios(unsigned long start_pfn, unsigned long end_pfn) > +{ > + return 0; > +} > + I think this should be static inline. Otherwise, build fails when CONFIG_HUGETLB_PAGE is unset. Since this is already merged into mm-unstable and the problem and fix seems straigthforward, I directly sent my fix: https://lore.kernel.org/20241219183753.62922-1-sj@kernel.org Thanks, SJ [...]