From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF8FDE77199 for ; Thu, 9 Jan 2025 17:42:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D2878D0002; Thu, 9 Jan 2025 12:42:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 481838D0001; Thu, 9 Jan 2025 12:42:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3220F8D0002; Thu, 9 Jan 2025 12:42:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0329C8D0001 for ; Thu, 9 Jan 2025 12:42:18 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 98DE9A031C for ; Thu, 9 Jan 2025 17:42:18 +0000 (UTC) X-FDA: 82988632356.28.7B4FDB4 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id EE12880007 for ; Thu, 9 Jan 2025 17:42:16 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ZOtnMP/o"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736444537; a=rsa-sha256; cv=none; b=MBKvAkpdSktU50ao+fCRU5e3dnwa3bYDkuH/vMG8WvI7ZuYDVZk+n184MVsOm130XEOswV um0zT5wIg7gnqeDXmSs2J4BAc//vLmcZhnIAlUb6Z8+8lsfaZaINkXH8KGyS63iFe21PrB dkQTH0QrKd5hJIPFnBQmTDf2Oqq5buE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ZOtnMP/o"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736444537; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hIe9ikcmO5HZpimDEfpcSJbbPNHnXXgDMmbcR73fQyM=; b=N8WAoYRg5yZv1ZDHJJlVlxR/S4SM1ppO8oX+sBuVWYP81Wl19FXRjy6Fs3/Urff9fOD+42 aLhsF/ph2k2p2lAUuKJUQMvBNGxreIy8KVzOLTi9Lp9UZ//amX9/N3UhC3sWvr898ovzsp Vu3Oawuqmcw9WC9bBSI+xEbobBS0JHQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9EB2CA40492; Thu, 9 Jan 2025 17:40:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB4C7C4CED2; Thu, 9 Jan 2025 17:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736444535; bh=Us90W3iK3EMl2dQQtMx3D2gQ07vdM1nJz7lej6pS6zQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZOtnMP/oO3McloFa5SLz+G9ZVljZBA0nqYnJaei5CtAsRQhUdXICmBBb/nCFIIgov Inkg4DhWFNFEgtWp5hQ3yBG+MHE4r8a0tD2weniDe8QvaLDeQ2LYPoAGL0X1/ei+to 6caOnkcawbG8Ps6CmvKVNkRbDMNiDJV7F9Hg/5P5T58hWAdlJ4otKcGr979EjvLxar pW2sAFYQwV8ZasIygrNkuafNhH2NA6dIHdCLMjW3CnxjWZngK9fQhenpvVUCEdwXS/ 6SRMru53hhYFyN924zPkl/leMURMaRI+eP6ZQ2Ki++wT+ojM9RYQteepsOvOzf6Rjk PZipONnIClKGw== Date: Thu, 9 Jan 2025 09:42:12 -0800 From: Kees Cook To: Muhammad Usama Anjum Cc: Andy Lutomirski , Will Drewry , Shuah Khan , Andrew Morton , =?iso-8859-1?B?Suly9G1l?= Glisse , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters Message-ID: <202501090941.5289E7444B@keescook> References: <20250109173842.1142376-1-usama.anjum@collabora.com> <20250109173842.1142376-2-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250109173842.1142376-2-usama.anjum@collabora.com> X-Stat-Signature: 69hwh8izng35onnor9h6segj58n74gxr X-Rspam-User: X-Rspamd-Queue-Id: EE12880007 X-Rspamd-Server: rspam08 X-HE-Tag: 1736444536-851189 X-HE-Meta: U2FsdGVkX1+hzvwcxXylzZs6vBd4NZE8k1wFQGzN5VQhGCxJinP2WY5XVwj7PzxjIiPG1c+Fw+C1+L2eKyWjmMdDbXMeguuZCVjbHgukRFMUr9QJaqVOH8yDXqPxBWGJkqtWHZpkEbDLkzx0v+k82/fWTZ7o3OYllTYFrsIgpX6Kla+UU/mIinHUFzCP6iHyHlUuJVYE5W2n3QEIfg3/wBu/dnyaqV2LnB+IM1nU6lw5oxBMDTopMnEng2U8za4y41K/zQbIgnmtVKDSJls3j1aBaR58+holXzWW6tesbfHtKvK2NJ3/EAYMbmfCNFuV3Q2mh4O1J/KCRoGRdVYzJNq+kutl1TiXAGhYuTQf16zo5BPWTBPT4ane5hXI9e7czExCooaU+VcFAcSjhErdyNmFLzXdv0geeJdnwaTwAmJ8XQuaBNSD/UmuoCGY+S0N4tjCFJXUszPlNyLy30XqqdHy+ieq9aumP9uzgLCt2y1c3+E71EjVPsOZlWqNAJTABUnCcgbsOPgOEI2eAwdt/LoV3wNFT1WPB5OIqXYpzWdoKJi6TUm24onYTPnG3V3lY3ymXSPH0XZwWiUC6312JANWzRp2lCy+kAFfrID8OndqBS2oj2OpY1kEqhGr7QrnqiEI2O9Iz8mxA3DXrcQDHr8VdpPZi/FfSRHeKrfXCWYE3S+yj5PZNT56oCbwCGXbT0bAfvb344z/DesG6hz99maEdlIT10tzv0lteYsB8463nn2jQiaU5E4lmnlLe24CRixGIZrvnW9HJ2OY2nA4HIXB5fE293xOAevSzuJpf8PydH2aWvC02jyDNDhcki9YTn7COOr4B4qj9QiI7ICC51vOoyfWy6iQ8Sm6ZPf23smt0rH1NZQqHLRiKx4ZN2y3/UHKPuqPc07xsM3Mve2KmMkE89vdJnzB20uVeymO4ldMH1yc86S1CuFsjbDAFQAs+22/L/xCmqXWfTh90WI pG7nIowN md1H4OHuCYT5HlQA+tJwbLVCjrUiTDhz/nKVeTnE2TuKXV0liUf8m/2j0yYIIEnQnmg/6kFHP7lnbihf8JfK+z80c6yHXJsMwX3Qoouu5KLkGMOc2TLEp22z6J8Otdn5zR2e8FpRR69QiKmZSsLaxwzQvSvAogOzhvJ4SMcwA5cX/M4ap7g6IwJ7AQXp/p1VEaxhgGJNmcS9fVo04ahSUHGx+9YuCuAK9A5Lcj0pCJdPe2QnypB0ViTjmsc5oTUhvjRpmn8VdYgia8B5Dja7DHc4hAeVpJe2H8ybkYInKK7g/U+Ch1GVLoT/Da0kFGZNXsUWW0NKyH6OvcCrYkq2pxHJxyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 09, 2025 at 10:38:27PM +0500, Muhammad Usama Anjum wrote: > Remove the following warnings by removing unused argc and argv > parameters: > In function ‘main’: > warning: unused parameter ‘argc’ [-Wunused-parameter] > 158 | int main(int argc, char *argv[]) > | ~~~~^~~~ > warning: unused parameter ‘argv’ [-Wunused-parameter] > 158 | int main(int argc, char *argv[]) > | ~~~~~~^~~~~~ > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/compaction_test.c | 2 +- > tools/testing/selftests/mm/cow.c | 2 +- > tools/testing/selftests/mm/droppable.c | 2 +- > tools/testing/selftests/mm/gup_longterm.c | 2 +- > tools/testing/selftests/mm/hugepage-vmemmap.c | 2 +- > tools/testing/selftests/mm/hugetlb-madvise.c | 2 +- > tools/testing/selftests/mm/hugetlb-soft-offline.c | 2 +- > tools/testing/selftests/mm/madv_populate.c | 2 +- > tools/testing/selftests/mm/map_populate.c | 2 +- > tools/testing/selftests/mm/memfd_secret.c | 2 +- > tools/testing/selftests/mm/mlock-random-test.c | 2 +- > tools/testing/selftests/mm/mlock2-tests.c | 2 +- > tools/testing/selftests/mm/on-fault-limit.c | 2 +- > tools/testing/selftests/mm/pkey_sighandler_tests.c | 2 +- > tools/testing/selftests/mm/soft-dirty.c | 2 +- > tools/testing/selftests/mm/uffd-wp-mremap.c | 2 +- > tools/testing/selftests/mm/virtual_address_range.c | 2 +- > 17 files changed, 17 insertions(+), 17 deletions(-) > > diff --git a/tools/testing/selftests/mm/compaction_test.c b/tools/testing/selftests/mm/compaction_test.c > index 2c3a0eb6b22d3..8d23b698ce9db 100644 > --- a/tools/testing/selftests/mm/compaction_test.c > +++ b/tools/testing/selftests/mm/compaction_test.c > @@ -194,7 +194,7 @@ int set_zero_hugepages(unsigned long *initial_nr_hugepages) > return ret; > } > > -int main(int argc, char **argv) > +int main(void) > { > struct rlimit lim; > struct map_list *list = NULL, *entry; > diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c > index 1238e1c5aae15..ea00c85c76caa 100644 > --- a/tools/testing/selftests/mm/cow.c > +++ b/tools/testing/selftests/mm/cow.c > @@ -1769,7 +1769,7 @@ static int tests_per_non_anon_test_case(void) > return tests; > } > > -int main(int argc, char **argv) > +int main(void) > { > int err; > struct thp_settings default_settings; > diff --git a/tools/testing/selftests/mm/droppable.c b/tools/testing/selftests/mm/droppable.c > index f3d9ecf96890a..90ea6377810c5 100644 > --- a/tools/testing/selftests/mm/droppable.c > +++ b/tools/testing/selftests/mm/droppable.c > @@ -15,7 +15,7 @@ > > #include "../kselftest.h" > > -int main(int argc, char *argv[]) > +int main(void) > { > size_t alloc_size = 134217728; > size_t page_size = getpagesize(); > diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c > index 9423ad439a614..03a31dcb57577 100644 > --- a/tools/testing/selftests/mm/gup_longterm.c > +++ b/tools/testing/selftests/mm/gup_longterm.c > @@ -444,7 +444,7 @@ static int tests_per_test_case(void) > return 3 + nr_hugetlbsizes; > } > > -int main(int argc, char **argv) > +int main(void) > { > int i, err; > > diff --git a/tools/testing/selftests/mm/hugepage-vmemmap.c b/tools/testing/selftests/mm/hugepage-vmemmap.c > index df366a4d1b92d..23e97e552057d 100644 > --- a/tools/testing/selftests/mm/hugepage-vmemmap.c > +++ b/tools/testing/selftests/mm/hugepage-vmemmap.c > @@ -87,7 +87,7 @@ static int check_page_flags(unsigned long pfn) > return 0; > } > > -int main(int argc, char **argv) > +int main(void) > { > void *addr; > unsigned long pfn; > diff --git a/tools/testing/selftests/mm/hugetlb-madvise.c b/tools/testing/selftests/mm/hugetlb-madvise.c > index e74107185324f..43f16c12c8e9a 100644 > --- a/tools/testing/selftests/mm/hugetlb-madvise.c > +++ b/tools/testing/selftests/mm/hugetlb-madvise.c > @@ -58,7 +58,7 @@ void read_fault_pages(void *addr, unsigned long nr_pages) > } > } > > -int main(int argc, char **argv) > +int main(int __attribute__((unused)) argc, char **argv) Can we add a macro in kselftest.h for "__unused" like the kernel already does? Then instead of removing args, we can just mark them, like you're doing here. -- Kees Cook