From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E2CBE77188 for ; Fri, 10 Jan 2025 19:01:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA6096B00DE; Fri, 10 Jan 2025 14:01:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B38ED6B00E0; Fri, 10 Jan 2025 14:01:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A7B86B00DF; Fri, 10 Jan 2025 14:01:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 75F496B00DD for ; Fri, 10 Jan 2025 14:01:03 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1B9CBC0E61 for ; Fri, 10 Jan 2025 19:01:03 +0000 (UTC) X-FDA: 82992459606.23.D9D8F37 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by imf04.hostedemail.com (Postfix) with ESMTP id 0333240022 for ; Fri, 10 Jan 2025 19:01:00 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="iC/uyAH8"; spf=pass (imf04.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736535661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jl28WGFBUnyXFL1l4Ve02m6xRTatJU9EP+pENMko8OE=; b=S1HQaCLEF2tw8v5ipkkTZRn0FWulFiJMKtNp3G9cWw3a7HcZaLI8O0H4R7liK74qmbeJPC Xul6Tbqp2NgFT+bKtmVAP5SmIE6eyITNcJZD3qHBxDz4j299MT6bnre/rIrvhK3cHfS20w pjT/wQAkTzHOehugyqPwr71Usozh4v0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736535661; a=rsa-sha256; cv=none; b=6gMAaQaCIdUbOSOgK6hBD85hnYOnrWP2Zh5QwY7yqu3KOnqEwMfgKT2Oq2myts2df4+9aH nEm5ybkhhdEZgi9Zwf9SVZIHOay6h2FOgUSsk38pXpp51zIVzgppayvQZiGWZ9HJV7Cwhe ZeKXC6e26Ni3rnJGsPBMlu14V8xswRc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="iC/uyAH8"; spf=pass (imf04.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.54 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-43626213fffso22138135e9.1 for ; Fri, 10 Jan 2025 11:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736535659; x=1737140459; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jl28WGFBUnyXFL1l4Ve02m6xRTatJU9EP+pENMko8OE=; b=iC/uyAH8qDfOqb9FwQgY7KeDj82FQFitQ0Zja7lD3RARXYJn9+wn/ZgCEqgR+vsPfi zXOa2VQYELRNJeWZN3ZSzV3N8DgX9jUqQKs0sjQ/VPC7T4khJPsgMgL0OjV1WJZzJtXa 1+SSHYBo4Vvytw4n+v/1Z9ih78dGzJyaLslp6/sJflBzHjNGeGuuhQWMloIkN4tJsBzv 3FiONklqJwy0o7h2LqJDJrVEpCW6V+hs1FvesTaANv5rYWhEwByX3u5maqUyTNUSkkOt q6COH+3ezhw11AeZRlOSN+eW4e4hXUQPaC6p/L3k23ujAq8KKBFZO+QZVV/qeoCB9hqF 05Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736535659; x=1737140459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jl28WGFBUnyXFL1l4Ve02m6xRTatJU9EP+pENMko8OE=; b=BTCTS9yef/vsvOioGZOKm/9RvlQCbGKvfzBhv6smjmnn6gxgooQBYQC2k3RFdlCF0V hX6uvupRXsdxXE5qfaDKRyLOAGsy3ufAH4EQZ3Qg82FX9+2NM7HjM3F458NQ2Ox0ya3l YF3P/MXwdXZ9C7l1jCi6DoYyGnk+mcUPQjwoDxvxVgn9VYDijlv5degIlzYAH4reRMcV jv3kXJtMZqwDlRezMBwzb41wGdOKMSHVE257s7Vsv3AaRij/Al5BkBKZ1171HvUGljwo Okf9mN+zdcSk/x9Z6/h6dM8UudmlCInPwdPnRVA/uNX5Cf2SZU5KQ2Ad3USF4L89FLNy RzZg== X-Forwarded-Encrypted: i=1; AJvYcCVQb9X4wTw5nZGH2+c/I4A8XxvpPIB2puNq9Oukcm75U7Vd9dqgJEG9OduKc6OFl2FijNSmkum1Fw==@kvack.org X-Gm-Message-State: AOJu0YzvjW4QoEskbrXQcuOHjZWYVL+vzsKjZjry76GBFuo69DHCtA46 KEas3HKKsWEjZwM9A6vENPRReKzocdc9jECuIuGWDEwQWgqDiU7g6jRWew== X-Gm-Gg: ASbGncsW+b0NvSDwzR0WO8LYMijgN4jM3j+W22ci49Rzb/upflrg612dh04fD5XkaJ+ yudt31WEqN8g/w4eYmAeSxTTCBcm6RUV79rrwq+sejPlmHgtu7v02ZxCEAwgkb43Ux+qICjqJVT u9QH+g5QyheYkzgxqcJy7nCQnujRHUXDO8Th8v3uG40Yay0PsHarzXVOim2F5nmQCTtUVvMZ193 Q692wxKbl3LE/TnAsGPnDBC9HIGUwMtLbk5QTAxI1/98r+y4uLoJA4/TU8laFmY2Qhrfa0289tF Gk/kyJy64v2TnJ3jjXY= X-Google-Smtp-Source: AGHT+IFqfQ9D/+Ru2s28NeOwpa6tmi6l/3Fy+siG6IN7TXQbcoEEAlkBeBjEy92hU2amqqBnx5IKrQ== X-Received: by 2002:a05:600c:1827:b0:436:199e:8458 with SMTP id 5b1f17b1804b1-436e8849de0mr73803245e9.14.1736535659163; Fri, 10 Jan 2025 11:00:59 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2ddd013sm96255465e9.24.2025.01.10.11.00.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 11:00:58 -0800 (PST) Date: Fri, 10 Jan 2025 19:00:57 +0000 From: David Laight To: Muhammad Usama Anjum Cc: Kees Cook , Andy Lutomirski , Will Drewry , Shuah Khan , Andrew Morton , =?UTF-8?B?SsOpcsO0bWU=?= Glisse , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters Message-ID: <20250110190057.2294fd5a@pumpkin> In-Reply-To: <20250109173842.1142376-2-usama.anjum@collabora.com> References: <20250109173842.1142376-1-usama.anjum@collabora.com> <20250109173842.1142376-2-usama.anjum@collabora.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0333240022 X-Stat-Signature: tfui6pfbytp31d95iig3cpar6r73oe9h X-Rspam-User: X-HE-Tag: 1736535660-622328 X-HE-Meta: U2FsdGVkX19gb3soklDdy30KZW5eRaTM+7t+SD92pqI8MMmIKFOTSfwtSmmKRuKqnrOW6R8gjFj/3jSZpqn7haYmyHG6LLRN5eKPYHh5BUJ63wZWmEm57rhkb2sGX5ynOnQNZnIm+pLCL05dv8O5DLOFgLBkKgRBa+wMaW/wCnG96trdKHoOaApRjhxtcsI9PpFy7ZyCU1d+9NSLViugjHYT1i3Sf/1qeIwwPZDIpJsZxk9x9zKfoIGg3ZuN0D9n8/gMjiJ4W56Lrh3Jjb4z8y/PyNZdvcCIgQCjMvGhPsKNBxayBbgex4k7shafr7mlf/jfk5tyvzs/7yYoD99/1sEyeig8F0I1oKfAehrIvy6aHZSIARduP61w0tP9RUZou9rSfaIJv+pHIUHYQ5LD+5IubXNoIZlUo3P10dh3i5JdGyQOZDLH8P2TPAJPmF5b5ZqsrPfiVG5g3FdGbEzP74UjW0MewgF6zfy0fUFeFobVEa4wUvFRVKDWxddtJ9qAdrNCjh+DsBh42QqA2ocWqi1W2A3gBDEBChx2NeURGlgIFsfRsJWcgVZep7TBdBWxMwK7Ts0UqALpDZWc0ZoFGwRBiukHyHiHuhd9dZA1ti+dQXJI3G1DZuIqpljj9mfhoBoV7ekSm2B7hTHLz/94qoYwev77P+3kFAcVvimWGBu13Qot7FKZu4ib+nbmm7RdNxDugIep2B/xb4HR3MzwecN11lJUqK+fKvGisqkkg65sRQ5gyOxyGaKuS2xTccAmIyFzYrbLmb11k3NRk3UfOYGuIKbx80HReoltrFwcoctUc3SMPqCVnfztFApSyZ0HbVG62zIK8qV9gY7MgBDk/DoX3y1s+wojkw3ReYpGa62UyljmwNo+8LiFnsgspPTJN3DEeA5KpbvjhdFLDlJXtUN1xP3y9n9i1MV4qfYdJoExESqO7igEnL8rL5MVYBvNTIpm1jDfj0haoaK41Zk LEJv8Mjt iGC2gpm2Wp6JXNqe8Sp0upk1j8jPvdH0je37QThou5/4Hjnr7oXkbK/7khgTZBQhK89oUmwGfr0ODLZu31M+lxIidhPfhe+ypv4FiRS7NXFpfKqOiCihCGSvSIEbat8KRHxEEqSXES/PNuwJtbWIUubmanwppcuTWbG00Xf4tg0vYnxWZlCurBvS2YuZtPvOqN9GWrLPUattxM88+P/xUI44onflCfuS99Z0Eq583ExwDnKgoNiL9/LkaqhuLXw+MkZe843L6GXszUER4AS8EOHIRSkYkNJ4NTEfr3/UoLd4gIiHalci8JUfsAkYRbLyCpk9CRNuX57A07qjOgjvx64CkRU31DNG5bdh66sxwphbIJmFI4K0Z9zWCE8wfE2Nu7aAgFbFq0qIUEKGez3LbNXMRjxKZOroFlz+tFvyH7M+GQHT/oYRg6zxWTwzmy+eRAFDF X-Bogosity: Ham, tests=bogofilter, spamicity=0.001309, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 9 Jan 2025 22:38:27 +0500 Muhammad Usama Anjum wrote: > Remove the following warnings by removing unused argc and argv > parameters: > In function =E2=80=98main=E2=80=99: > warning: unused parameter =E2=80=98argc=E2=80=99 [-Wunused-parameter] > 158 | int main(int argc, char *argv[]) > | ~~~~^~~~ > warning: unused parameter =E2=80=98argv=E2=80=99 [-Wunused-parameter] > 158 | int main(int argc, char *argv[]) ... > diff --git a/tools/testing/selftests/mm/compaction_test.c b/tools/testing= /selftests/mm/compaction_test.c > index 2c3a0eb6b22d3..8d23b698ce9db 100644 > --- a/tools/testing/selftests/mm/compaction_test.c > +++ b/tools/testing/selftests/mm/compaction_test.c > @@ -194,7 +194,7 @@ int set_zero_hugepages(unsigned long *initial_nr_huge= pages) > return ret; > } > =20 > -int main(int argc, char **argv) > +int main(void) Doesn't that generate a different warning because main() is a special funct= ion and gcc knows the arguments it should have. Just disable -Wunused-parameter - there are far too many places where it pr= oduces unwanted warnings. David