From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 750E0C02183 for ; Fri, 17 Jan 2025 17:08:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BFDD280004; Fri, 17 Jan 2025 12:08:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 06F71280002; Fri, 17 Jan 2025 12:08:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E792D280004; Fri, 17 Jan 2025 12:08:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BC796280002 for ; Fri, 17 Jan 2025 12:08:34 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 68BE71A071B for ; Fri, 17 Jan 2025 17:08:34 +0000 (UTC) X-FDA: 83017577748.13.B50BC89 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id BA22140014 for ; Fri, 17 Jan 2025 17:08:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uFO6edxE; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737133712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D8e3VKYevaZeCoM+Wtlx7W/l5GjHQhPLdu8Hpg+E5M0=; b=D2IDCuOvhrv7jSCutyQZj6AFj5Iv/+i0bxKYoky+SIlFs9eduJROhj8KCOVLy2UbnLma4c mEvwqPWSGxU/r/ZcmOKOuX+8lH4ZnShigfHOxHcjrmPmlrVOSVsfjrHYNOdB4STqh/3GU9 BKOyim9Bsp49AMTesoa5DDCBr1aaCqU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737133712; a=rsa-sha256; cv=none; b=jwkyA8h6aSeQYaKoc00XKJ7LKq697p3ssQXKkpB0uYxbSyqikEPIwKrwE2vPzDYmvo1/BH KQBFBCSWlkrW40NRHXHXdS6n3BR+ArK56xmeuzwXbUTq+CCWvT9V321CnnjGsCOhtUh/2c dMyuZpFmxc+FObtkzFoj12kXEJ6lBy8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uFO6edxE; spf=pass (imf01.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1B5645C6397; Fri, 17 Jan 2025 17:07:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53148C4CEDD; Fri, 17 Jan 2025 17:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737133711; bh=sBLYq42nXCh1cJRuW3R19kQZcefoL+by29Bl3OgHDSs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uFO6edxEsGeX9NG+lTyELxT+h+oyhTM7HELAuOUf+4ChMYyGkwafwDUa7xarfeQlq 0b8g/6HcR7GC2XxhcO/k+OQ+8uNh2ztjKloCFsy0kOOXevumVav0jgTNhAH/Dx5Q7p 24emku++eCH0/KeFKNgClH2EydKK5boo1aQwpdc3YF4WcQTLhDCB1EASKbrqvXritD buxuyMPUsQK8xDO6Cws+0z2VsGXB0zRQqrD2pE1I+ZwcCvQYN3geemReHFkf56Sabx QGGSLFVbnuw/E3fjc5ne4TBy4B7WOEUvvXvUkKhlJqdV1JqEpa8z78yqeEKJlcE64o Sox9IrkD0EcBg== From: SeongJae Park To: Usama Arif Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [v1 2/2] mm/damon: introduce DAMOS filter type hugepage Date: Fri, 17 Jan 2025 09:08:28 -0800 Message-Id: <20250117170828.55772-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: abz563bt7uqghx4yrjachkzosp3rfkmj X-Rspamd-Queue-Id: BA22140014 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1737133712-68822 X-HE-Meta: U2FsdGVkX1+wHXo4GbCA8lDo1eueTZ3wgZrqWAlkLR4450rCQQ8ZFnxydRwL7PLPybglD2h7LfHjZZF2H41iAAE61tZoakByUBXa2iW2cV5d6Xoqkg8dlizctUp7vj15LkgXA4apN8/fgQMCWgnuSQ5L3xKuDJEd/skwr3FjPMwAxev16Lkg3njRWapa5StLlFS7Ag4UVS1Nk3yGFeoGFHUKA+fSIKo0rrAysz/uEckt7rTVR9nl/7qAO8e7wmgkuY/lD7qpLySePw/bZStBER6zsJF+YXlVkvQx/Mjza6j9yd9rjGdHMifhyWLdP/WZSisfTbrnWCAUJxaG/40/e6lomfCyfXEjXDwsR5LSl9rnhz9OK+/gP5bL6Mpwt7/8d1oP5akZwnECG23i85KsA5zcRqOcwUrF2mAcn2buvo6yAG01S3z5mfIFCK+RnZvvVFI5BnucsQFatmCMjbHTg0JGpvWL4/ADDSId/3NXc/5WomoqyeDPw0L7CNNJmgxHdnJeeHOqFY0YOVUOKd/5a5ACQhqggU18DzwZ8PJoPCQNY3fyGIKYfUj3+vvVu+Y1fV9z2DAUb0B3sSUWWrrIcdUTkE02GmCDgOx6wqKDLdYaoaGySbpCrAsqdmiJhtxilcCTqivz8Aph4MLWS/hvjjrg6lmB5MPg+rTBxCQlhl65GfBR0tyIH0MWeQwiozhUt7sToezXknHAkcHe9iJt1CC/d8naxL8nlhyQyyNvf7gCgsuM7yc7NnZk36sl9DKrdKKP762zwB9281rCutSA+5DfRv4nYu+ba/H3rEEtHzusV9bQFerNAdyTg9nCjy1zXKiPDRBcsAyPCm5P7mu3mdkqBnbPrNjO5OoiOUe+xOEihWSuQLKu1F5q/d1d5X9OnH6MswHj3WeWYzcCqB7vc2IDXseJ2BPnzKG72iE6j5qzDs8liojs9cg5fTbnykiiP6LkrpxHBHhiHrNSs1T 1VzMqicD DsLbTQRAQU0GbG8hlZQ1njn+MK6mkLl3DqoYSywmaoTx8BE3Nlnx6/qsXKJkUUeEwwlGtbACZB4nBAeAbCDkP0xYHZ8rMO8M9+VJMdeBWJ28fiPXyGpcznxbcmhsPtYL2gBor5AOu8f79DweRRFwsmhrjinyD/YXv+ZUdjHXDHFMLuFeG/nO9XPyvvn99INLbDLwp8fge1lJkJ0rpRF1vY42OiUWr105OKeByWPYDQCvl1Qsyq2ZoQep/TDBRk31FhnarOO4XhDjxhauvave9ya4u087C4l5ylv9B X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 17 Jan 2025 11:02:05 +0000 Usama Arif wrote: > > > On 16/01/2025 19:05, SeongJae Park wrote: > > On Thu, 16 Jan 2025 14:44:36 +0000 Usama Arif wrote: > > > >> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > >> index c0ccf4fade24..a9e69179d45c 100644 > >> --- a/mm/damon/paddr.c > >> +++ b/mm/damon/paddr.c > >> @@ -222,6 +222,9 @@ static bool damos_pa_filter_match(struct damos_filter *filter, > >> if (matched) > >> damon_folio_mkold(folio); > >> break; > >> + case DAMOS_FILTER_TYPE_HUGEPAGE: > >> + matched = folio_size(folio) == HPAGE_PMD_SIZE; > >> + break; > > > > This will make build fails when CONFIG_PGTABLE_HAS_HUGE_LEAVES is not set, like > > below: > > > > /include/linux/compiler_types.h:542:45: error: call to ‘__compiletime_assert_321’ declared with attribute error: BUILD_BUG failed > > 542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) > > | ^ > > [...] > > /include/linux/huge_mm.h:111:35: note: in expansion of macro ‘HPAGE_PMD_SHIFT’ > > 111 | #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT) > > | ^~~~~~~~~~~~~~~ > > /mm/damon/paddr.c:321:48: note: in expansion of macro ‘HPAGE_PMD_SIZE’ > > 321 | matched = folio_size(folio) == HPAGE_PMD_SIZE; > > | ^~~~~~~~~~~~~~ > > > > > > This simple test might help you reproducing it: > > https://github.com/damonitor/damon-tests/blob/master/corr/tests/build_i386.sh > > > > What about enclosing the entire case with > > > > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_HUGETLB_PAGE) ? > > > > Ah Thanks for pointing this out! Would > > #if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) > > be better? Yes, that also looks good to me :) Thanks, SJ