From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CAB7C02185 for ; Sat, 18 Jan 2025 18:09:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB0B76B0082; Sat, 18 Jan 2025 13:09:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D39A96B0083; Sat, 18 Jan 2025 13:09:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB1776B0085; Sat, 18 Jan 2025 13:09:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9CDDE6B0082 for ; Sat, 18 Jan 2025 13:09:22 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 445831C9355 for ; Sat, 18 Jan 2025 18:09:22 +0000 (UTC) X-FDA: 83021359764.09.D9E7009 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf26.hostedemail.com (Postfix) with ESMTP id 58965140017 for ; Sat, 18 Jan 2025 18:09:20 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JGNXiaNO; spf=pass (imf26.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737223760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4BA/IJCpYsGVXt7I5m+H4A9gd0VSnYvzZ/4qWQWWRxQ=; b=HNZFxSj6dwS7SluxUxB7IiXrEnEP7nqgbcjdfMu89iz66+uZZM1USGuytp79lyMrxW7siJ voRZCkl9wmNAOPUl6wwDeRqmXAgvHq6q/Ckayi+diN5+oqr5ohnFeiyb+b7O5FuMgtCoD5 Y5XUwMuWYM+IrneHShrEXYR4sSTfVNw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JGNXiaNO; spf=pass (imf26.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.51 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737223760; a=rsa-sha256; cv=none; b=4D6/mG67//01r3mXqw57QkSG0P0zAW9K6IJ1nUtP287LOZ0S23puOHgS8hmejoKX+0Fe74 hKN28J22x6KuEP+b5rIQtUDa0u48F3HwT872X3tYhdIL6y6ZMssCIALOHqMj3s0epp2OBn GvRxEd5bWA8nM33Fi3pQIC9w5f45hA4= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-436345cc17bso21509365e9.0 for ; Sat, 18 Jan 2025 10:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737223759; x=1737828559; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=4BA/IJCpYsGVXt7I5m+H4A9gd0VSnYvzZ/4qWQWWRxQ=; b=JGNXiaNOvVAA6MN1VWmZg2r8x3TbiK1bM7CWS3dwhkG6nzIFSn9tHQW/tVKw84X5qf oXkwbmty6MyhUz82/syY/zNBDHcd7NdCNBUcKk8wJk+TiOAwU8gGbeCiu0tJVsATfNab Rbxj5xNUz/GqFzmLXcxXPPm/G91N3qjy9LxVucw00EYEm9SB2H0eKEdhT215T2S47YZk uyW52ckoJJS34cweTjBbn45k2YU3CwQY1biwRg+WVDAd/m7G/BrgcyDyaUtthKCAWbg6 2h0MyHGWJ6tmbE5S8HDo80X/FE+223r+KOn9BQpqvNI4+23Dkj5k9jQKIUPVKxp8hUMY SUyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737223759; x=1737828559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4BA/IJCpYsGVXt7I5m+H4A9gd0VSnYvzZ/4qWQWWRxQ=; b=ZCms21Ay02bUpyG6Yugi9LN+MPwdC87GdXRYVGYwy8BGuNgxz++seZxeN0eCaZ9Wj5 MlAX90c7jINyZYdE7IZ+d4bgd+NcQBigQm58AlWkaKuJHkL1MSvGmZSOln3qxf15tV12 J4Y0u0xgb1xIpvL8EfTs0Hm0pa/WJZhlBx5aCRBzw3vNS9MH8eq13CPXgytJWM/eWQqM orxUIIPdCCb/bVxqLNPZcsWkZSnPkjK9b77omKpu0Pc/XqqK9ZP7Bbeeusj8CLhEb+qb ElI8BYYqIpqvW5L/zVPVF24NccShF5xvJa8uyB+yb2FX7cEfv4iB8T+kS7I86v56OjKQ L96A== X-Forwarded-Encrypted: i=1; AJvYcCVg+jmLOXanbxc2MkfVHLORy4PjbXzy4tFvgPvNsM39nnPcRR9Jlp3uqkEtNK7O22FiOhp0s6n+qg==@kvack.org X-Gm-Message-State: AOJu0YyHW+5TgM1+TXcOvup1m24abW2QdEDxmBvdHuUbmyExHQoIlYbl OdbF2JlVQy4TYNWei1l3heUIs86Oj+n8fUyeP3iFybtgcV4Z1E0C X-Gm-Gg: ASbGncvxOym5CP9nULk2ZFmlKiZGTptsV75Qgr2uDQ+Eg5Q//hma0KcBT5BquZUBy7h hLrBj+Q7o/ODCcy5sCbj62p/R+LTEwzVq65IqCceYUSEqAhty8TeauFO5MjhvdlST0wuLShjFsW UF5FOVy0bfYWJ0a9yJusz/1rZpeuvVYyLoiHlPKPVAKX3TMimrkm+Q4PTyeiR6rKT2yScI8bzDx lNwennHmUm1w8eudNGLuiJb+PWLhx46iT9oHsM6mmCPr+HdTJiU2LL0QbxMGymZvPDLSvG3WrJZ A6z1A2d9Uu1XNlv4mHcBA3jHiMHskUB7 X-Google-Smtp-Source: AGHT+IHVwNkjw3fCrBEKyLXBvBiUL2k60KcVoV9cy6dZqzV7+/qO4ENIlaaFUStajLUdjSOHJHd/GA== X-Received: by 2002:a05:600c:4e4f:b0:434:f767:68ea with SMTP id 5b1f17b1804b1-438913bf92cmr81103605e9.5.1737223758584; Sat, 18 Jan 2025 10:09:18 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4389040854bsm77741645e9.7.2025.01.18.10.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 10:09:17 -0800 (PST) Date: Sat, 18 Jan 2025 18:09:16 +0000 From: David Laight To: Guenter Roeck Cc: David Laight , Linus Torvalds , 'Arnd Bergmann' , "'linux-kernel@vger.kernel.org'" , 'Jens Axboe' , 'Matthew Wilcox' , 'Christoph Hellwig' , 'Andrew Morton' , 'Andy Shevchenko' , 'Dan Carpenter' , "'Jason A . Donenfeld'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' , "'linux-mm@kvack.org'" , 'Lorenzo Stoakes' , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi Subject: Re: Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()) Message-ID: <20250118180916.433bb73c@pumpkin> In-Reply-To: <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> References: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> <20250118170959.3aa56f4d@pumpkin> <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 58965140017 X-Stat-Signature: nmy7k4fb9qaiqcte8gj8kfn9o5o4cq3z X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1737223760-486899 X-HE-Meta: U2FsdGVkX1/SyGPsyd/zRnt1yC8YisUiaXYcbW6f4hflABLQCvY2lniV+GwdRc7FkVwM5ao1XfQQMaCfa6Q87XB01EoAEd5Ww7GPkGzWoxTUirQOjVnqpLJoVwt9ivnHaDXvD2goAiCFyI7Kq1uDpGo5H9+x1rv8krCtPAdPY4K6zWQOuALueUMCHGCgNVSfZm/PRhgzHKZDjjn5bxsOrkQc/Szp7AJC1I9YT2CPKMIGNFR1CyewSE8NCC3Xhh28ry5QY+xqCKbdDziiLQWs7nUXpw3veFvJ0AYuH7KHalYcFBg4oBIlXZfQ01irKp+s5JT+YYqnTp1kap7zCAZOIK3OPHpWLs2N18tDy0W1gA8z5NRarpRbOtFEF4/xaxuW6czkX+lmA+rP0BG1OqNI/xKSLdT1o3gzQKXggLiLeLu7fNvsthKPd7HJma8GhFqLUWpTUQ3N0eD5K4NE8HR0OxLaTCcplO+CNVuFLvm0OLAD7pi2sF6UW8tGsc5cT4KBujfUcVJ19e1QeJ2ndmRdXbGNcWB9raBesqH8GFFCOt1qYsIeaAB7UAizCuBP1N4VfAYQsu5vCph0HA8X8ys3OGPiR5kd4G+pjP5Wc3fG8ABCzIAeOm5tZhvIhMY1xaW/rfQgUWQ90Ffkx/wh8Of6X8HvPB8iRoiZ3fNTJn5CC/MB6cyPX9vvXMhHL0BMCNU7XGCH4Zpeb443BUPkotpYN9U9xM37KfhrfU3LTwJzpHyr3RkIRk2+fbjYXFdHuCXuUEySSNyeXSin0aZyk2uiIXTSSQVvXzLvrN6oPfctDd/BSdp9lCVUGFfGF6oD00sF21p/WhjBVSdpUB6KhLykuOzv2i391/NEuWMtbVQoW8aAMRr1M6uymP45bDZty/smAm0acWLy+QNbwZaTN/q08JdGiD5d+dCbR4snB1UQKuvkXQskZolWuofPje93r+kOyu+820DkpCbM3S7lNI6 H/sshBCV dJc/vZ9O58fD29kHyXQ64JNfAQZ0VxpUmTnezb592Ocizgaww4l4L7BEnux+qfBw2zMvC27etuP4OciG6pG4LR8vDVU8UJ3rVCBoj1dxisP0ah0jvzzTXfE+5AREz09CEzXI5znTzobZJ8vKJ6KqEoXm2cQaDmstN7tjQeXNKvjuLIiuknVltC5mXKev4ha/G151JzJoygSreVno4Y0TvC3XaEPI1NiZDHPnO3aRe2CXvEsd9RelYb8OrxFa3fPG4luVffh8du+oLEIa84JVqq/IKSGRPNKdCgSlGf4fHBzVl+lRAdO1+0lRRnzZhWJx/BSWhxnI2qU4BQsKje4tg9TFDYe5nT8VWTradET62DQk9e8BY1QDUmOCFmDYCztXJogndjvUo6JyOgl+f9Mto7rbYNvK4OiaSaOReLPQ9Sdftm8cyMoFDuI/sgWB1PAyIsFLR5oDXAusiM35LWeqrykzMQyBg+tau9hA64/JXVgNdNkMvqXjFkF4UQkU6xg0VbLCBy+KSfEoqeEUxSx282H9TLTxIoCQDSSzeuHw0z29z40u7x6NoaHywEKJsHO3gMiZiePA6ygofOpn9rpf1boH/UTsxuuj7FJ+a3zUR5HY8IVMCpGWr5nYFD2FiUKuKfuEK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 18 Jan 2025 09:49:21 -0800 Guenter Roeck wrote: > On Sat, Jan 18, 2025 at 05:09:59PM +0000, David Laight wrote: > > On Sat, 18 Jan 2025 08:13:06 -0800 > > Guenter Roeck wrote: > > > > > Hi, > > > > > > On Mon, Nov 18, 2024 at 07:13:31PM +0000, David Laight wrote: > > > > Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity > > > > check of the bounds in clamp(). > > > > Gives better error coverage and one less expansion of the arguments. > > > > > > > > Signed-off-by: David Laight > > > > > > This patch triggers a build error when trying to build parisc:allmodconfig. > > > See error message and bisect log below. > > > > > > I don't think there is anything wrong with the patch. The underlying > > > problem seems to be that parisc:allmodconfig enables CONFIG_DRM_XE which > > > tries to build the affected file even though CONFIG_DRM_I915 is not > > > enabled/supported on parisc. > > > > This has appeared before. > > Any idea which inlined copy of scale() is causing the problem. > > On the face of it they all look ok. > > > > If you can reproduce it maybe try commenting out some of the calls. > > > > See diff below. All three changes are needed. > No idea why the compiler would know that the values are invalid. Maybe it isn't even an inlining issue. Perhaps that compiler just doesn't like the function ? What happens without the 'static' (and an extra prototype)? David > > Guenter > > --- > diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c > index fc1e517e074a..3b2c8bdfcf8d 100644 > --- a/drivers/gpu/drm/i915/display/intel_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_backlight.c > @@ -76,10 +76,14 @@ static u32 clamp_user_to_hw(struct intel_connector *connector, > static u32 scale_hw_to_user(struct intel_connector *connector, > u32 hw_level, u32 user_max) > { > +#if 0 > struct intel_panel *panel = &connector->panel; > > return scale(hw_level, panel->backlight.min, panel->backlight.max, > 0, user_max); > +#else > + return 0; > +#endif > } > > u32 intel_backlight_invert_pwm_level(struct intel_connector *connector, u32 val) > @@ -119,8 +123,10 @@ u32 intel_backlight_level_to_pwm(struct intel_connector *connector, u32 val) > drm_WARN_ON_ONCE(&i915->drm, > panel->backlight.max == 0 || panel->backlight.pwm_level_max == 0); > > +#if 0 > val = scale(val, panel->backlight.min, panel->backlight.max, > panel->backlight.pwm_level_min, panel->backlight.pwm_level_max); > +#endif > > return intel_backlight_invert_pwm_level(connector, val); > } > @@ -138,8 +144,12 @@ u32 intel_backlight_level_from_pwm(struct intel_connector *connector, u32 val) > intel_has_quirk(display, QUIRK_INVERT_BRIGHTNESS))) > val = panel->backlight.pwm_level_max - (val - panel->backlight.pwm_level_min); > > +#if 0 > return scale(val, panel->backlight.pwm_level_min, panel->backlight.pwm_level_max, > panel->backlight.min, panel->backlight.max); > +#else > + return 0; > +#endif > } > > static u32 lpt_get_backlight(struct intel_connector *connector, enum pipe unused)