From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D31C02185 for ; Sat, 18 Jan 2025 22:11:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00EC36B0082; Sat, 18 Jan 2025 17:11:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F00506B0083; Sat, 18 Jan 2025 17:11:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA0BE6B0085; Sat, 18 Jan 2025 17:11:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BC2386B0082 for ; Sat, 18 Jan 2025 17:11:29 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 756C7141DC4 for ; Sat, 18 Jan 2025 22:11:29 +0000 (UTC) X-FDA: 83021969898.29.22CD6D4 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf21.hostedemail.com (Postfix) with ESMTP id 829811C0004 for ; Sat, 18 Jan 2025 22:11:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h8TbX0OS; spf=pass (imf21.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737238287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wDLMXoR1qmk4Dz/P9/9AXOD8JfOCMxUMePEkYwFYoZc=; b=u6I3I8+oe/L1olFsmPEFXg+1aprksqqmkzqI6VK6a/MtGNYrjqHzRX5Y23uP4JXg9tRTSS RdMG8D1gtVheHa0temICDiSEJXtJIZ9urs/qiRGCm9r2tUyiSWdvYu4RgrmhNvwnZ+yUgI nL0OXFmkt56oJg9RrH/44miutNmgqdU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737238287; a=rsa-sha256; cv=none; b=nANcL6aiS7h0cf9570FRNIiUsv+dG7J2F8KqJFJvmDEWbbA8u2bszBgMQ0J+HKvtJF16DJ 0VnmwsOTj2RdwxdNt5HpRt3+UDzyuWiMRKNTKGdWujkx74cE8Tec2SSi6YksC4agJIa84B FilNTHpIlz0G5OXFr2e2edJKC4S9whU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h8TbX0OS; spf=pass (imf21.hostedemail.com: domain of david.laight.linux@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=david.laight.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-436202dd730so22142195e9.2 for ; Sat, 18 Jan 2025 14:11:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737238286; x=1737843086; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=wDLMXoR1qmk4Dz/P9/9AXOD8JfOCMxUMePEkYwFYoZc=; b=h8TbX0OS4AQBXNNSaMdQ+CK35+0QuAEkZv5V/sMlqhwVbffiv0PF5TEDaBM+ryfWFY Iqri/xlgGMVMugJy46Y0p3Xg/zHHfe17+yyZXQPSBpkX94cEBOl+3lFVGxdr0ZPWXuWL 9XR5POU3nvHRLaWZIzfgD4G3ItzH3bSQ53DZZ3uHHi/lUKj7JjhfXGFwbZRSmzNSoNs0 rDRQ8+D/NyIyXtUdrFb1MTBmXkVxhUYTFsUzo8fQ+SC7x1fHCuJEPd5irhoaIROiN99B 1dg9SRFsRh6LmvQFzVMnHcjr3XZLSmuk1SPOD6kTzeKSHpNIqfEhR2DDpnC39M0dgzVl knVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737238286; x=1737843086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wDLMXoR1qmk4Dz/P9/9AXOD8JfOCMxUMePEkYwFYoZc=; b=QQt4sAJTilCqvi+GCTFn4YnV8J1uzyuVjBBqE+syPti41sShQFXE9yEXVECMzv/xId i0sxzZfHCW+Y/MQWghdg2HZm0VaKHDKHuU/4YVGmWVVvJ5dqPa5KdNvcOUCjVGwnQBV2 2PAVIwtZcYiVowH4vjBIjjEXyXxrkJOg8h9ipJtIrg0y7mOZmXVClKIodA3NNewrc9NM nAuhIJMoc6bnh3vuQIF74TEgNVN1Vu9OyxwpXcwxrEmxhdkTczZHIr2u49K0b8gJ6vPf lQbWJo864NUa40MFXmUgxzRJcOUQcJOSjRozUrw8Ekpw3gLZuqn36TnYNxnwxXqNu1+i 6mdA== X-Forwarded-Encrypted: i=1; AJvYcCUfXehzpJWZ34fW014dzsjPAHBL0HXIYOesWuMozAn2zG0clNavb3XgRNCs43EZvJPiEk3UY9UOHg==@kvack.org X-Gm-Message-State: AOJu0Yy3q+q/Vb39XSn0Jx9JEPwXxpZFM0tYlDACH8YOIkblkfadsBcN mtEUG2DSu9RgmDQBf5BYCpFV7TCpm2OClHE70TXuAIAwJBf7b9HO X-Gm-Gg: ASbGncury3iVbOagsrPQLGb5sJLkURWQFCYPokcU2O/29pN39a3jML2AAnEHXHIvsA7 /3TN8vgBYuWZDlGq/mw9fmGuJwfkSkggR/zn9+WkSotRK2V+XDNeLMhoY8vve80kvQIKZosLxaF UP3qUenB7yX/h1rG8etQQPrU3WA5NYUSAUPdqHjBKvfkD225k5BBLwFXJxvH7lOe8Get/pg17of 2A9EthUacjyha7FLoYVg8ZAW/ymDaQmH46+U7V0bUNUan5l0+D+3MpWLd+kWotLU4Ce5ZdC09c7 fuJLFcv3G+nsgATTlzbs5zzzRmWt6q0n X-Google-Smtp-Source: AGHT+IHnaJuHfUIiy/0045g/Wc2s71so4/jbOpY91Aw6dJkpE4hulhRnISFfjzqdOCP3e8RPnZ7zng== X-Received: by 2002:a05:600c:1907:b0:434:effb:9f8a with SMTP id 5b1f17b1804b1-438913ef2c5mr77403735e9.15.1737238285738; Sat, 18 Jan 2025 14:11:25 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf3215066sm6248539f8f.11.2025.01.18.14.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jan 2025 14:11:25 -0800 (PST) Date: Sat, 18 Jan 2025 22:11:23 +0000 From: David Laight To: Linus Torvalds Cc: Guenter Roeck , David Laight , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Jens Axboe , Matthew Wilcox , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi Subject: Re: Buiild error in i915/xe (was: [PATCH next 4/7] minmax.h: Use BUILD_BUG_ON_MSG() for the lo < hi test in clamp()) Message-ID: <20250118221123.5bb65e64@pumpkin> In-Reply-To: References: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> <20250118170959.3aa56f4d@pumpkin> <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: d1kkgru6rntbgrdmd3ojw7aemqzi8dno X-Rspam-User: X-Rspamd-Queue-Id: 829811C0004 X-Rspamd-Server: rspam03 X-HE-Tag: 1737238287-757230 X-HE-Meta: U2FsdGVkX1/2y/9DzdanfEEmDB88BrfE07sQTDKPrB+pXyAwDPWBMTtMrrIS19VApMFD/KiH0WaoT1ucQlBblVVqDfDfOj/m81ZfFpXkAM4+LApXkwovhAYfn9ouD45Vys41y3XHEXALUeET5OTq2BrnVefqvXP3/MEhny11rR0e/2iiceoq9OM7n1bxJJecoxztadbTDUcm4bQMR8znrVi1zuIXzuPrQWW5ErJCvUyYV8YLdnow+rG842nMexWRem4j+CYPbiiDzYLWS8PH4x+2Kv1qUFT22Z3Ijd0/sHnJjpoJKkVWHWDfWoZ2GZ9mpy3xZJ9qNWfWfNSWjvc8JxfgjGK4AzvtkzcpfaO7GTgw+0aiFj+IuSgtkE/sjsesbeHkpjfzxcS/TD398iviLCZ2+nRU4UAq7em/OIZ/08KDaqapgQubXTEnB1PnqpI/a8JS8BN198753gLm/OOMCjGViQc3hOzjR6dZ6uZ3YC5nPueTnoCyS4QwB1j/w5mdn0qaCHRYROwd4mef3wQ/bp49zM4wFBQ6qAltNZ5W7LccgDCM65A4SGepH4UR4bttkP4O+wRqwSH4WB0+DmP7tkOMroOF33ECUQ3l/EIbtg2bGzFYZiJ9Dnuv/Lt32WUzEPoFroU38vHKmEnNIHNQmZT6xO41niH5+4u7PkW8IEYtnsd9ZaDqqNDl5DZT48MB23rHrWcy1fR5l74Gs0TvoJvDTygF5Z9rlK4m+5V7pqiKxlriBHvVN2TLXRfjItsjE/FLHPHW7h32GQrDs6cLE57FRx0prDhs7W9aKQUBjfivwHgGJcjyg5HSfOAV5LhlvpU8vsyY/UtYSxEMKGaNsgsybQId2Lkw8yGFdjAPBS8/IiJmeYTAw0d99fnTUIsysa36w+xz9wkaXKqqmLnX4J/dsZ6Px34rsAmVtoPTcZfVtlwT5z7pPWft3V/7opKGKWIJpJ9xXwmdx4ZuK1w v10olIbR S4R/BnsTDlJVcy71LBFxgMSrR4zPuzC9lEK8XKoipETKUyanj5hrYuC/ZvvqjBrnQlcWqyNoEFcvwCo5iZRODjrpKCVSTO4Q1PRgkC/JmkemkqHv0Rw60DxZ5drsnUM5oyytdRj1IGp34WzYy31ZmYgmHeNSbP9trNI3fvgLV65FvUqBWe38ebTHIQra39ptkUsq4x3vKKGl8UkjGMU+M2sE0f/cpc+U418abhYqkkwvnulSkgr43mAnymER8gbH+Up03yRj/DUI/CSuc4Uvvw45YzetxcbAj1X3CT/9/jv+on5aq0llxjVnbxXfLJFjgKMkQzFiiHMtSuRCoJUJIZoIPlEza7KNcN9IlgQF8SDH9Bsuh14KieKF0TQiI0wWCUqD4jXy8HOiHkp3hkLp56Ctv2k3s0z8Y0+riTcJ6DI/ZLjuI7Fz/Sdsu+FCPMjTJ8u3DWBmWNWvMAE3tQzMBFgMXhZTuZQApWDSLoFExpbCYGTUMew9Om0b9qtiza0qlgeSAd4UwVh5IrLDNHKYT9PcSZlzcwcZBfd0kblT0neoYwJIbhv83PsfUfEPrc+4Ge7y1t1pwta9N8mUQBK+x1nXrlr2JjDJT2lMXL5PPdVRjuizapf7N9uxQpKTPOJ+ICI7Rhtj3l6uMzQyxH+ekWMB4pUGn8iURm97E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 18 Jan 2025 13:21:39 -0800 Linus Torvalds wrote: > On Sat, 18 Jan 2025 at 09:49, Guenter Roeck wrote: > > > > No idea why the compiler would know that the values are invalid. > > It's not that the compiler knows tat they are invalid, but I bet what > happens is in scale() (and possibly other places that do similar > checks), which does this: > > WARN_ON(source_min > source_max); > ... > source_val = clamp(source_val, source_min, source_max); > > and the compiler notices that the ordering comparison in the first > WARN_ON() is the same as the one in clamp(), so it basically converts > the logic to > > if (source_min > source_max) { > WARN(..); > /* Do the clamp() knowing that source_min > source_max */ > source_val = clamp(source_val, source_min, source_max); > } else { > /* Do the clamp knowing that source_min <= source_max */ > source_val = clamp(source_val, source_min, source_max); > } > > (obviously I dropped the other WARN_ON in the conversion, it wasn't > relevant for this case). > > And now that first clamp() case is done with source_min > source_max, > and it triggers that build error because that's invalid. > > So the condition is not statically true in the *source* code, but in > the "I have moved code around to combine tests" case it now *is* > statically true as far as the compiler is concerned. Well spotted :-) One option would be to move the WARN_ON() below the clamp() and add an OPTIMISER_HIDE_VAR(source_max) between them. Or do something more sensible than the WARN(). Perhaps return target_min on any such errors? David > > Linus >