From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89537C02181 for ; Mon, 20 Jan 2025 18:08:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DC796B007B; Mon, 20 Jan 2025 13:08:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 18D696B0083; Mon, 20 Jan 2025 13:08:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07BEC6B0085; Mon, 20 Jan 2025 13:08:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D9E7D6B007B for ; Mon, 20 Jan 2025 13:08:21 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8AD3BAE243 for ; Mon, 20 Jan 2025 18:08:21 +0000 (UTC) X-FDA: 83028614802.07.54B848F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id DF23140003 for ; Mon, 20 Jan 2025 18:08:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WJMFcuXZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737396500; a=rsa-sha256; cv=none; b=lARaEqnjZF6Z0TnuLG1r/agiPCpXoiAee/BBS6OUiU7tsGcapOnntX6298SI4FTqv7LQcs PTOptI/MannASmk2sXLe4nBOTtmaWsJSH9cwMYI26FV2yUD7mX1lFRUUYJ6rq3c77Xzpcb v6HCkAWJUAsGIVVB2FTun13d2vbpOYs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=WJMFcuXZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737396500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5wu2EWuuKWu6MUAN5OwETHScffLt0Ev2cb6uEaadKCk=; b=suPSCnuuHAbPXqah11DNCNa65vIF+xVQZohvAedBKLXQprCgg/+50HwdpZNkh3wLDkIJXH DeKQTfMM3jjgjz56AFynUKlaOV4PXi6F1Uv+QXmW5yil2HrSty7pASYk67vNbvvj84WbA2 Gi6tobetwTWM+bXaCW0vrTEx8FRufU4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7F2D35C5BDA; Mon, 20 Jan 2025 18:07:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BAC6C4CEDD; Mon, 20 Jan 2025 18:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737396498; bh=WOMMM3ZEZph/7jOGVt8Oa1TUcQa/0v+Hx8F6QlvlXjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WJMFcuXZYe+r35XL9wRvegnlH8RFnbwSXmCE3I5fZYM+qX+bnQusPhdyenWEeDFK2 rNIKM3eyXmRQWl12xRUHpWJGW6eZ4iwAhcdV1RaRYiKyjGr18ZJC0vsrlfa870FeIn BOYd+q+bqCeCMmQEtpJ+3ZAmGpuF2mNkSzO75YhbTN9bft9dGLVO8xA7iNgKFNzM72 +0EZhaRrplvfC+vRRZLk8NrEmXn+lRSztWCCIyWmmzWll/Ufcn5OoUxzlxwF9WB6d/ /q3liiJr7kwiEdLYa6dgqOyDJGHrjoueSIu1qnJKSZ0VWyBGD5GtiDWT1fCHiHY7IU lPTAz1GXRZ2VQ== From: SeongJae Park To: Usama Arif Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH v2 2/2] mm/damon: introduce DAMOS filter type hugepage Date: Mon, 20 Jan 2025 10:08:15 -0800 Message-Id: <20250120180815.36028-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250120101650.3761306-2-usamaarif642@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DF23140003 X-Stat-Signature: 5djmmy1xxhodg49dpj8ikye7ugaiddp5 X-Rspam-User: X-HE-Tag: 1737396499-378665 X-HE-Meta: U2FsdGVkX19okYvHci8aarmHUAeqrZIU0BEKjzgC0Zd8okJcoDEg6CtZz2RQ3XoZEaeiY5oks7h2F4NW3HdBbIf7I90UdTALkH9GTeGxn4WfTqjIfSFbDMa4dAO3mjAKRSvcGXQnWl+awSccuVqswpcVO34HU54WvY0Ar81P+RfM31rMHY0gwo3Oo07wI0rfDPV8ruL6thJXh97mWYvypsIYJ4lyxbH6qtRU3HPqE7gAjPryDybQ/iONMENRrU+VvybXBqOI4suks08eZfC3BaRclK9DHeUFpZCgu1YUyDOskEm4i16eFrh3P2JU6Vai5awx5+Mt1SyNRgzxZ9ahaUKoomUSyF86iPZMV1IXGSET/Hz/Gf7DAJ8JniZ1RHU5Dd07RcYJ3UrZrEI3mfEZ/czy4OhtqWmKIgXJNqUn93S056zsz+4n1SsQVJT0LYa4puooqiVqrVlhpYwEBUP5oU5j0ogYPgMWFLWOMBPPfyJ48QoA0wdUBoXD8sLaSrBS3MWVf41a47+yyVKQx4Lkc6LaOsVcoLP2S+mTItYgc215dYBV1zunTOkF/tkl9hkrjFECVb8l21Kcp6Y7AZdgJWRax9cHfF0tye1fgpkgMwXTqJtG8E33zDC3ChZDf/tpEKfxzBtmtJyvloPq5shjW/DzR5sCCFqhHbv/nyKgDJH7EyzTbyv3UtQXpWmie26ZBjJze8aMR403rJaYYil8K0K64elf2F6Hk6adpVoKXGFhqQyuQmqL/RtIjslFKLMEgrxHPMpOhmJMaDSE1+R+xgG4dQNUuhwbr64p2j3AkKI4hvmgeE+jv4SzHvim5EtS5mEQnh9BhqmwAUfX3c8fTbrkmA9JNQjRNf9J4kYxq1dRuKSpWY4vftRK0nTyBUVQDOLDXq275t99wAE4fF7nxtL9UGZKuLHjdW8HkIl0OnU8w38TKUgj7vVGNBd9UiOOpsrhrT9R1n1l/U0pdpk aqI8S3W6 DPkLP2ckt6IwyKMwfBLd2fgRDUr7vqOXdsvS50SFbscHidmMtr35yREMsvd3eQnLyDAgODsW6OBplOLskslyIC22A4kX3e4Afx3OCc4nyAuxG1GSh+iL1mPUbdkG0fvlL2CECDj1ZMq8CU9wTsCLd5LSyVDroQZgg+gMdilfkP697npD4gBz1y5fbJo8jX6qh55Zdg426IMpcDONt+4NGJ5qHH9u2EQ+b9OYunJS+jkhc/9Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 20 Jan 2025 10:16:50 +0000 Usama Arif wrote: > This is to gather statistics to check if memory regions of specific > access tempratures are backed by hugepages. This includes both THPs > and hugetlbfs. > This filter can help to observe and prove the effectivenes of > different schemes for shrinking/collapsing hugepages. > > Signed-off-by: Usama Arif > --- > v1 -> v2: > - Wrap DAMOS_FILTER_TYPE_HUGEPAGE case with > CONFIG_PGTABLE_HAS_HUGE_LEAVES (SJ Park) > --- > include/linux/damon.h | 4 ++++ > mm/damon/paddr.c | 5 +++++ > mm/damon/sysfs-schemes.c | 3 +++ > 3 files changed, 12 insertions(+) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index af525252b853..b0dbf380ab76 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -326,6 +326,7 @@ struct damos_stat { > * @DAMOS_FILTER_TYPE_ANON: Anonymous pages. > * @DAMOS_FILTER_TYPE_MEMCG: Specific memcg's pages. > * @DAMOS_FILTER_TYPE_YOUNG: Recently accessed pages. > + * @DAMOS_FILTER_TYPE_HUGEPAGE: Page is part of a hugepage. > * @DAMOS_FILTER_TYPE_ADDR: Address range. > * @DAMOS_FILTER_TYPE_TARGET: Data Access Monitoring target. > * @NR_DAMOS_FILTER_TYPES: Number of filter types. > @@ -345,6 +346,9 @@ enum damos_filter_type { > DAMOS_FILTER_TYPE_ANON, > DAMOS_FILTER_TYPE_MEMCG, > DAMOS_FILTER_TYPE_YOUNG, > +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) > + DAMOS_FILTER_TYPE_HUGEPAGE, > +#endif I'd prefer not enclosing this part with CONFIG_PGTABLE_HAS_HUGE_LEAVES, so that users can simply use it. If the config is not set, damos_pa_filter_match() will just say nothing is hugepage, and hence will work sanely, in my opinion. > DAMOS_FILTER_TYPE_ADDR, > DAMOS_FILTER_TYPE_TARGET, > NR_DAMOS_FILTER_TYPES, > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index c0ccf4fade24..224308140441 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -222,6 +222,11 @@ static bool damos_pa_filter_match(struct damos_filter *filter, > if (matched) > damon_folio_mkold(folio); > break; > +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) > + case DAMOS_FILTER_TYPE_HUGEPAGE: > + matched = folio_size(folio) == HPAGE_PMD_SIZE; > + break; > +#endif This part looks good to me. > default: > break; > } > diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c > index 98f93ae9f59e..3eb3ec464591 100644 > --- a/mm/damon/sysfs-schemes.c > +++ b/mm/damon/sysfs-schemes.c > @@ -329,6 +329,9 @@ static const char * const damon_sysfs_scheme_filter_type_strs[] = { > "anon", > "memcg", > "young", > +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) > + "hugepage", > +#endif Again, I'd prefer not enclosing this part. > "addr", > "target", > }; > -- > 2.43.5 Thanks, SJ