From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDFEC02190 for ; Fri, 31 Jan 2025 16:30:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0E2D6B007B; Fri, 31 Jan 2025 11:30:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A96FA6B0082; Fri, 31 Jan 2025 11:30:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 910546B0083; Fri, 31 Jan 2025 11:30:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6F1C56B007B for ; Fri, 31 Jan 2025 11:30:33 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DBEACC0EE7 for ; Fri, 31 Jan 2025 16:30:32 +0000 (UTC) X-FDA: 83068285104.16.CEE0BC2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 3485840008 for ; Fri, 31 Jan 2025 16:30:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qcJV2VWx; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738341031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2jkkV8cRNoCAZEf9Dbe/gzMG3EMymMc6jSuG5L+rPpM=; b=r9og+3AyyeWpcnlNXUB2xuDjztg3ugE0HItV+bxy2XiBLSgwH7olZkX8WtoXucpc2Xj0Dt kY9TXqrsURJBsSQM2nA2mcDUk1KUvBWMLnJSSPYlq2uQS9w/MabST+BCVG7hJclffEC/Qo b245HQxjCA+9sECeeu7B9LnsgWB29wI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qcJV2VWx; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738341031; a=rsa-sha256; cv=none; b=XvvYaXyjUwvvl2eWto7NlQkx7ID1UHXFHlW3H3Hh9n6Fpic8cMw8dQ5DOimtchrqb0wqb1 zD7nHToYpuGe3F67yrf+LCSmfyCjjbqcAMpRw+k8ESgOr73mW10YCfaLGSOS1D2TKe2eyU spoT2ksWhzvwWi57WE97ifdMFXndMtA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1322E5C6335; Fri, 31 Jan 2025 16:29:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FF79C4CED1; Fri, 31 Jan 2025 16:30:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738341029; bh=DnWNs2jt2xBVatLffXgilzh5QI1bvhhB2XMLb9Bvh9w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qcJV2VWxEA5xfwjNAwdvqdLJsQBpkKOAV0aZepoTaN++NQXCP1HRRPNg9BdVFeLNC K0P4LvYSjmWCFDLr89R6zIizRBE/UAZtZy5Z3n8eV5hp12H+OF+pNHQoqsh9JuLNNv cTdN3dx2P/eYBJvFPT/LbC2Jg/UDJflNxhRZqb95dvz3ETnHc8PcQ4IszGjiJGqh1Y UI5fSVht1neFopJQJfPxhSSgTNEVzPDBllqLnsGUZ0mTaZEKShEd6sY8+BOj7m2/uX y5sJ25Doy03Ho1pAdh7is7c2EjF3fjQv/u5FYKAws4VTX+F0vRmOWRdiDgc8/4op6j wIl4Ec//RzG3w== From: SeongJae Park To: "Liam R. Howlett" Cc: SeongJae Park , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 0/4] mm/madvise: remove redundant mmap_lock operations from process_madvise() Date: Fri, 31 Jan 2025 08:30:24 -0800 Message-Id: <20250131163024.54001-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3485840008 X-Stat-Signature: c6848yb9386ym9ceuhnekuo7u8oazkxa X-Rspam-User: X-HE-Tag: 1738341031-544643 X-HE-Meta: U2FsdGVkX196pm/nmCcGESQAPSpwAfDRHWXEqY7Iz8+yPHDAlmzRelFc+dmPCs0Tl+CUwHPvf310R5SSQ8Wl1F3o/6dgMQdkdb1Mbc+ot2nGb5S9VP4extk51Kje6yKyoAqsBmUunezz94/E+WyULCmz/a7Bmkh6jgYfAqWNs48K2vlMmNwJAcF54G17CwJKLv9Wu0R9Gb5MJBnCxkJN+goFDhjvZLDldzhijUE9Gy1ZjUyXw+dmtAMKofzZhuOSKIi0EWq8hSDrcCjSQnzNMDvjxgLjE1RQpg5aMkI0bZkGvthAB+TEPhdSVF/cJCdBS2i73pxk+L6jUgYzT+Dqf9cOyhV3xUdrr9W8lbrYuqLAmpXLTUxFb029EgAu/XV19AYSVyK1duRRTGzd1sVCCoG9suuGQtMbr49LwM8WgRY8OswlomZVjmC6lDeWD+fynRstFAfd7rRVk2ZJPMSevrOyP25Vadzj1vCDxTs8tL+yDKamaH0urag/vV0ht1VEptnH/kLSGSJ5FYEh9kWzK91EWWqLVTXNO2u759oTc3Mf5REDhP9VfwqvAdcpH+WCdJ8xTlEDclBX2pDuKJWDyXH3u0f68jU/VvTuJR2/vQEDlykfIptYdYkfsQ76f2PbeqkjJN3UukIcXqPOw+JWizYBZ/U5975WgdklOxHUEUJK8e4FOJsnRjOJW2KwmBPAaQvmiJU/ZEgG97rXyhMGYBxHrWAAfK0xqOaWH7nPIqtNC7Pdq2NNfJ+L4gZMr00iex9nmkS4dAeCSju7/8e0RdmQCNulU0sPm6hKs3cXN3tOOySQrI50CyTFDwHaSAxiMIWPlrw6RtG+d8rvhXGL+Ouq8XP8/Z9N9Boyog97WF0jXh4//32+GOEhQ3Ar/zwwU7WCdup1cZBd1C87sFFa+0eCKcCDWjMSvqAYZNeQHy8Znrcmm91HNK9kMaKL20aWes7Qds0wTGAIGZZOgOl 0/nfS3lw jz/EDawpm1iCUmXPWXIhE0jo3kDLS5RXuW74cTqYAOLhYRJ09N7g8SoT43SzBW1WUB0isY7TkiAoVca6O04BEJrzt9CFphrYZDxWuXNwHOd5UA1DxpOoTthcF4iQ4a0lAOqYBDNBqpQ2hVLhhnktsKU3OQjOl+awl1LW5/Yvq6rEp4fcSlydpJqGKlQ27iNv5SWVA9nmkg49iDYb4gJoLNFI76zE/NWkA6BtTuqBBxK4i5325s2wSiRWFmIyYNuK2IV2LbTjvCw1zAmW77Pl2BFRAMKg7qvQRa4rHF0eu7PNmNFo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 31 Jan 2025 11:04:51 -0500 "Liam R. Howlett" wrote: > * SeongJae Park [250116 20:31]: > > process_madvise() calls do_madvise() for each address range. Then, each > > do_madvise() invocation holds and releases same mmap_lock. Optimize the > > redundant lock operations by splitting do_madvise() internal logics > > including the mmap_lock operations, and calling the small logics > > directly from process_madvise() in a sequence that removes the redundant > > locking. > > > > Changes from RFC v1 (20250111004618.1566-1-sj@kernel.org) > > - Split out do_madvise() and use those from vector_madvise(), instead of > > adding a flag to do_madvise() (Liam R. Howlett) > > I was waiting for a non-RFC to re-examine the series. It looks like a > good clean up. Thank you Liam :) > > Do you think you'll send out a non-RFC version soon? I'm planning to send it next week. Thanks, SJ > > > > > SeongJae Park (4): > > mm/madvise: split out mmap locking operations for madvise() > > mm/madvise: split out madvise input validity check > > mm/madvise: split out madvise() behavior execution > > mm/madvise: remove redundant mmap_lock operations from > > process_madvise() > > > > mm/madvise.c | 150 +++++++++++++++++++++++++++++++++++---------------- > > 1 file changed, 103 insertions(+), 47 deletions(-) > > > > > > base-commit: b43ba6938d01ad4487028592109d4116a28b7afa > > -- > > 2.39.5