From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C17C02194 for ; Fri, 7 Feb 2025 18:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FC5C6B0089; Fri, 7 Feb 2025 13:52:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AC4D6B008A; Fri, 7 Feb 2025 13:52:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19B826B0092; Fri, 7 Feb 2025 13:52:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 024CC6B0089 for ; Fri, 7 Feb 2025 13:52:18 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9A1CBB0260 for ; Fri, 7 Feb 2025 18:52:18 +0000 (UTC) X-FDA: 83094043956.04.AB69840 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf08.hostedemail.com (Postfix) with ESMTP id 02A35160007 for ; Fri, 7 Feb 2025 18:52:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RQpF3WUq; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738954337; a=rsa-sha256; cv=none; b=KxQBdPRmdQblYhdEgEft/lnYWh3VbUBm6trGw0/pNP12gomATbKbJzrOU1yg5WhG7djZIX yh2qwAMc9Mcav3XhCt72A7v6cL8YfMc1mg6+bf/LUoNjIvciwIQ/cT3DyEfiLWPnHjzCwF 5vTWqLyObJ6NRYxLAQKxTYjygCFkouo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=RQpF3WUq; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738954337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ne+mt5tj6NqFhsCUI2mDn68ML2Iq0X0N1Q5oFLKZstc=; b=IP3lvScO680As1EJpCEDOm+3PLjCJ8CtN7gPL9yu2ttKxycmRx4th9SbojPtcmcrLYFE9X jZRg9n/+K7c3liWJaBGU3eJohKAGyFxVR+rwnexvzPsma3ZqDE/68ZKcbPH4VJR8aou4nS QEKY4X67RVM/MHpklK9jJ0aSgh1n644= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 552B2A43A1C; Fri, 7 Feb 2025 18:50:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2431C4CEF7; Fri, 7 Feb 2025 18:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738954335; bh=BFWvHtCqI4zHx0zSd21fwnlKrln4GSc/JnQ/Pky/4EM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RQpF3WUqxEgU+XzXEz5sFp7DqVylKk1Bi0ADaBuUG6nV3iZmlG7y7Q20/yr+lHnMW N20d0uDA+BLXHRqq7SlSUYNiOQhJGxqydRTHVB0YATT6WKdqTpNTocXHQTLPrszZ+N moFNkQcnif3chxG99RQkJbSBaWxrl4UpwN0pB3aNBY3xXazcs9EyZNf2N3cz9nuIhn wDdsV+Nbx+T7B5QnZUHZYNhQil95R7eoGoPBRJH+iOLabnKeOMnzXXJE8nIszbsTco QbkXNkcv/fa21fZ2Y1nUXa7vZTbfNgCbB9YvWvTM0VhXXcIZ8gqNRfqVY/UOR7N5Qf OWr4X+KkX8oOQ== From: SeongJae Park To: Usama Arif Cc: SeongJae Park , akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, hannes@cmpxchg.org, david@redhat.com, kernel-team@meta.com Subject: Re: [PATCH v4 4/6] mm/damon: introduce DAMOS filter type hugepage Date: Fri, 7 Feb 2025 10:52:13 -0800 Message-Id: <20250207185213.43553-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 02A35160007 X-Stat-Signature: yxj9y46fk7inmxxokkbkbwib1yr5nb9u X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1738954336-884551 X-HE-Meta: U2FsdGVkX19X8s/fYyjyudv97qwGvIEu6w8vn+ys9GfrBOUOYIcxATZo6W3+YR+Bh/wlTUD95XrsOwweH0ulDSSIdOBAbbBExSbAcfHAsMtdm5uqC8ptTA0HrWPE5xilOIZ9Bsjl0gwoNK40GDr2sNV9mPNat4Uwm1aNyigvEEP+aptmXd+B9Sz4Z5X+wk+BklOOx1dK84p7AA+wdTosC5ZgOUolYtTayN6e1zZSfm3w/EggAFatvst1KBaiF4W2pWEbynVcU88tKincEQnmUOMdMYlea+OWewf9Qe7+Uq8PKRf+EI9Lp1rGdqUB33hyclKtFMCm8YPdrfGlqCMacRc4WXCMY7E1Ly+GdGSmWzXtWP5wAg36pTLn4oqy5pTvTAoDWiqQRg2P/wSEuu7aBysvCMSQ2c1MpT6dbVu+AuPfZ5C9lYci1LSoFHZ1pM61V/n0MhrDqgXrkW5eKPltd71F0Iiagl9tr7zK3KKk1I0gFt30DGP/O3DZwfyRJv4YOtpK+7Fvy1cS/o0CxpYnYHm50AOvashLz9Aap6ZP5FShHwPIfiV12wBe4DPNm1i1nepGpnNJtUm1k4/1Vt7LlJTqnMWzPzQroVY1R5lDyX0dYnvUkoPIgit0KecWjDisZL4B+0V2JnzOYETCnBQu3M/8TxDCfI/t8YisuaaUREriGQ5rTP2oACz/btSFlZ1Ihh6F4lP400FHmHITqgrht1GWF//NaAoqeSGCqw8pJODNtvqNt4YYLfgTNzWxjBnIBln705aRZcvYencZT+JVhivUspu5xqKJqBZwd1r/RuISFYytC9MkyHoSIN43ON0Rq3wBj/FYqW0N6PDxD5R5YeRsMEcD4Q6EUF6kxlU2Zz9Mt6lfnShUGOzlRWi3bFVKKR5leKZ0lpVZWrQknuT0EEPQ+zLhN8wt3RSZ3h+fXyWiIjhDWlG9T5hJeaR+03b/qUlg3FKGCytpNrqsQ6L Qp+v8nUJ apR602P6A60hSYPb4zMkieLw6rMOHZ/TsrKyfOyIalMDPPd5Vmq58lL2JFM9rZnFlzk9f0IFLWMlaiAy1lwuaXJSGv2l606StOZj89tl/M+qPtWSiyJWCcmGCg61DIRPS9u15mQIQV9xQlFWYo0GRnge82aRwlqstVRq2boyzrHVivFUuBQ6EQ8y1yEVxGW5J1jiQ9a2RMFuPav5z7E3EzjV0mqniJwC9uXpSe7G0X2m6SLY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 7 Feb 2025 18:22:04 +0000 Usama Arif wrote: > > > On 04/02/2025 23:12, SeongJae Park wrote: > > On Mon, 3 Feb 2025 22:55:31 +0000 Usama Arif wrote: > > > > > >> + case DAMOS_FILTER_TYPE_HUGEPAGE: > >> + folio_sz = folio_size(folio); > >> + matched = filter->folio_size.min <= folio_sz && folio_sz <= filter->folio_size.max; > > > > We should also return 'false' if the folio is not a large folio (folio_sz == > > PAGE_SIZE), if we agreed to my suggestion on the previous version of this patch > > series? > > > > Thanks SJ for the reviews. The pleasure is mine! > > I will address all of the changes in the next revision. Looking forward to :) > The only thing over here is, I would > like the filter to work for folios of all sizes, even PAGE_SIZE. It would give us a more convenient > way of knowing if hot regions are mainly being backed by 4K pages, and improve observability. > Let me know if thats ok? I have no strong opinion here. Unless others have concerns, I'm ok with your approach. Thanks, SJ