public inbox for linux-mm@kvack.org
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
	Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH 0/3] may miss to set node dead on destroy
Date: Sat,  8 Feb 2025 01:18:49 +0000	[thread overview]
Message-ID: <20250208011852.31434-1-richard.weiyang@gmail.com> (raw)

Per my understanding, on destroy we should set each node dead. But current
code miss this when the maple tree has only the root node.
    
The reason is mt_destroy_walk() leverage mte_destroy_descend() to set
node dead, but this is skipped since the only root node is a leaf.

Patch 1 fixes this.

When adding a test case, I found we always get the new value even we leave the
old root node not dead. It turns out we always re-walk the tree in mas_walk().
It looks like a typo on the status check of mas_walk().

Patch 2 fixes this.

Patch 3 add a test case to assert retrieving new value when overwriting the
whole range to a tree with only root node

Wei Yang (3):
  maple_tree: may miss to set node dead on destroy
  maple_tree: restart walk on correct status
  maple_tree: assert retrieving new value on a tree with only root node

 lib/maple_tree.c                 |  4 +++-
 tools/testing/radix-tree/maple.c | 24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)

-- 
2.34.1



             reply	other threads:[~2025-02-08  1:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-08  1:18 Wei Yang [this message]
2025-02-08  1:18 ` [PATCH 1/3] maple_tree: may miss to set node dead on destroy Wei Yang
2025-02-10 14:19   ` Liam R. Howlett
2025-02-11  7:48     ` Wei Yang
2025-02-11 15:23       ` Liam R. Howlett
2025-02-12  0:26         ` Wei Yang
2025-02-08  1:18 ` [PATCH 2/3] maple_tree: restart walk on correct status Wei Yang
2025-02-10 14:20   ` Liam R. Howlett
2025-02-08  1:18 ` [PATCH 3/3] maple_tree: assert retrieving new value on a tree with only root node Wei Yang
2025-02-10 14:18   ` Liam R. Howlett
2025-02-11  8:02     ` Wei Yang
2025-02-11 15:25       ` Liam R. Howlett
2025-02-12  0:41         ` Wei Yang
2025-02-10 14:31 ` [PATCH 0/3] may miss to set node dead on destroy Liam R. Howlett
2025-02-11  8:11   ` Wei Yang
2025-02-11 15:28     ` Liam R. Howlett
2025-02-12  0:49       ` Wei Yang
2025-02-12  0:55       ` Wei Yang
2025-03-04 12:07         ` Wei Yang
2025-03-04 14:45           ` Liam R. Howlett
2025-03-05  0:32             ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250208011852.31434-1-richard.weiyang@gmail.com \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox