From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A469C02198 for ; Mon, 10 Feb 2025 12:45:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3834B6B007B; Mon, 10 Feb 2025 07:45:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30CE06B0083; Mon, 10 Feb 2025 07:45:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1865B6B0085; Mon, 10 Feb 2025 07:45:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EEE586B007B for ; Mon, 10 Feb 2025 07:45:02 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 841364AAB9 for ; Mon, 10 Feb 2025 12:44:20 +0000 (UTC) X-FDA: 83104003080.01.84D21F6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id A3AF1A0009 for ; Mon, 10 Feb 2025 12:44:18 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EAZ36+Y5; spf=pass (imf15.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739191458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wgfiPQIv5/8AasTDk1SSI4A81+6rIbhJTTfC+jpz/Os=; b=jHE/pzzQtBCktodcEH56VsRENvokWot9vv8MvRmWvccqT+5CX4aSvx/phcKoKVdC8plXb/ HpiJcn35wdOxvFAkmKGeyXwoCbtW52hPDTQLCZxWLU0kxxvnXgrZq+ZKc8RgdLIH6afyo2 dlWXhQoA6YLp8mlDmEeGyo5ULUIEs7g= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EAZ36+Y5; spf=pass (imf15.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739191458; a=rsa-sha256; cv=none; b=JmhWS03AK7y6En9zbFf7Fk+jpDUPDNmLzIIw6pLIzVdl8Sh31H8BYp/+v1VXzJfbqkiGgG /wzr/Ept7v/e9TfDKhIQ0HA1SaIz2WiIjbiYbz51l7G6Qpff3aOJa3qaPQaNJ51766tYKk ny7vTr2LAgXOP30fUi67sWDmyKfbjpk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739191458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wgfiPQIv5/8AasTDk1SSI4A81+6rIbhJTTfC+jpz/Os=; b=EAZ36+Y5YL0T9RNYPSgMnhCXqKqIHRzXVxl53ulVxq8m8s8/OH6wibRli071PgEvzRU+F+ pSGR+LMkJEHPLryswJNCMm0EsYfsOimcIPA9EHYG3dU2X/mBNWtI5axZQhC9QbM1Ab9PxW 3Bmbv4kSVpZCiG4ZEBskZYfJjdk1p6k= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-Sv9hUTHdMCqiMsS5eOYDIA-1; Mon, 10 Feb 2025 07:44:15 -0500 X-MC-Unique: Sv9hUTHdMCqiMsS5eOYDIA-1 X-Mimecast-MFC-AGG-ID: Sv9hUTHdMCqiMsS5eOYDIA Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F92E1800982; Mon, 10 Feb 2025 12:44:13 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.113]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 1968019560A3; Mon, 10 Feb 2025 12:44:08 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 10 Feb 2025 13:43:46 +0100 (CET) Date: Mon, 10 Feb 2025 13:43:41 +0100 From: Oleg Nesterov To: Frederic Weisbecker Cc: LKML , Peter Zijlstra , Ingo Molnar , Valentin Schneider , Marcelo Tosatti , Vlastimil Babka , Andrew Morton , Michal Hocko , Thomas Gleixner , linux-mm@kvack.org Subject: Re: [PATCH 1/6 v2] task_work: Provide means to check if a work is queued Message-ID: <20250210124340.GD32480@redhat.com> References: <20250209223005.11519-1-frederic@kernel.org> <20250209223005.11519-2-frederic@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250209223005.11519-2-frederic@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A3AF1A0009 X-Stat-Signature: hqexaf6q6qn4br4xwby96uf4e5r1nwho X-HE-Tag: 1739191458-365110 X-HE-Meta: U2FsdGVkX1+OAtov7jDGqlB1aA6AuSboeMPhUY8hBPfXWmxfUXwOAKDsHDV6QoEPe0tKVbB1ZebroYuP2mKoO6e9wkKdhkuq1ko3zf/jTpoaSTPlulzrGMniHYaU9UVqLn63C2UDrcRYNtG/I7O8mYwRvqxasMCsQLhSvRviYu+VkC43lyPQXkfA8QFMvFZGtlmRAQUyvoUSlvhq7gepwSeNxGlE8PUOEXRkoi89mmc3x2jon4w5P4ZBcQk9MkQw37awBh6kGkbNbS+gLkXgn31tr38Uei1GdPOpcc41mOVHUDd/eSBQo9Y0wipjdNef2xiAkFfZn9xQBKdd0nAO39HuyHPQCM1wUc+tcBrggnWgt2jqgNQ7EDpnwDZrbNNx+ItA6dAF5MP4DzVM/W60o1Gk7rJg4grgcH8vmGaz8nnxrhrp5unU8+tyZIdV4DhccAUZvPnjhYQu8210lI5OEX8dfeVoTyBoHwnK5/OjCotGrirwcZR5LD4j/aoUkDQfiqqa0WLsIMMX5DqunNAa1gExKPzVxNXVjAm7ymwpFgEv2j/YIh09JyhtrkoWyPJfG0cmUBCj2VWoY6zNSvhKibUzRydIJhXn0Pp1Q6cD6Ymk65VV9Cbjf2Z4xES7PGN7mySlVEOk+VRFU6e9egpsl/LNM2SJ0cqcRNw4491kgkfm7soqvv1rShC6sW4SxEBeScy7fGhfjYHh/oOR30QQFeOZUq2PfplWqSNvrnUOaIi83bwazJoqEUyoXIsrpAxCQw4J49sr0LpAqCgvqf7AUInnQtWCqk/qCMQ0R7xfdjcVzk3nNoBSxhD0ZHtDjUHH/VBYw/R+OLlu+uaAEdQq8d+KmH9Ruwas58p/a1o0QQsuMZ1thHog9FWZsCkJBQ3CdUao8h7B+uBAkn3RGEdvT8AAJDcFBqL5sIMqnTVQBhgPS5iWW6QsyclbSnrijiYzyswTkR1r3cvrXQbxQKY UYl4TFYu ZGAKs1QfK8jd378DMGLWfdxAAR1OE4QH0HjOb2ZlB0piaMuchduwNaHaonzhPiqMtMtea+DP05WtP3N60uE+ex7Yni9T6TBXN/t9FoiQm0x3yYAIvQrrdyoVKzJZXulnRZDLkXsiJQh/udaLq9quWoAfgPVTNzyXiJh5MvHnvQ9SZLtBh2EyA01K5sxI4iXI0Kr6ryi+hPW+C2RcaUkqvajrgcUlBLQze1ftCtcXrEAkP51yF7iIu7+HjGUwDhGQPVQi973iKKeoLFHwxySQm/O4wb+4a7EI4YV5k8orveoBFLQLN2h/EuaKHQIHZDcKFmXHeJ8a1cChqSVwZaQRNFD9rD7EN6xHgJyahAy1kXDTCdscAh8tzMYs8o3MCBGc/J745pkTmWSjqP6Ib8n+6aQNf2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/09, Frederic Weisbecker wrote: > > @@ -56,6 +56,8 @@ int task_work_add(struct task_struct *task, struct callback_head *work, > { > struct callback_head *head; > > + work->next = TASK_WORK_DEQUEUED; Do we really need to do this at the start of task_work_add() ? If the caller didn't do init_task_work() before and task_work_add() returns -EINVAL we probably do not care? Reviewed-by: Oleg Nesterov