From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD34C02198 for ; Fri, 14 Feb 2025 16:45:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE03C280009; Fri, 14 Feb 2025 11:45:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B906A280008; Fri, 14 Feb 2025 11:45:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5898280009; Fri, 14 Feb 2025 11:45:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 877F5280008 for ; Fri, 14 Feb 2025 11:45:50 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 024C61C7C6D for ; Fri, 14 Feb 2025 16:45:49 +0000 (UTC) X-FDA: 83119126860.11.4E95951 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf03.hostedemail.com (Postfix) with ESMTP id ABBCC2000C for ; Fri, 14 Feb 2025 16:45:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=e5+N5soT; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf03.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739551548; a=rsa-sha256; cv=none; b=p5KpLlOyRXaZvzrXKMsRRjVcOuhOISJmNP7ETYBr+dKu7RSr4ro5g83CA+Cryxxb44Bujt 2hJ6hbRurz15oBlnyh71K8cZUkc+OUfl5C6f8JygyV0Q1zRCrU/m+8fBcpKcC1GK7Q99yF UbDiPCdVTcHI029+DvKXwz+XDlCS+yY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=e5+N5soT; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf03.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.169 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739551548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ngroD9vi3+Uljzg3R1uHsM+zWtaFeoRiAMLeO+Fv5uo=; b=TipgNkUdnFfv8E8KejPkFSXo2pAAcIK4gQfryoxtEjUGlEMzB1r+V36VWgPpPyt3gNQbFw azK7kWuOB2pqs0wKNcCd9ldcnRrItgnRYJKkhq6p2U/rU3tva1NurNYK/REC1fyzfysmAp fAZft6MUpUxBGl92ouCXEVoUzu2ZGqA= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-471c8bcb4a9so14397131cf.2 for ; Fri, 14 Feb 2025 08:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1739551546; x=1740156346; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ngroD9vi3+Uljzg3R1uHsM+zWtaFeoRiAMLeO+Fv5uo=; b=e5+N5soToHMVZa4O0g7PcBoQmaSbB8ZXS4RaDYBWG3W3nngKcaMZTeOXB4Cw1wGs5E SrpZm5xzPXdlTGsiuEQ+X3ie14l6TjrU6ZU9XtkDpONbjP3f1WdW1e+0pNW7gaN6AXha 7Q7xYifG+dF2Xdut3wqztNKW4bIsF7L8PcSIZHPuPe3hZ5lxOCmmoOzD7rqFGzWYuZRV 2Pcw6ol80IHQVvJtDPFujvzvjmMtx/BTReggFQnPI/gtkoEfgq0vrnD8Wi6g3YXQFF8z s9f3CHNIbTyCKe8hUg0VPyWieCeWzlQPietVd1FVVuBfid8KzAvqpMTDFvstg4iqreDh d1Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739551546; x=1740156346; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ngroD9vi3+Uljzg3R1uHsM+zWtaFeoRiAMLeO+Fv5uo=; b=ZirMfKvklGUC7J0i66lsfKq7YzqrDh2aYuKfSacRYOATh3vlxy8hxYF9TnGCXOMKGV QCl7iQO/YeYIn29xDEif07462kwS2+kNudjBm1tZD+Cfd0ry3TlYayHPXClAqGfmdFCZ +294G3pxnsPoM2wrRlZ4nNMfv6DZ/GLmmlJvGBwnZVUEpYjcnDmNMARNvoNZguGrti9q up5xpCrWrXIYKtson+tzJ7RIDMIMEgr3Ca345jy7OFIbdDzn19A2dcCdl+JbaTriVt5e FnwB1ThRu4g1KIH+8kaC573/Z1qjbnXwioMsjNhNEaUiVZlLZVrB548gFvpd7yXNwjFv y5Rg== X-Gm-Message-State: AOJu0YzkWzNHfIv0CuAPinYE2xILxTkxlIUef17JUEcOAsdOAchO0oOi Dl/hKxafLjCq3+28ayi+qqcwtjHGIDtr/5dLTxm1ZRj7G93hukHgwYm7eG0omdp53o5HfQdD9uF 2 X-Gm-Gg: ASbGncs9VKdPOi+Hcer5wXiZjlS0uGyaNfJ5JUA/shNdt5eA2pBRkfF03uBszEg0Rrf 3XD8/6qgas2EIJcheDcKLofl5Fbjkj18ZyTq9BZsGvbBeWDtU+i2h9Vxzh9AtPAfjHxuCaqnE3m xFx4nf0l+QoIDdrsAdNd67XA37k2aqAb7ZwIL+phcllGmzeb/m7NeMNILxDlFFDKO4TvSn/bNNx nI9OtUBcyYwvE4NDNQhuI2wkpW+ZF4bMazfpLmey72y1nqde2R9pWa9Zn42sBtrHr8f6ckcnLPz 5VXtGP7OQvr+mw== X-Google-Smtp-Source: AGHT+IHLiyAZD+OEUbtpbB5HAJMOScUjybQrh233VZ0NaF3TDsAi1xa3b7qp2N0oFxqTB4jbuwrTSg== X-Received: by 2002:a05:622a:11c1:b0:471:aee9:dedd with SMTP id d75a77b69052e-471afe034efmr181771441cf.5.1739551546620; Fri, 14 Feb 2025 08:45:46 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-471c2a125b1sm19458431cf.24.2025.02.14.08.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2025 08:45:45 -0800 (PST) Date: Fri, 14 Feb 2025 11:45:41 -0500 From: Johannes Weiner To: Zi Yan Cc: linux-mm@kvack.org, David Hildenbrand , Oscar Salvador , Vlastimil Babka , Baolin Wang , "Kirill A. Shutemov" , Mel Gorman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/4] mm/page_isolation: make page isolation a standalone bit. Message-ID: <20250214164541.GA233399@cmpxchg.org> References: <20250214154215.717537-1-ziy@nvidia.com> <20250214154215.717537-2-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250214154215.717537-2-ziy@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: ABBCC2000C X-Rspamd-Server: rspam12 X-Stat-Signature: e8iucg5hf9xu3sgggpcxs7ki7jqktt7o X-HE-Tag: 1739551547-271415 X-HE-Meta: U2FsdGVkX19alv+QJcDqlANbGoGjEOaScz1yDcJd+TntHzi92QewzoceCu9Kn8fkGV9plRG/vQ8wR33+7EjhtEkhbkO1wm+dEI8NoYfcGF5hF4/4U4YrpHrpjo3/F+jafuub7YeiXoulsqeA8EA2RJvUXHMmsm/SK1pBAuxzRZGiK5S6HHRdgpUAiqiwTKxT/LrWnZJ/ob7W7JJnmm0NApqO86wQErn/i6ocCVwCZ9tfHH7lF4WotJIoC3WuOFToX8wr02tXtBbwUwfn/JJKHf6wLSJKCwQa/33TSZ4K9LjWBO2TsxGBAAHYRCAD32DyuwxaVn4/tHNpmigfF/DfgDjTaCR8RDZ7JrRgxOiF8sPicv4dnSxTO5oQwX263mjQorPmPrOEPUHN8yz9dmO7sgKB8L10v99K2VPZ5q+JefH5UhoPGvwsO4hqsXrdjn7WF009mBdxMOUWF2cS0ildWaKYwYz3ce2kWGDpjgNKRHRBDMSiHOYBMbiGSXbWZwyx85KNSs4OJJqh8o47UYKrjc8McVqBwcB7fTCHv5yXFTfNsOHnt5VEpO/B9IJ123bVsrPBGv3Db64s8M+sJotPXUkzXA4C0xlmH1ZlISeqJszwYxUGQQXBXa5w8SxDPP4SgVRftUk/yreaOjbM3T8us36ck4xWzf8yrmtaCzuzuP6l22SRDheYvuomUYQ4ejwF0A/QCIXr2KRs/VuGtRbntLMWCl+o2UEoR6QbrB6AYxk/7FADSaHkX+g24XGeC0rhfLfms0uw/BUswsKwlTAN+/GQvVaIRLYMz1mhxGIsofyn0MRwnfgatSfT3AFuuDeV8CCuOSNH1GDNiamPEeJYdILLTcUWWaM7CfPjlu5wZUPDVutS18ujZ/bDgzA2DCLeq2+NDoSJ6tjMMUkpMfdj+x011GzvGfZ7fiUMpmyQBVJX6863kzuA6x+c+mOJRQOazfVmdIQfgTbHDaOD+N1 e0bfU2u8 cIzjpE1iaQRXM8Ffi1/b/XF/REZuS++/2FNGcrAQaHUw3eN1kgit5wWKkHFm1idJR6jh2vJQ2airngx2MrdiC8tUftBN7cGF6TmPwrU/oejL/2mH95F9qR/eme9Y8dnXXEXuWZN8qy7PQRV13KkDpWFhLBotwnn+d48uABMZK6+DboHrMfN0eJTEJG/A9FoKA2zAa4GYYj8vKy93tRxOWg5SWqgp5Ci7Y17tfx/0CCPwF+cRtaYYCos0wosF36dDvvv4m+Lm+XKQQI4abctGmndx5vPCUkjfV7CjbnmuwFit+S45ujq3ovJbv3+vokJJ3yM+DmFJPl54awUC463fgOb4faS3HwXF1LKiaG1UCt6/PCbKt3LXm8qLEhf8CxeGBk+vY43yO27VJGB+L7NGOPR6N204fj7K3E74qSfTfN9CoxgYFNuNL6EcuwRk9W818VrIzjZbK28m/1FLQlAnXgHrKQdDw2iDiYQksKaMPiKwZpLZS/520bUMgf89ceK3r2RuEi5O/5VqwO6MkjVCEmyppLQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 14, 2025 at 10:42:12AM -0500, Zi Yan wrote: > During page isolation, the original migratetype is overwritten, since > MIGRATE_* are enums. Change MIGRATE_ISOLATE to be a standalone bit like > PB_migrate_skip. pageblock bits needs to be word aligned, so expand > the number of pageblock bits from 4 to 8 and make migrate isolate bit 7. > > Signed-off-by: Zi Yan > --- > include/linux/mmzone.h | 18 +++++++++++++----- > include/linux/page-isolation.h | 2 +- > include/linux/pageblock-flags.h | 33 ++++++++++++++++++++++++++++++++- > mm/page_alloc.c | 21 +++++++++++++++++++-- > 4 files changed, 65 insertions(+), 9 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 8aecbbb0b685..3c7d3f22ccb2 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -106,14 +106,22 @@ static inline bool migratetype_is_mergeable(int mt) > > extern int page_group_by_mobility_disabled; > > -#define MIGRATETYPE_MASK ((1UL << PB_migratetype_bits) - 1) > +#ifdef CONFIG_MEMORY_ISOLATION > +#define MIGRATETYPE_NO_ISO_MASK (BIT(PB_migratetype_bits) - 1) > +#define MIGRATETYPE_MASK (MIGRATETYPE_NO_ISO_MASK | PB_migrate_isolate_bit) > +#else > +#define MIGRATETYPE_NO_ISO_MASK (BIT(PB_migratetype_bits) - 1) > +#define MIGRATETYPE_MASK (BIT(PB_migratetype_bits) - 1) > +#endif There is no user of the NO_ISO_MASK until the last patch. Can you please defer introduction until then? > -#define get_pageblock_migratetype(page) \ > - get_pfnblock_flags_mask(page, page_to_pfn(page), MIGRATETYPE_MASK) > +#define get_pageblock_migratetype(page) \ > + get_pfnblock_flags_mask(page, page_to_pfn(page), \ > + MIGRATETYPE_MASK) > > -#define folio_migratetype(folio) \ > - get_pfnblock_flags_mask(&folio->page, folio_pfn(folio), \ > +#define folio_migratetype(folio) \ > + get_pfnblock_flags_mask(&folio->page, folio_pfn(folio), \ > MIGRATETYPE_MASK) That's a spurious change currently. I assume you tweaked the MIGRATETYPE_MASK parameter during development, but I can't see a functional difference now. > @@ -373,7 +374,13 @@ unsigned long get_pfnblock_flags_mask(const struct page *page, > * racy, are not corrupted. > */ > word = READ_ONCE(bitmap[word_bitidx]); > - return (word >> bitidx) & mask; > + flags = (word >> bitidx) & mask; > + > +#ifdef CONFIG_MEMORY_ISOLATION > + if (flags & PB_migrate_isolate_bit) > + return MIGRATE_ISOLATE; > +#endif > + return flags; > } > > static __always_inline int get_pfnblock_migratetype(const struct page *page, > @@ -397,8 +404,18 @@ void set_pfnblock_flags_mask(struct page *page, unsigned long flags, > unsigned long bitidx, word_bitidx; > unsigned long word; > > +#ifdef CONFIG_MEMORY_ISOLATION > + BUILD_BUG_ON(NR_PAGEBLOCK_BITS != 8); > + /* keep other migratetype bits if MIGRATE_ISOLATE is set */ > + if (flags == MIGRATE_ISOLATE) { > + mask &= ~((1UL << PB_migratetype_bits) - 1); > + flags = PB_migrate_isolate_bit; > + } Please change the callers in both cases to pass the appropriate masks of interest instead. That's likely a bit of churn in the allocator code, but adding caller specifics to this function violates abstraction layering rules.