From: Brendan Jackman <jackmanb@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Brendan Jackman <jackmanb@google.com>
Subject: [PATCH 3/6] selftests/mm: Skip uffd-stress if userfaultfd not available
Date: Thu, 20 Feb 2025 15:03:15 +0000 [thread overview]
Message-ID: <20250220-mm-selftests-v1-3-9bbf57d64463@google.com> (raw)
In-Reply-To: <20250220-mm-selftests-v1-0-9bbf57d64463@google.com>
It's pretty obvious that the test wouldn't work if you don't have the
feature enabled. But, it's still useful to SKIP instead of failing so
the reader can immediately tell that this is the reason why.
Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
tools/testing/selftests/mm/uffd-stress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c
index a4b83280998ab7ce8d31e91d8f9fbb47ef11d742..db5366b4766e5bfa2d1150d2f3c2d32469a6e28b 100644
--- a/tools/testing/selftests/mm/uffd-stress.c
+++ b/tools/testing/selftests/mm/uffd-stress.c
@@ -411,8 +411,8 @@ static void parse_test_type_arg(const char *raw_type)
* feature.
*/
- if (uffd_get_features(&features))
- err("failed to get available features");
+ if (uffd_get_features(&features) && errno == ENOENT)
+ ksft_exit_skip("failed to get avialable features (%d)\n", errno);
test_uffdio_wp = test_uffdio_wp &&
(features & UFFD_FEATURE_PAGEFAULT_FLAG_WP);
--
2.48.1.601.g30ceb7b040-goog
next prev parent reply other threads:[~2025-02-20 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 15:03 [PATCH 0/6] selftests/mm: Some cleanups from trying to run them Brendan Jackman
2025-02-20 15:03 ` [PATCH 1/6] selftests/mm: Report errno when things fail Brendan Jackman
2025-02-20 15:32 ` Dev Jain
2025-02-20 15:03 ` [PATCH 2/6] selftests/mm: Fix assumption that sudo is present Brendan Jackman
2025-02-20 15:03 ` Brendan Jackman [this message]
2025-02-20 18:06 ` [PATCH 3/6] selftests/mm: Skip uffd-stress if userfaultfd not available Dev Jain
2025-02-20 18:17 ` Brendan Jackman
2025-02-20 15:03 ` [PATCH 4/6] selftests/mm: Skip uffd-wp-mremap " Brendan Jackman
2025-02-20 15:03 ` [PATCH 5/6] selftests/mm: Print some details when uffd-stress gets bad params Brendan Jackman
2025-02-20 15:17 ` Brendan Jackman
2025-02-20 15:03 ` [PATCH 6/6] selftests/mm: Don't fail uffd-stress if too many CPUs Brendan Jackman
2025-02-20 15:48 ` Dev Jain
2025-02-20 15:55 ` Brendan Jackman
2025-02-20 16:01 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220-mm-selftests-v1-3-9bbf57d64463@google.com \
--to=jackmanb@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mjguzik@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox