Re: [PATCH v6 1/7] mseal, system mappings: kernel config and header change

Dave Hansen
2025-02-24T18:52:14Z

On 2/24/25 10:44, Jeff Xu wrote:
> For example:
> Consider the case below in src/third_party/kernel/v6.6/fs/proc/task_mmu.c,
>
> #ifdef CONFIG_64BIT
> [ilog2(VM_SEALED)] = "sl",
> #endif
>
> Redefining VM_SEALED to VM_NONE for 32 bit won't detect the problem
> in case that "#ifdef CONFIG_64BIT" line is missing.
>
> Please note, this has been like this since the first version of
> mseal() RFC patch, and I prefer to keep it this way.

That logic is reasonable. But it's different from the _vast_ majority of
other flags.

So what justifies VM_SEALED being so different? It's leading to pretty
objectively ugly code in this series.