From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22578C021BB for ; Mon, 24 Feb 2025 16:02:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A90636B007B; Mon, 24 Feb 2025 11:02:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A407B6B0082; Mon, 24 Feb 2025 11:02:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92F7D6B0083; Mon, 24 Feb 2025 11:02:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 72DD86B007B for ; Mon, 24 Feb 2025 11:02:20 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B814D1C8CA4 for ; Mon, 24 Feb 2025 16:02:19 +0000 (UTC) X-FDA: 83155305198.06.DB6E6F0 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP id E0DFF140044 for ; Mon, 24 Feb 2025 16:02:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740412937; a=rsa-sha256; cv=none; b=JGeVVianU9Bv7D2DCPomKPpEUGj7aRdkoWpuKN0wz5Z3EBqzfO5EY+9nitceMfFGQwAyCE Ww7qySN6pd4g87+8/acOx2khfjrXlBeIHbgupnjDlwmMADoV8EX9nwaR9pqSazm40EtDn1 o1uq31Z8b6wfv1kwUvmuwCIc99e8Lik= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740412937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KGTWjvtb+6Tnwgqf+kMV6m/4VPxG7L1QgxU5BeApu80=; b=3Il72M9zIOk0wpckSkbD9e1U3dxPHh50UbOmDmWDU6rv46PzQXEayyaMVFqWNNCrU1HCrO pNq5a5/hWN2uup/CcwpZlaLAGfZAnvjiROPxzZU17c3dtbLs4P1msvrgmgEkSuJ1+ZVJ2G ToCBGXy3/+5IRttqBAiCTEiSnzmnbIk= Received: by verein.lst.de (Postfix, from userid 2407) id 7B47268BFE; Mon, 24 Feb 2025 17:02:10 +0100 (CET) Date: Mon, 24 Feb 2025 17:02:09 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , "Raphael S. Carvalho" , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org, Dave Chinner Subject: Re: [PATCH v2] mm: Fix error handling in __filemap_get_folio() with FGP_NOWAIT Message-ID: <20250224160209.GA4701@lst.de> References: <20250224081328.18090-1-raphaelsc@scylladb.com> <20250224141744.GA1088@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: E0DFF140044 X-Stat-Signature: g1fokb9qy81gex38zx3je4wzwqea9ygj X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740412936-814384 X-HE-Meta: U2FsdGVkX1/RjKcvBA95N2RrKaMeDRf+WMvtn6caCi5J6xNQrcGxlIvEsJM2zuyNaaJseFhbTnqBxEaozuZIuX6dGCh3aHFIi42CGwsFM1LB799irp5wnVtN+PDylLXgj8euW0JrJfO7qqPv/T4QaV7A9BglsdB5OE0moj1UA4bf6soW20nzV7YFrJt1ZiRPG2wQ91M4xFJVF9YMcbYWsY4S+AtEA3R9wxgQjVNFxkTyAoGId8cPuJd+OyF9by4mSynRrlnBunPom7DoJ/HOHGZjwHTmWVODQDvx5E8aINFLpUILdEz4ehMB2QczKTgjpps3lBN8S22lXjNxXJgD48Nz+tlSwrA0PtJ/UjcNEm2CRzNCAbFX5DwJdRjT52WAjKcN1gdvxOQxatw9wVpq8ZlZf6gp8+/cpUvPBQvtlcAPBAPx/8Tz719WclvMbnfo9PCZA7wr4dfIx8Vj7v9Jjz81uXvaKhzRILR8xrG/ZILBzC7Vokh/sjSSpXm3vcynTlQPy40HCGwQB6q3skJVxsQzTCaD+zCkvA769T73h/owai+zzdHb5KICrAFOvC1JqdI7Zd75n7yDmAcAGQ2PCKNB+ns2sHDTOyJbZ4Ve0BOYHCm2r/b4butnxim7ydvBrmDvf7RnKBG5p1OQSLMu26ltMBm9JCdNThkTPAv1XO6Wa5LKI1rATQ8dquhJV1+5wDQk9hH9CN3P67dS2kb0DuYEC6nb0VPvCs12NNCbVWI8WgIhdpSG/zaq44asDQckJX8l3cp/vDWQ3AgYyjn+9DrVT1RdbEZfA/y7sxSQNbipdO7qmUZ6HGSCzYrN4rdG0szaCAQgCoCxStTvcvBgqJPjQ586PHHGYnnGDlEJvS1zAF54q9FJrlS7aHBiiOsChisoLJq3e8LPWGHxADB+AKZFYfnB9FWDPjwkx5avppJfDdz9icW9HA2yVI1VghLR33HmHrLtVrQHWXF16Ef nI9f0Mz7 lTnswCV1kgvDRSKX34egqiQTCHO9uip+rUTZnVAkgGjPrMJ6dMgMCt5E7gN3DZOo41s/hfOfPuWM0aMiVMoaX2O4vyXRMc3pOEVeG+9vvX/K6j69LU4A6m1iX2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 24, 2025 at 03:33:29PM +0000, Matthew Wilcox wrote: > I don't think it needs a comment at all, but the memory allocation > might be for something other than folios, so your suggested comment > is misleading. Then s/folio/memory/