From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: "Kees Cook" <kees@kernel.org>,
"Eric Biederman" <ebiederm@xmission.com>,
"Shuah Khan" <shuah@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Andy Lutomirski" <luto@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
"Willy Tarreau" <w@1wt.eu>,
"Thomas Weißschuh" <linux@weissschuh.net>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, llvm@lists.linux.dev,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: [PATCH v2 13/16] selftests: vDSO: parse_vdso: Test __SIZEOF_LONG__ instead of ULONG_MAX
Date: Wed, 26 Feb 2025 12:44:52 +0100 [thread overview]
Message-ID: <20250226-parse_vdso-nolibc-v2-13-28e14e031ed8@linutronix.de> (raw)
In-Reply-To: <20250226-parse_vdso-nolibc-v2-0-28e14e031ed8@linutronix.de>
According to limits.h(2) ULONG_MAX is only guaranteed to expand to an
expression, not a symbolic constant which can be evaluated by the
preprocessor.
Specifically the definition of ULONG_MAX from nolibc can no be evaluated
by the preprocessor. To provide compatibility with nolibc, check with
__SIZEOF_LONG__ instead, with is provided directly by the preprocessor
and therefore always a symbolic constant.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
---
tools/testing/selftests/vDSO/parse_vdso.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/vDSO/parse_vdso.c b/tools/testing/selftests/vDSO/parse_vdso.c
index 200c534cc70e2c2381fce3be5c0ebe4cb5675e84..902b8f9984a1f70049d46bcd4f199df24f507dcb 100644
--- a/tools/testing/selftests/vDSO/parse_vdso.c
+++ b/tools/testing/selftests/vDSO/parse_vdso.c
@@ -26,7 +26,7 @@
/* And here's the code. */
#ifndef ELF_BITS
-# if ULONG_MAX > 0xffffffffUL
+# if __SIZEOF_LONG__ >= 8
# define ELF_BITS 64
# else
# define ELF_BITS 32
--
2.48.1
next prev parent reply other threads:[~2025-02-26 11:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 11:44 [PATCH v2 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc Thomas Weißschuh
2025-02-26 11:44 ` [PATCH v2 01/16] MAINTAINERS: Add vDSO selftests Thomas Weißschuh
2025-02-28 12:22 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 02/16] elf, uapi: Add definition for STN_UNDEF Thomas Weißschuh
2025-02-28 12:23 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 03/16] elf, uapi: Add definition for DT_GNU_HASH Thomas Weißschuh
2025-02-28 12:23 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 04/16] elf, uapi: Add definitions for VER_FLG_BASE and VER_FLG_WEAK Thomas Weißschuh
2025-02-28 12:24 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 05/16] elf, uapi: Add type ElfXX_Versym Thomas Weißschuh
2025-02-28 12:24 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 06/16] elf, uapi: Add types ElfXX_Verdef and ElfXX_Veraux Thomas Weißschuh
2025-02-28 12:25 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 07/16] tools/include: Add uapi/linux/elf.h Thomas Weißschuh
2025-02-28 12:25 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 08/16] selftests: Add headers target Thomas Weißschuh
2025-02-28 12:26 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 09/16] tools/nolibc: add limits.h shim header Thomas Weißschuh
2025-02-28 12:27 ` Vincenzo Frascino
2025-03-01 11:30 ` Willy Tarreau
2025-02-26 11:44 ` [PATCH v2 10/16] selftests: vDSO: vdso_standalone_test_x86: Use vdso_init_form_sysinfo_ehdr Thomas Weißschuh
2025-02-28 12:28 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 11/16] selftests: vDSO: parse_vdso: Drop vdso_init_from_auxv() Thomas Weißschuh
2025-02-28 12:28 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 12/16] selftests: vDSO: parse_vdso: Use UAPI headers instead of libc headers Thomas Weißschuh
2025-02-28 12:29 ` Vincenzo Frascino
2025-03-20 13:23 ` Mark Brown
2025-03-26 13:02 ` Mark Brown
2025-03-28 23:08 ` Shuah Khan
2025-03-31 11:56 ` Mark Brown
2025-04-04 13:03 ` Mark Brown
2025-02-26 11:44 ` Thomas Weißschuh [this message]
2025-02-28 12:29 ` [PATCH v2 13/16] selftests: vDSO: parse_vdso: Test __SIZEOF_LONG__ instead of ULONG_MAX Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 14/16] selftests: vDSO: vdso_test_gettimeofday: Clean up includes Thomas Weißschuh
2025-02-28 12:29 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 15/16] selftests: vDSO: vdso_test_gettimeofday: Make compatible with nolibc Thomas Weißschuh
2025-02-28 12:30 ` Vincenzo Frascino
2025-02-26 11:44 ` [PATCH v2 16/16] selftests: vDSO: vdso_standalone_test_x86: Switch to nolibc Thomas Weißschuh
2025-02-28 12:31 ` Vincenzo Frascino
2025-02-26 21:18 ` [PATCH v2 00/16] selftests: vDSO: parse_vdso: Make compatible with nolibc Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226-parse_vdso-nolibc-v2-13-28e14e031ed8@linutronix.de \
--to=thomas.weissschuh@linutronix.de \
--cc=Jason@zx2c4.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ebiederm@xmission.com \
--cc=justinstitt@google.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@weissschuh.net \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).