From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC056C18E7C for ; Wed, 26 Feb 2025 16:27:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 577666B0085; Wed, 26 Feb 2025 11:27:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5275E6B0088; Wed, 26 Feb 2025 11:27:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C8976B0089; Wed, 26 Feb 2025 11:27:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1E2C06B0085 for ; Wed, 26 Feb 2025 11:27:05 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9381E1CBA76 for ; Wed, 26 Feb 2025 16:27:04 +0000 (UTC) X-FDA: 83162625168.09.C225978 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id E53D514000E for ; Wed, 26 Feb 2025 16:27:01 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=faek9iJz; spf=pass (imf09.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740587222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ppomcWQSOcgvzeEl160zR2jOyW8ovhKpqyTRKDX1OIo=; b=4WBSN9SIFehjiBzOnvBqlwY0/yjtmmdc6v2RCNRhmzHCMd1V3X2NBw0P7nVy1eILDPWq1K GYTrU6d3ecK9RYua3JYY35WuhXKP8WJ8inBwFQgnRJ+W6wWs2bUpwVlAvyyfg1H/1yPlrB Em/r9BpKfrK2jxWYjRsnzzfx3I303Mg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=faek9iJz; spf=pass (imf09.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740587222; a=rsa-sha256; cv=none; b=1Ry7OJFfYShaHiOx0iU9tReYShDmi6LPN/wXTuJek523Sp8/oZPsoNSR5x5F+3LZE3GY8U ljNKVXSsZb4jdMhXF2u4UxSeFg7z2WN3Kh/0Rbx3k9jz8evyocvWvzmiJC+vw66+pzMvdJ WNcd3goz0ZzHoXTTBu7LAA9wLKVadJY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740587220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ppomcWQSOcgvzeEl160zR2jOyW8ovhKpqyTRKDX1OIo=; b=faek9iJzMESdUP1a4w0RxdG41Iqd+eZIKkpU0OUNyODaVrVTuBznt0dGmgkNHQyWtq2mGh kC4w4ixWGaW25sdGh8AJ3dFLzTU6Ba/tyQlbq5l1R3EAkQc3S7jBwjZbEQQCBgQBxuOSen 5qgu7mfqtQxmjkRNSs0QgBnOOzZURQ4= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-LPGgYWgyOTyPOxcZJ_DLYw-1; Wed, 26 Feb 2025 11:26:58 -0500 X-MC-Unique: LPGgYWgyOTyPOxcZJ_DLYw-1 X-Mimecast-MFC-AGG-ID: LPGgYWgyOTyPOxcZJ_DLYw_1740587214 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 436A51800998; Wed, 26 Feb 2025 16:26:52 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.226.247]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 8BD4D3000199; Wed, 26 Feb 2025 16:26:35 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 26 Feb 2025 17:26:22 +0100 (CET) Date: Wed, 26 Feb 2025 17:26:04 +0100 From: Oleg Nesterov To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@Oracle.com, adhemerval.zanella@linaro.org, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Subject: Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping Message-ID: <20250226162604.GA17833@redhat.com> References: <20250224225246.3712295-1-jeffxu@google.com> <20250224225246.3712295-7-jeffxu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250224225246.3712295-7-jeffxu@google.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E53D514000E X-Stat-Signature: f7r3t139tm7jj1dr9s61qi5fsy13qbjh X-HE-Tag: 1740587221-950357 X-HE-Meta: U2FsdGVkX18p6p4eVmWK9V/xg/tOlGYeyJnRVbw+pzK4cMKlar9agBnooMmqSi/K1Du2lvhbsDSAlTajA+8kdPosQ9PgPVYDYCa4gqxKa9T7WiwtCbjCuzzX0F2gBeuzfhqIJ8kmQ6zWaUokhewJWpFQ0ID6AYxZLyatQ2MQHPgpgyfI2gWvPAvq57s6rtzij4MvKGk0/vcCUWpbuAzIoKV3ykt9DZjCPgUzHLQ8zuHmsa66IM8FenA0ETnVW5bfRP0owLSHYu05LMQKn4z6qRiUq9ClnID9JxFJXW2UpJzoIHIbtzG6lfdX4AoGThE++Q35b35mMwVhf8W7wLs7civDXk0NtPd1oQocYsoQOlNzxMjaFRWK0UBzaP2Yn1KIk+egkZ1Uo87Cw00RAJTYc/F7/1GjfMBnkSwghiJjgUn3YC33qSpRtCD7sHmsEfSq+BjQhA1Dqn2OOVGwEahVUDPB41EXfh/7LPXPbuV3bur3/PfpqtO7HIRLMzqnUh39w041tdRz3ZDV6iUI5wIsVQ6O/YidgWZ3Ry1VnFBpQUBTFU11iY3IGVhldGFoXIlxb3knix3/liF31yXujd7W8SU67h/APTg4xHiO6wZ9SGhVqQjtcVDzbCHkMrCGZrey7OdiN4uHlBTUh0B7oTMusfVdxkzf9rrP4s9vhjJ3rxdgsXXEtwA9FDaSUDJiKn45LUcsLYSyREfTkvsZK48sM2H6+F45Noedv4hwOtJLsrRPSzrazgWXLCtvgQfaPSdKMokluugJGa7hEa8rn6jgWW0cXCCwb7Tn63Ga2UGjgze+LN6oqqV9VRTyVy6l8YwFFDDECDseCeVlkeFxUQKa7K3pIjigPKd7n+tfCb1u6dd8LgU6fWrBAvRoizpfdHrK5+SiRuX1UgUqgM00bIkRGcznPpI+wF9S0souUwJl6qDGl+Ps1T364wCjLpiX97xU3iaabbLr6EXIL/BzZY9 bi52Bfxt 2wUvJ+8xrleQg5nUmOzzIu6X/BjQ1LZJZ52T7OhPtfzV/8bzD/MVasrgkGelkVKGNZF7KCMWJ4PY9FntndyQDFNJQzS5fRrgAH0vrSXMeXh8VeaTzwn2mfebn2j4k54ook3xpK8df9sadIwonNxSy4LsSntcYJrGbSAv4umL04T2CrEwQOlLUijwcZ20BpJp2DolhnHe08VXAIpn4nlOA0SAQ5vbuKn2f/0UP1oDTlfzBDtvFjuhZ0aBixCSO1Ovbkh/U9YC/vIg2yCZutPNrscQEaxIol0mRYz2sDmqFVdk3T+JlJQL5kN4xXlDxsLvyswvEH8QIxhB9L2V9+adX1mG0FGXsPeDCMuXY7CN1fD10Hxp1350dTb3DMSAkeVPVuvTCRGInbK6Gt0T0lIFOxCqu+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02/24, jeffxu@chromium.org wrote: > > Unlike other system mappings, the uprobe mapping is not > established during program startup. However, its lifetime is the same > as the process's lifetime. It could be sealed from creation. Agreed, VM_SEALED should be always for the "[uprobes]" vma, regardless of config options. ACK, but can't we do #ifdef CONFIG_64BIT /* VM is sealed, in vm_flags */ #define VM_SEALED _BITUL(63) + #else + #define VM_SEALED 0 #endif and then simply vma = _install_special_mapping(mm, area->vaddr, PAGE_SIZE, - VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO, + VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED, ? But I am fine either way, feel free to ignore. Oleg.