From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6662C28B2F for ; Fri, 14 Mar 2025 12:25:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84DB6280002; Fri, 14 Mar 2025 08:25:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D694280001; Fri, 14 Mar 2025 08:25:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677C3280002; Fri, 14 Mar 2025 08:25:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 46F2E280001 for ; Fri, 14 Mar 2025 08:25:43 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3A542C0F75 for ; Fri, 14 Mar 2025 12:25:44 +0000 (UTC) X-FDA: 83220077808.07.8565BA5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 733DEA000D for ; Fri, 14 Mar 2025 12:25:42 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of "SRS0=6XU/=WB=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=6XU/=WB=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741955142; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Wzk8mbpfBFBH1YQcP6jKoNkdrb3/e0YZqRAzSvI8Bo=; b=wYAp3aFjIiNqCotNaDPsEKVtFin0oK4I7FlFGS43CqacYCO301v3/E0NVwhzDmHw8oV5qS wKo/loAQd7lahbnQ3jCIy6Y7u09sPBWnlYDxXRrf6p7l5siyZ84EEckCwFJ9X2ncZnHs6l nOcEOWi1RF8RSgC1G5f0POIBDr4STQU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741955142; a=rsa-sha256; cv=none; b=sMOkbDuFBfFw4Pmb4EY13vHP1FYPWqjHjkFdGUzKJREXFU2X01MMirOAf9MpakqcMyfNhr 7LP7ACrAwcHBdV4D7enPWU5+AcaeSyd+LYGBXCRqaFuAaOGyAuwQ6jF+8dvVlkh5JH1rjd lmiueWD3rrMjH/3Ff7zi60WokJSpsno= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of "SRS0=6XU/=WB=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=6XU/=WB=goodmis.org=rostedt@kernel.org" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8329F5C572D; Fri, 14 Mar 2025 12:23:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 215A4C4CEE3; Fri, 14 Mar 2025 12:25:37 +0000 (UTC) Date: Fri, 14 Mar 2025 08:25:34 -0400 From: Steven Rostedt To: Petr Mladek Cc: LKML , Linux Trace Kernel , linux-mm@kvack.org, Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton , Michael Petlan , Veronika Molnarova , Suren Baghdasaryan , Rasmus Villemoes , Andy Shevchenko , Tamir Duberstein , Linus Torvalds Subject: Re: [RESEND][PATCH] tracing: gfp: Remove duplication of recording GFP flags Message-ID: <20250314082534.57ef07c4@batman.local.home> In-Reply-To: <20250313125313.4f3d98f4@batman.local.home> References: <20250225135611.1942b65c@gandalf.local.home> <20250313125313.4f3d98f4@batman.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 733DEA000D X-Stat-Signature: eoecaematsikzpfjhea3kagzib9ah7bq X-HE-Tag: 1741955142-892121 X-HE-Meta: U2FsdGVkX1/TI8XFctc5ZvAtbi9TzqeZQXF5248wEsN4PVtlWLB//9mIQYh/POQbBnE4TMipGEN4ztBTsIePw/w6d73scteQgLhsskiZvd54uPSGyVVT4bBy66ihaW6zTmuqB27oCqjenZlfj5xbvIk35w+CgPuUWHLOPsEpIxV3qnoN7mypExIm6/NyIJm777vQ1nw5pEO0Ewwv2EZvYzdMG/W/aqffCo9bUfQrJtr+gaP7Gkfc3mPpZ6Y46pCSfcGze2tgdCwz6D/mDO22cz0CHG5urx51iTbKGavPLZjs7m5kCkR6FqKBDkdAxBDJLNA3BL5lRu1RBQqBrVuDiE06BhOrTnhr1+fj2so0xcNEwG23ODlr1tkqfmrdOFJI9htQlaoLjBlFBkmyjGIf4rZO33kUywif2uxmutC7J1mTw+BDnEik0naHfB+hc1RmSnXj0uJHnwx7WFdQ1WLFdBJyN1RnDx19EZ9lhlTA37smsYeXsuo2PCmzh7QUPiN1WqheWCRNmS9tizRKf2ZXhggNkKfzuiGQq93l7SWErYy/UCcTQ65SgXGgVqqd72S+jY948B8uqRAXRqLLswyAwkt4LE2If7RJl/7y/+unz1Feq+N183lJLfEVhrPu6tZ6UlLE6eO282sEZhFRIEPjtqBJQzxIeQ4EVu6IYCMcnrR4iM/N7tjkalty8xxvHcRQ08gKGY0kxR1NEg7C4SF1YPdDLGjzOlfsnqLCrp+iQFtkxAo+hsy6IdWBWFNdkqiatGqr/xIxGFmI9sHq5m8wDI7qec7S5szaB0ylKFTyGUfCJXEYAsyB4zrt60ATR6RkCPYXMI8p9Xspwdg6TjEbvP8hdCQ2wv/3Tf3t8ibZW3sapMEffiAiJG4eZHx194wVr+XT3EgbRGesVbbStVHgGlHHo7v46ydnj/Jp4KOXvh/yoCUL6dlXyK0phhXmlAHOyUQbytKeTHPzajp6QjD IwsQ+rf3 a2s0WgAGb5TfTgs6phy7X1C1AuiJDqHqLNb1BEQBAPjZnkHk2SL5rS0aree1BqtZDwXAFHPCRg+Af1AneWLKpQLFeXMzJ/Kcidu65aAfEQb/1J0lV76FYuASGABA4/fsk7LyPNHS8e9yMRojvtaMz2oCiIlsmrBFdsGwvuxBxTNsKfFC3mDYJBYQktwaDYcgydSW/uk5LiiWdiKNu5cgZe8WEEnD3nhfdMRjb+kJ547FZpLr3kg86BPmkcvNEX68mPSp0uTjt4uC7+vvFpXUcKZ6lR+l0Ns2P/wPrwe0iPR9L2zOe+XeQHkQTmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 13 Mar 2025 12:53:13 -0400 Steven Rostedt wrote: > > --- a/include/trace/events/mmflags.h > > +++ b/include/trace/events/mmflags.h > > @@ -101,7 +101,7 @@ TRACE_DEFINE_ENUM(___GFP_LAST_BIT); > > gfpflag_string(GFP_DMA32), \ > > gfpflag_string(__GFP_RECLAIM), \ > > TRACE_GFP_FLAGS \ > > - { 0, "none" } > > + { 0, NULL } > > > > #define show_gfp_flags(flags) \ > > (flags) ? __print_flags(flags, "|", __def_gfpflag_names \ > > > > It seems to be safe because the callers end up the cycle when .name == NULL. > > > > I think that it actually allows to remove similar trailing {} but I am not sure > > if we want it. > > Hmm, I could get rid of that last one with this patch. What do you think? OK, I think this is too hacky, and it only affects tracing if there's a flag not defined (which never happened so I didn't see this issue). I'll just go with your approach. You want to send a formal patch? -- Steve