From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB06C282EC for ; Fri, 14 Mar 2025 21:06:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1C29280009; Fri, 14 Mar 2025 17:06:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCB73280004; Fri, 14 Mar 2025 17:06:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C949B280009; Fri, 14 Mar 2025 17:06:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A9325280004 for ; Fri, 14 Mar 2025 17:06:05 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B060B80DA7 for ; Fri, 14 Mar 2025 21:06:06 +0000 (UTC) X-FDA: 83221389132.04.890F954 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) by imf02.hostedemail.com (Postfix) with ESMTP id 7350D80006 for ; Fri, 14 Mar 2025 21:06:04 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=wUUVxcj0; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741986364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wouJWyoqE8ZpbRdKYnwSI+aPBYLXbj4bary9x6Givhk=; b=KghUW7V4fj1cB8fJgw5odN9eBbvXA/BhVgKL+5QNw0pZ1jKHR5CPE+7jXLpSlHcHU2VTWo GXXfuXB+LVRshmq/3q/16je0uXgLl3Tij4HnrDbxsvKsZ8DQIb6NAY2zbmjC47TmVXb6Gp SWz5TZMxqXBPt0cfhd+zym7r7r8iaH8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741986364; a=rsa-sha256; cv=none; b=pbavOBnugqecHPxSkvlhQG7cuzqETNaH3f5YvSmYw5wcq8DgelseCXHYUL3GRbyVZN8MtH gYjh3nAWdCOv09yFpzovIQPHZ1833I0eEERtiPPxInc0YRwtb3B8npyAEftkXzqWgYizVp gHCzUy4UCMhg+oJgS9n1+NdQSBIgaTc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=wUUVxcj0; spf=pass (imf02.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.176 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7c5675dec99so296426785a.0 for ; Fri, 14 Mar 2025 14:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1741986363; x=1742591163; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wouJWyoqE8ZpbRdKYnwSI+aPBYLXbj4bary9x6Givhk=; b=wUUVxcj01FupVPzmNQL9KzMkqnpKcDLp3D/qQp84D8ZOawVooLY9CCTxiwxyW1Vqo4 oL0n19YKs9o8nCxMBE4igUMQwm1AsyIXElKSTgn01qXQhqyjrpj2lI0zB953bRMCEO2l L31DtxK95n+OcZNfpbUqdEUr3VGonZ90ESAvCvkg+154kZgyoo9/daGkkckcXRThV9xv wuSy3/PG73Fz1d0ixocXi/j37HxghjS894qrEcjeqO+DWIxfBZwBYKTBx8cCcFLGjklk XBTXM8S5iea1LVLNQH7B3q9oI4lYaybJgrWepgSeK1IejwwZjDHJuFeiNMF5o1WLwm/j C2yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741986363; x=1742591163; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wouJWyoqE8ZpbRdKYnwSI+aPBYLXbj4bary9x6Givhk=; b=CqZoz3Wf3yMEdVuavmYXHTtfghzTujSXl3Nr17D8WmaikZQAAnU9lHwy7CKkdNSCjZ dki1XVwK+3VAGOAYKEGNjIv2yCkaM5DwtM5gn2WkwmgT7US7fyUwxOeSzN9tbkpwor6q kHYhnh6JyhZFejFPE4TlA433+BlzkgqE8F9WCfZQvo8mveGvC7/ndrUzl3Q0bubtRILt US1UqkpOIGqKOSlrZv7DhX4hdn9rY9UthyG33Ni/BQ8EAwsaoMgQlpxzBohzYlQMbo+T +mMWGaS7p6iKhWMA0jVlPEWBu582d4evumnfO/OTVH5sA4C++wTH5D2ixBgWJp4Pr7mX Mvdg== X-Forwarded-Encrypted: i=1; AJvYcCUv/Dksdmbow3grJnC8EzA4uj+PcArvNqhcamu93rwnjh+yLDjliPzYIvY4OOw9c2VcZ3szti9gBg==@kvack.org X-Gm-Message-State: AOJu0Ywl7wv8B+a0zofA762hKL9f8QOxUqEtqzFrO/ZXLrkVkWmBlgrp 4a9atoLKIII7yF3xyGWfLNbJRfctKxY1Nzb6oAlHRhsY+JofXP/y7a4BTIIw2dE= X-Gm-Gg: ASbGncs3/q8FzQeI5CfMessO8KKosR/u6eS8i2JH8Y0wBSqpUCS7iYqET2a+2+jYzkK 4lTzd9a71PpqKdHMUy0qnETG2UHn7iZTt4eTMvqJ5/NA73JgQjsKqZPYzqDqMNt1hitNSgmEO49 sVIMlTGap6IG7aHSc2UDC/BeG1wYdTBZJc46hvkgFdf5O1lCrFqZmDacK76+vxfbtEVVcIAlaM9 RnEPs8drvJXPzu0gwpSkFow93csEiqr98TBZJezUSvnfAdey1j/x9qyhgaSRfXvnf77xA/6CxUf hg/36qeYBEUB28/stUoOmR37UOTxNnwy0PDgILxhg+M= X-Google-Smtp-Source: AGHT+IHzAK5TurTbeJNlYYY/Gy5+4Uau1jNFIkO8qge0TCNONcogZCW2HlHi8miPmY46e06XC0SziQ== X-Received: by 2002:a05:620a:8003:b0:7c5:4eee:5405 with SMTP id af79cd13be357-7c57c8fc474mr560621285a.35.1741986363439; Fri, 14 Mar 2025 14:06:03 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with UTF8SMTPSA id af79cd13be357-7c573d9256asm296990185a.106.2025.03.14.14.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 14:06:02 -0700 (PDT) Date: Fri, 14 Mar 2025 17:05:58 -0400 From: Johannes Weiner To: Andrew Morton Cc: Vlastimil Babka , Mel Gorman , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] mm: page_alloc: defrag_mode kswapd/kcompactd watermarks Message-ID: <20250314210558.GD1316033@cmpxchg.org> References: <20250313210647.1314586-1-hannes@cmpxchg.org> <20250313210647.1314586-6-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250313210647.1314586-6-hannes@cmpxchg.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7350D80006 X-Stat-Signature: 9zip91uiwf3eq3r9o3wqpkdt4hjzbix6 X-HE-Tag: 1741986364-4371 X-HE-Meta: U2FsdGVkX18fel/8lHf+5KgoKVLHCyD/78I4GMHnd6qrxDSMpdWOhmbTt7rLMFv98QSlcFnz8N+W+jg4d8sKrADHT5VtCHnBgIBjVasRsypolWRXPRddgw3a0X1vy15DDXAZ0PcoxwXS6qFRP7p/fwC9YMxLNIrNf6NW1SgpOC1bxSeqkw4a0Hcs7oJo4iprDFnXBFipTS/Dv1A4rsGv34d3F9K+yTA8tyhSbi10Ca4tD8rwjMmG/Te+36lkRpsxMSnn0XxhpB+kLAl/ZBm7HgUN0FfuVT4pJ105RehhXqdCXzG/CNmaEzvHNooeMSWHkYQ7Iv57HNZuqbUU3sqV2iv/hvdmrGCB/hlXI65xWy/BhctH5aRCgJw5MiIA9bfcNYezTPs8/Jth8G6mTOU4ebZLdUxPFuvDupGFOzopR86IVRL8jlSNtwkoaHoHEt7NlJJL9Bs8S3tYtUnEXeaZqFSrZ6mhY5aNyr1tI2MgCe259wmwv34goBP/+TAVsR1HwzJ/MNPEQ2jbq8FmSlLtyNyHrvsKWGCeJtl8zrGDvhVHYhP6bnxeLQwyFTOEUJto6QOz/PDtveHu9orM4ahix4irsixOfXPb/wfQ9ZQqRQ78itD/1r4qKNgWnrjPcSrw0R2RcNemFs+6EYvSF0n9MGDBkVAfN4SAFKE/rrHK778L69ylkZu8ieLK9kYpIDALYPFQzdM5cgs2HLQXYfoA1tB5Zk+9nV+oG0etIYZcKcI9ypizPKc2tSql6EHhud+DzWSISRdF3aJfSx3Sy9wsJq6jlXRG7gZeq+vWPhX3tDNMdDPIFcvODaN3RRNQwWQ2uH04xQWKAJUtf6Z8+dkXwpeBirN0cKcA5lPf+A1Fb/vtak441ewll52M3l+1RgSZdwkEYnvPALS0DFZ6XqFPZCk58OkeDsM9f1mxhA+998SKzYXZzWad7xw1IIsMwU4319mkRsS1MFbgH9P8d/n trprHUMX wYtNR1GeBnoixrzfxp+eaLagzfnYhcJmhKNFBwD1/XwCGWM+8PJCv9AxIc+px2IzGfn8PMHsnsKrNdnsUu2muguxzCKaVB1KDBUM553QkqYradvZCtlcy4D5wXkhyWVuW7kGMVa1N6fosW7hbviqI4MhPbeLZ2gwK+qAvH25M99qM4Aga/KAQnvm09XD4JcAuhEi96oAfvf7l1QzOdXigr5F1u2XK4jzEB7j/BDsIW76oRYfLVTpBoU0J9Lji+2CiOs2KaJlKMMA4XWB/hopx9+tyUXznMdF9TNHpr51fmK8UcJKRSsnDgaO5xonmaEvL59GTGad1C9RAupYJbkXXsCh0NbwyNjzeEt6G3IY/C1SZOfkySbKBLwOwvd/xq8n4KjU0jOLb8s71chfkuIks2utZYBqUf5xIwCZcF4NL0erx27qJqqSSGllvzuiDLFLF98dejFEx6jRRFgc1QwMqaQGfPlEwHiy94YnOGUti4Uox5xNmQbH2Mvymo7vg7UtZOfLVZCPsdqN4o7R9i5WjunQejg7GMxMBsUpbhNDp03tNjR3+JSFykn6dtkkYUOHPrZ2T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Andrew, could you please fold this delta patch? --- >From 3d2ff7b72df9e4f1a31b3cff2ae6a4584c06bdca Mon Sep 17 00:00:00 2001 From: Johannes Weiner Date: Fri, 14 Mar 2025 11:38:41 -0400 Subject: [PATCH] mm: page_alloc: defrag_mode kswapd/kcompactd watermarks fix Fix squawks from rebasing that affect the behavior of !defrag_mode. FWIW, it seems to actually have slightly helped the vanilla kernel in the benchmark. But the point was to not change the default behavior: VANILLA WMARKFIX-VANILLA Hugealloc Time mean 52739.45 ( +0.00%) 62758.21 ( +19.00%) Hugealloc Time stddev 56541.26 ( +0.00%) 76253.41 ( +34.86%) Kbuild Real time 197.47 ( +0.00%) 197.25 ( -0.11%) Kbuild User time 1240.49 ( +0.00%) 1241.33 ( +0.07%) Kbuild System time 70.08 ( +0.00%) 71.00 ( +1.28%) THP fault alloc 46727.07 ( +0.00%) 41492.73 ( -11.20%) THP fault fallback 21910.60 ( +0.00%) 27146.53 ( +23.90%) Direct compact fail 195.80 ( +0.00%) 260.93 ( +33.10%) Direct compact success 7.93 ( +0.00%) 6.67 ( -14.18%) Direct compact success rate % 3.51 ( +0.00%) 2.76 ( -16.78%) Compact daemon scanned migrate 3369601.27 ( +0.00%) 3827734.27 ( +13.60%) Compact daemon scanned free 5075474.47 ( +0.00%) 5910839.73 ( +16.46%) Compact direct scanned migrate 161787.27 ( +0.00%) 168271.13 ( +4.01%) Compact direct scanned free 163467.53 ( +0.00%) 222558.33 ( +36.15%) Compact total migrate scanned 3531388.53 ( +0.00%) 3996005.40 ( +13.16%) Compact total free scanned 5238942.00 ( +0.00%) 6133398.07 ( +17.07%) Alloc stall 2371.07 ( +0.00%) 2478.00 ( +4.51%) Pages kswapd scanned 2160926.73 ( +0.00%) 1726204.67 ( -20.12%) Pages kswapd reclaimed 533191.07 ( +0.00%) 537963.73 ( +0.90%) Pages direct scanned 400450.33 ( +0.00%) 450004.87 ( +12.37%) Pages direct reclaimed 94441.73 ( +0.00%) 99193.07 ( +5.03%) Pages total scanned 2561377.07 ( +0.00%) 2176209.53 ( -15.04%) Pages total reclaimed 627632.80 ( +0.00%) 637156.80 ( +1.52%) Swap out 47959.53 ( +0.00%) 45186.20 ( -5.78%) Swap in 7276.00 ( +0.00%) 7109.40 ( -2.29%) File refaults 138043.00 ( +0.00%) 145238.73 ( +5.21%) Signed-off-by: Johannes Weiner --- mm/compaction.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 4a2ccb82d0b2..a481755791a9 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -3075,6 +3075,8 @@ static bool kcompactd_node_suitable(pg_data_t *pgdat) struct zone *zone; enum zone_type highest_zoneidx = pgdat->kcompactd_highest_zoneidx; enum compact_result ret; + unsigned int alloc_flags = defrag_mode ? + ALLOC_WMARK_HIGH : ALLOC_WMARK_MIN; for (zoneid = 0; zoneid <= highest_zoneidx; zoneid++) { zone = &pgdat->node_zones[zoneid]; @@ -3084,7 +3086,7 @@ static bool kcompactd_node_suitable(pg_data_t *pgdat) ret = compaction_suit_allocation_order(zone, pgdat->kcompactd_max_order, - highest_zoneidx, ALLOC_WMARK_MIN, + highest_zoneidx, alloc_flags, false, true); if (ret == COMPACT_CONTINUE) return true; @@ -3108,7 +3110,7 @@ static void kcompactd_do_work(pg_data_t *pgdat) .mode = MIGRATE_SYNC_LIGHT, .ignore_skip_hint = false, .gfp_mask = GFP_KERNEL, - .alloc_flags = ALLOC_WMARK_HIGH, + .alloc_flags = defrag_mode ? ALLOC_WMARK_HIGH : ALLOC_WMARK_MIN, }; enum compact_result ret; -- 2.48.1