From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2863CC36010 for ; Tue, 1 Apr 2025 19:01:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AD97280002; Tue, 1 Apr 2025 15:01:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 733BA280001; Tue, 1 Apr 2025 15:01:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F952280002; Tue, 1 Apr 2025 15:01:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 40D22280001 for ; Tue, 1 Apr 2025 15:01:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 503D61C9383 for ; Tue, 1 Apr 2025 19:01:50 +0000 (UTC) X-FDA: 83286394380.08.C803B78 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 7B8B54000D for ; Tue, 1 Apr 2025 19:01:48 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vWXGk2nz; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743534108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uR8eFRFyFZz8tEbA5RDQiH+sfUJ0BZEbqGbe50H8XeY=; b=FxO/dm7maFCdDybBVtl5Q8RMp9xO4BAfk+1kIGcQKg6NPPHdZk0YAgMR751TYls5zFoWe9 SRKQob6pACFTChmxZ0uaWax2tDQgd5x33qnWU+QAqC1+Liw7OyO/mxfpv09aT5pbXPnvEP B1tMLEBrN3zb5kBBfHOqtIRPde1Pd8c= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vWXGk2nz; spf=pass (imf07.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743534108; a=rsa-sha256; cv=none; b=Agot2DA4+gwRGKj0SgG5QxgbSgoC55ssAugQTYO7eHAfg06tlRHLYKqhdGsct0UToHWtwI cFWvfK/bAqV7nXERY9IFiO7WlIf/RtABRLWsz7b4s5C99Kf8gVWS24bJq4iM+c/ZN/Riis bcg5DTqOf9ZVKhmtSbn2Y8SkJFHyxYE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id CB675A409BD; Tue, 1 Apr 2025 18:56:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 084FFC4CEE5; Tue, 1 Apr 2025 19:01:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1743534107; bh=K8GGUKRabMKEZ6JIjw4NI8sc8Kkbl/+8n/DuS+E9OEI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vWXGk2nzNovEl3MYhCqn6avIVAfboZsR0yYlEP5JK2SfnqDJTtMp/lbJYKpQbLLmK VoLLhkulpjZ4HJfy5nvs5374iZZwqX1MFHGp/tv1Mtk45WlYO0yap0iK/zz9RD8XRG Nz5B16yXQeISba3TU8bMJx3JVMZsxxeSBHKXBrXA= Date: Tue, 1 Apr 2025 12:01:46 -0700 From: Andrew Morton To: Nhat Pham Cc: hannes@cmpxchg.org, yosryahmed@google.com, yosry.ahmed@linux.dev, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] page_io: return proper error codes for swap_read_folio_zeromap() Message-Id: <20250401120146.8d3533b39968df5e0712acb3@linux-foundation.org> In-Reply-To: References: <20250306230015.1456794-1-nphamcs@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7B8B54000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zj8c3w4hjcsxj898355wbo1bbx81ab5f X-HE-Tag: 1743534108-647575 X-HE-Meta: U2FsdGVkX1/Q7Ji+D4PMY3dF6vo5NfhoPb1Iqojyxwv3ppy4OEUPz4YOmfsONrad1w1/aMdi0I7OyWbRDFqltgIC5CGnMBOLZ7d+Wmf5rB3DWt4iFNUClYZl4xTcN+t7wQeercGieqN0xEJRgumoClIb+BlucdqfvUZfpxVSpujmVTedf708Fb03wecMZhx5R+tqeriw07nCky7DFd3XzF5kzkJJtsZXSZhJW6NdN0Exa3Q0vQKKqY4KGniMrsEsTMI9/DHy2czQvP7Q7doHpIL9BF+HD2Yr+gIr1Nj81A/sU0TQgDxltK3YgfW++Z6pXKU56isagJZfI7cxyOy/x4SpYPTc4SHRf2o2lquK2/uOPwGCK2HUm73xX1fPTblkiGMDnSn7edfavyyqnhH7TDo8TZiGOQnTtIeXf01f4IXRcHD6sqBevKhTlOgN3UsP9q4tj4FR9yqIDRmcDJAJHjV//6vuM4oUmcO88r7qZLEvzS4IZiIV//9G+wRsYFy6BijTfCZw05qKxmzqC0yXPaK/xYeCcNCcMJOjBBA+fPxiy67uiIvJtXRu3j5lqJYUzbFRhp8HkgTXTXb9hK7Q236dxdjIcM3L/GBpTlJnjOyfwiFDuA/LSuzkN2Rtf0ZRKVRl+DAD39/xaVwkxhxLN963bsuqSLg7ubmA8Pxl7SWCNm2kFr6Ps27KHqhuL2O3gTVMrbMx/xKtFADzOFwTWBqyEQ3AwymZyArHonjSgFiCr0Y6jncNPleiPBCSgK2UTSnC7akTrlfvH/rEDvaDhEtBul+ZlI5mvt0OlwUIPwv64b5/Ugu2vbkcTJoP9Vi07Beov2dXcofK4lxBmp4GKs3GYsR2CpAf5WiSP4UtbT8i4OjoUe33hPd9aR2l9n/12Zyb4paXP64kseC5HpzGTFAmXMxYTxq8/WXAQ+q9ntemquYJNKu5thDmD1blNU1xhXBzGEHC3Q0QUn4Up51 fujxjqAP RwmcsNeXeww2i0Bs695Vi3ObJBk+XM2ealxvSz1BIAPvPVA/DgX8ZO+Lu7ebnhk4d7Wvfw4z8cOyUkQemvpcOAffS6FW3G5U7FV1GbDKrbGSkL0il0xE3dQJaP5BzZg0eaSsVEYhYe9pmxLl1Y20hvti+xynGywKol6Ea9YPXYOLXUET/J850AcXo2seldVAB9qH1N/u8txf6rxHvKsA32GK8V5SIXHFmYjsT0aLTS86cuzkym4POhjZNPt+wGQXWWz/QCyE0H5klLxyEihJ2QcAeMjPfeB+n6lajGuzZZ7XSKY5bzQnEm8bELfzzdYZKky3qLG0bWWqgwvH8jODz87Ug7ZRUPIz+sdvM3ouF1KTuac4eboOJSBcHe9q+S9Tl71I2Q4JzeXtpRg3nKxM2yuSIvZ8B9auzLUeMhhy3+kd9FVI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 1 Apr 2025 11:55:31 -0700 Nhat Pham wrote: > On Thu, Mar 6, 2025 at 3:00 PM Nhat Pham wrote: > > > > Similar to zswap_load(), also return proper error codes for > > swap_read_folio_zeromap(): > > > > * 0 on success. The folio is unlocked and marked up-to-date. > > * -ENOENT, if the folio is entirely not zeromapped. > > * -EINVAL (with the follio unlocked but not marked to date), if the > > folio is partially zeromapped. This is not supported, and will SIGBUS > > the faulting process. > > > > This patch is purely a clean-up, and should not have any behavioral > > change. It is based on (and should be applied on top of) [1]. > > > > [1]: https://lore.kernel.org/linux-mm/20250306205011.784787-1-nphamcs@gmail.com/ > > > > Suggested-by: Yosry Ahmed > > Suggested-by: Johannes Weiner > > Signed-off-by: Nhat Pham > > Hi Andrew, I think Yosry and Johannes signed off on this patch (with > the fixlet). Looks like it was not merged for 6.15-rc1 - let me know > if there is something I need to do. Thanks, seems it fell through a crack. > It's mostly a clean up with no (intended) behavioral change, so no > rush of course. Yup, I'll toss it onto the after-merge-window pile.