Re: [PATCH] page_io: return proper error codes for swap_read_folio_zeromap()

Nhat Pham
2025-04-01T18:55:46Z

On Thu, Mar 6, 2025 at 3:00 PM Nhat Pham <nphamcs@gmail.com> wrote:
>
> Similar to zswap_load(), also return proper error codes for
> swap_read_folio_zeromap():
>
> * 0 on success. The folio is unlocked and marked up-to-date.
> * -ENOENT, if the folio is entirely not zeromapped.
> * -EINVAL (with the follio unlocked but not marked to date), if the
> folio is partially zeromapped. This is not supported, and will SIGBUS
> the faulting process.
>
> This patch is purely a clean-up, and should not have any behavioral
> change. It is based on (and should be applied on top of) [1].
>
> [1]: https://lore.kernel.org/linux-mm/20250306205011.784787-1-nphamcs@gmail.com/
>
> Suggested-by: Yosry Ahmed <yosry.ahmed@linux.dev>
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Nhat Pham <nphamcs@gmail.com>

Hi Andrew, I think Yosry and Johannes signed off on this patch (with
the fixlet). Looks like it was not merged for 6.15-rc1 - let me know
if there is something I need to do.

It's mostly a clean up with no (intended) behavioral change, so no
rush of course.