From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71B0C3601E for ; Fri, 4 Apr 2025 21:07:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E0346B0095; Fri, 4 Apr 2025 17:07:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 879F76B0096; Fri, 4 Apr 2025 17:07:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D0A56B0099; Fri, 4 Apr 2025 17:07:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 48C736B0095 for ; Fri, 4 Apr 2025 17:07:12 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8F3DB9811 for ; Fri, 4 Apr 2025 21:07:13 +0000 (UTC) X-FDA: 83297596746.29.E64DF0A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 2955F140005 for ; Fri, 4 Apr 2025 21:07:11 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tfe5O0hn; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743800832; a=rsa-sha256; cv=none; b=RLdepIEKTdzBBjPAeaQkLtLITSsHNV2gTQIjtbUwhKzrFAljAh9Ig3Q1xUK4Qiqhe2xH8B ITBtjpzpL0Sh9KFUAdTV0mKf6rue74z/lwW37S25HmKnR01kJzNF3EYvf997WSZK+sVF3W 3gfYCaf6CeIC8hxLi8gHxnxSPmWMCNY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tfe5O0hn; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743800832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=euXWFZsWtbqMUcYgP8fpgoYoMI4a4qO3i76QDzmrI2o=; b=56HqXv7rjR5xnqDqE74opReAEOjM+cMJX8tWbrN6eNcHDuiC1BBoihnqMPXuY4sc7ffwK5 of+JK0em8zdCaMn7mnJPSfDtP+NDjDaBCAom+UKBu/7gbOuOyirTQx6jYzFZW4W5iQF8Rn hDEZH8EVaAsn1V3iJ+FwiS27ydYw5gM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id BEBBCA468C0; Fri, 4 Apr 2025 21:01:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CF3BC4CEDD; Fri, 4 Apr 2025 21:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743800831; bh=PmO0QX64UlqAoz84TozSVHOKpk+4GGuBfZEHaifqBDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tfe5O0hnRe939EEJfRxDNGiQ2pY/sppUaKc+3ycE4PVz3K9kjCVQqNYTL2cUilCYI aOrXiWURyiVn/Su/0TO9rfP1GBglrQs9yjvvDxZxFQPWwtgiLTozL5CMbvStwljFzi 8AETsR/AgF2+QXn/dN3hkJP+Cjdr7wf77DY8hfk6iOcWfh5suzQ5VqVkMhZxbynnO5 zs0vUjCSXYyCbmTtu3R9xs1Eg4sVBkMnRhRAEJyY02L7Z3YkAF6i9HPOJr5tl6HVU5 sg0H9Y220WDutkwLm9uznN13Hk0Ei6e/kFjPaXS0LC/URd8bnydmoD1GLapOGrNtft L0meA5IVAPO3w== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , "Liam R.Howlett" , David Hildenbrand , Lorenzo Stoakes , Rik van Riel , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 4/4] mm/madvise: batch tlb flushes for MADV_DONTNEED[_LOCKED] Date: Fri, 4 Apr 2025 14:07:00 -0700 Message-Id: <20250404210700.2156-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250404210700.2156-1-sj@kernel.org> References: <20250404210700.2156-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2955F140005 X-Stat-Signature: gscz8wdauq5hz3u37g69tzrbwadeg9nr X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1743800831-851541 X-HE-Meta: U2FsdGVkX18EOOpzK1UNGDICxdXQmbk1Ld1ILzAPERUXUh5xHj1ua5w9OZJmWFvisgOL61kcd/67XmxpiGs5H95kAPF0t6IZaDi+/4wugFsIjCp2ePUxXJ49jDcy3tJoYC3pO3ImBcqrCwuVO4AR1iCM1qEHyj/tqSFo+d9s7yim4lRpS9zE1JiaWf27JVg1cJ3kuNxoYFK6JlqnAc6RuuGo4/AW5zud80g/3KcqB6XQZlKGyWcWxqJlz1BUeUuSOlk6S/2MoHg3EE777vliIA1k7vBqQD0mXmtqfHhtV6ZcwQlOV/n5YZ2n0PeW8vHUFhGLV7U5hwkWu3Y0MA7WPZRvztgYr032MoG/wEcXCyxxNa34fKYHma5bTSUtZ5vYn0KIEHEHtDtzNiz1FiOxero9fjvwneVxjdgX1INRaTGNpC8tZvaUYGgS9gXrVt5uTsXH4fmsRhk2L0lDELfjo+a0IKF/XhRJndd7gpQmcHgs7vJB+8eVsoyOWWImSB3BEvXpjTT0SBpwupOfMa0AwD2rccIepoONxP7/XSEnJAeUZsNHbGAe+tG71dZQHmxAOAIt9L3zLj6rraPgCSHaMc8cHHh1z7Ua36Z9pa2iX1ViYfXc/2Zd6Llcf5DYwLvKkNv2z8lb64F7j5+C0NZD76ciMoWSIp2zjPWSJPPlNGD97CR49pfgILFPcL19iQcPQzJRFTLm2bV5O/7wiEbcWXZzxbGcjmUSXsU2UfJuVMAnfnbyat38Pt5fDhe9VCl+XpYCy6zHCi/FW0cWl4c6ZP+7Ul9l/HRJ6CnHZEt5gm0x0cUTNIqEhpXBYOurx8uzku9oQeBSm6SeQaZh42Rx8jorSIWp1QsFClwCE6bccibN4PNI+4WZDgqECimhi0cPL61Qfdo/e1g8cHe+tQfHeb3M7ms3W5no9W4Ot+TEvsm7YbLul/hv0Amyv8jPhScMjzQ+08PYO7cW8wyjtDf +ShSoHDI 8AhQuJbLOh2Bj/vq5y+Roig/EDrbR/FLnwWGg2bPbr14Jv8qNoHrAxAPubglgO9ZawEDuM7QVoy5lXJj3WHD2QVvl0rYL4DsxTnbndoTz6Q5/91/pRbasNsR9b1iLP5qME3eA/VT6ZjXkFi3EnLKVIVXfqjVA7kU3xG9IrdwMxI0qXftYzvBgjmkl3IVy2frzFAfqZgMvUu+JjYENfHpfszOi8A46ElMOtcmZzhmf+A7+BdE0X18MEzz6V9oQ+da0kcFO7FbSJT6VGbYr35HNqPCXyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Batch tlb flushes for MADV_DONTNEED[_LOCKED] for better efficiency, in a way that very similar to the tlb flushes batching for MADV_FREE. Signed-off-by: SeongJae Park --- mm/internal.h | 3 +++ mm/madvise.c | 9 ++++++--- mm/memory.c | 4 ++-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/mm/internal.h b/mm/internal.h index e9695baa5922..be0c46837e22 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -435,6 +435,9 @@ void unmap_page_range(struct mmu_gather *tlb, struct vm_area_struct *vma, unsigned long addr, unsigned long end, struct zap_details *details); +void notify_unmap_single_vma(struct mmu_gather *tlb, + struct vm_area_struct *vma, unsigned long addr, + unsigned long size, struct zap_details *details); int folio_unmap_invalidate(struct address_space *mapping, struct folio *folio, gfp_t gfp); diff --git a/mm/madvise.c b/mm/madvise.c index 564095e381b2..c7ac32b4a371 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -851,7 +851,8 @@ static int madvise_free_single_vma( * An interface that causes the system to free clean pages and flush * dirty pages is already available as msync(MS_INVALIDATE). */ -static long madvise_dontneed_single_vma(struct vm_area_struct *vma, +static long madvise_dontneed_single_vma(struct madvise_behavior *behavior, + struct vm_area_struct *vma, unsigned long start, unsigned long end) { struct zap_details details = { @@ -859,7 +860,7 @@ static long madvise_dontneed_single_vma(struct vm_area_struct *vma, .even_cows = true, }; - zap_page_range_single(vma, start, end - start, &details); + notify_unmap_single_vma(behavior->tlb, vma, start, end - start, &details); return 0; } @@ -949,7 +950,7 @@ static long madvise_dontneed_free(struct vm_area_struct *vma, } if (action == MADV_DONTNEED || action == MADV_DONTNEED_LOCKED) - return madvise_dontneed_single_vma(vma, start, end); + return madvise_dontneed_single_vma(behavior, vma, start, end); else if (action == MADV_FREE) return madvise_free_single_vma(behavior, vma, start, end); else @@ -1627,6 +1628,8 @@ static void madvise_unlock(struct mm_struct *mm, int behavior) static bool madvise_batch_tlb_flush(int behavior) { switch (behavior) { + case MADV_DONTNEED: + case MADV_DONTNEED_LOCKED: case MADV_FREE: return true; default: diff --git a/mm/memory.c b/mm/memory.c index 8c9bbb1a008c..6a01b73aa111 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1989,7 +1989,7 @@ void unmap_vmas(struct mmu_gather *tlb, struct ma_state *mas, mmu_notifier_invalidate_range_end(&range); } -/* +/** * notify_unmap_single_vma - remove user pages in a given range * @tlb: pointer to the caller's struct mmu_gather * @vma: vm_area_struct holding the applicable pages @@ -2000,7 +2000,7 @@ void unmap_vmas(struct mmu_gather *tlb, struct ma_state *mas, * @tlb shouldn't be NULL. The range must fit into one VMA. If @vma is for * hugetlb, @tlb is flushed and re-initialized by this function. */ -static void notify_unmap_single_vma(struct mmu_gather *tlb, +void notify_unmap_single_vma(struct mmu_gather *tlb, struct vm_area_struct *vma, unsigned long address, unsigned long size, struct zap_details *details) { -- 2.39.5