linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
To: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
	liam.howlett@oracle.com, willy@infradead.org,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	Wei Yang <richard.weiyang@gmail.com>,
	"Liam R . Howlett" <Liam.Howlett@Oracle.com>
Subject: [PATCH v4 4/6] maple_tree: break on convergence in mas_spanning_rebalance()
Date: Mon,  7 Apr 2025 18:41:00 +0000	[thread overview]
Message-ID: <20250407184102.2155415-5-sidhartha.kumar@oracle.com> (raw)
In-Reply-To: <20250407184102.2155415-1-sidhartha.kumar@oracle.com>

This allows support for using the vacant height to calculate the worst
case number of nodes needed for wr_rebalance operation.
mas_spanning_rebalance() was seen to perform unnecessary node allocations.
We can reduce allocations by breaking early during the rebalancing loop
once we realize that we have ascended to a common ancestor.

Suggested-by: Liam Howlett <liam.howlett@oracle.com>
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
---
 lib/maple_tree.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 203a1a529884..acecd4e8a6a0 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -2895,11 +2895,21 @@ static void mas_spanning_rebalance(struct ma_state *mas,
 		mast_combine_cp_right(mast);
 		mast->orig_l->last = mast->orig_l->max;
 
-		if (mast_sufficient(mast))
-			continue;
+		if (mast_sufficient(mast)) {
+			if (mast_overflow(mast))
+				continue;
+
+			if (mast->orig_l->node == mast->orig_r->node) {
+			       /*
+				* The data in b_node should be stored in one
+				* node and in the tree
+				*/
+				slot = mast->l->offset;
+				break;
+			}
 
-		if (mast_overflow(mast))
 			continue;
+		}
 
 		/* May be a new root stored in mast->bn */
 		if (mas_is_root_limits(mast->orig_l))
-- 
2.43.0



  parent reply	other threads:[~2025-04-07 18:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 18:40 [PATCH v4 0/6] Track node vacancy to reduce worst case allocation counts Sidhartha Kumar
2025-04-07 18:40 ` [PATCH v4 1/6] maple_tree: convert mas_prealloc_calc() to take in a maple write state Sidhartha Kumar
2025-04-07 18:40 ` [PATCH v4 2/6] maple_tree: use height and depth consistently Sidhartha Kumar
2025-04-08 18:02   ` Liam R. Howlett
2025-04-09 17:37   ` Sidhartha Kumar
2025-04-07 18:40 ` [PATCH v4 3/6] maple_tree: use vacant nodes to reduce worst case allocations Sidhartha Kumar
2025-04-08 18:08   ` Liam R. Howlett
2025-04-07 18:41 ` Sidhartha Kumar [this message]
2025-04-07 18:41 ` [PATCH v4 5/6] maple_tree: add sufficient height Sidhartha Kumar
2025-04-07 18:41 ` [PATCH v4 6/6] maple_tree: reorder mas->store_type case statements Sidhartha Kumar
2025-04-09 17:51 ` [PATCH v4 0/6] Track node vacancy to reduce worst case allocation counts Sidhartha Kumar
2025-04-10  0:29   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250407184102.2155415-5-sidhartha.kumar@oracle.com \
    --to=sidhartha.kumar@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=richard.weiyang@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).