From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 356E0C369A1 for ; Tue, 8 Apr 2025 20:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E646B280029; Tue, 8 Apr 2025 16:16:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1215280026; Tue, 8 Apr 2025 16:16:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D00B5280029; Tue, 8 Apr 2025 16:16:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B370D280026 for ; Tue, 8 Apr 2025 16:16:33 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CCE1812157C for ; Tue, 8 Apr 2025 20:16:34 +0000 (UTC) X-FDA: 83311984308.16.D8C7BE2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 36697100017 for ; Tue, 8 Apr 2025 20:16:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iUpHJJkE; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744143393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1X23U1DHMhJs3gXVrbM3TFsCs/t6UqoaMxTSEHYPvfY=; b=sbe/r1Bqw87pGbwuSCPB9YByxoEdIUvTgRy4mdztFKEpfZUs5WczGRrWeRt89lj5pivti4 UNWjnLddvYPxVSzXzKeM2DtLm4nbCpGaXYc8Lz1ZZKWp2hX5f6bGQ2XqNhQ/BWuOzbVMy3 URp5oxf6nCGr71rnlHNDaH6dUfOhwag= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744143393; a=rsa-sha256; cv=none; b=muxAyWtiX0uXgZI8LoweLXv/FGNw/0Wz6hrW7MwpbvqdFZbzeqf2W0HuNeW57g5H4bX7nN tVx5cxfnUGkmWqTjQpVn19xKfIEQJIMyzSAl8vw0yD+6n5q3iMdpf54m7omzUWJJxkCBhB lMy+DX/KMa3WZdRENa15wH5X7omM/34= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iUpHJJkE; spf=pass (imf05.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 473665C47C8; Tue, 8 Apr 2025 20:14:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE0A2C4CEE5; Tue, 8 Apr 2025 20:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744143392; bh=4F2PLkKE9ucfJzfR1uPhQJZXYEmbnlCLXGg63cq/2tA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iUpHJJkE/qPceoctndxDxWssPXnJD5r73Fo04+/EvTfBsFwxBqUPenxe5nxkMrVjP MdOc4kZyh2H90xFnHDVwcoJespJIrka136ECo11Rx7ZANq5u4jlGj/OPKK8tgJNqh5 04vpMZtPtSqMUzoqklq/23qPaftB3RCXI2wsKPglKi+D9OiCSoNZm2q240WwX18L0E gdkI/x5tV0+fVgp6d6wbB0Xdc2Q2uC2O/0gr241UGvfJqpTc+Z2wp1qMOQa7nsrv7j y3PVeyiZuuonqj60K7q7v3H3EsDg+JOpykv5t2j4UzY49vI+6B3TUiIa6jB1aSyD6D jYhowzAbfH6sg== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , "Liam R.Howlett" , David Hildenbrand , Rik van Riel , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 4/4] mm/madvise: batch tlb flushes for MADV_DONTNEED[_LOCKED] Date: Tue, 8 Apr 2025 13:16:29 -0700 Message-Id: <20250408201629.63324-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: ghabnm9rjpdthidobkkmb6ia9nfukkqx X-Rspam-User: X-Rspamd-Queue-Id: 36697100017 X-Rspamd-Server: rspam08 X-HE-Tag: 1744143393-360503 X-HE-Meta: U2FsdGVkX19k/WUVaOqt9w1gVbjNck/OrxIavvBy/chNqp1giGnyII2HFEP1mLUxvASMjuDzWTD7YHAgey97Q2VBkjHQPi17TwF8qlsp84ClMuYl6GwAFHBV8TzD7JXry3bE5ICbXvy4Ddfoycwpg6nWNFn7dAUC42j7ehaXPBv8C+O6phwxN1u5U9kFkzymrSAdhxyh0Em7YnRPLjREfrWnpo2dbfM6sKWKtjSkn7gA4wVw5JAdO3rRDsNg1ni1Hf8MQ9pBoswYPZwRWmNu+6Jb+0hC4+lIhMXx31QgYA56KvvPXkwSS4YcL8VX6yzy0UpGUxhZhnzuq8e+mFJ4TeLvm1r7/jhe+tkIZTGwXw7DZ9E8YDj1DhynIVRs81lqIUR/Uyu9BWfUoPyWGaeEgSvclHW6u1Oc0okEh9krGXdszYQtRonpvlZ3M3BuMAhuTmb0gZZo83Xu6ZUWKPdQ9J73EKIb2f6Sp7bP+GxoN1G3yzhPqQVBBiIg+tTGjCjriMufK3lscz+E97G9U7a9L/8FxfrzKyh1g45SZTLjqxebmE0c6p0zMsmE/CcJNVKha/8OIbY5KdyzqLzweyFmGpWH6P18qhoSHJQ4m2k5RS8+8Ibrt4Dy8aZPwbQM+MuuEEfE0p52759JmHhD91MYOBynqNHPAjXBzI+NjEp7ORk6VkZd1fZwdwW00rrhALW6I1/4bAebGNRlNf+Pk1aclzKljAAqlYYoVSLsmxq3docQQdhhz/L1JFGyIw0KgUdSnR+gS0LrwPuIackSiyC/QhkrMdhdl+N3MaK7GHScHRNBNU9Mc/01uNIDEbD2dNq48SsE0OUbSlnV61prxTpOE8+AUT0kOE976a8QG+QdmdyudiHaDmpT2bOlzqJGh89WetU6LhHVoTju2kBfOfcQVA90XDTHkBlzyZP09PzSy2E1c/6sJflMUbaJ5pZ7NsAhUbUztCPTW8HF3+LiCtJ fG5kkC4U hdG0zPFa/2tngUJE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 8 Apr 2025 14:36:18 +0100 Lorenzo Stoakes wrote: > On Fri, Apr 04, 2025 at 02:07:00PM -0700, SeongJae Park wrote: > > Batch tlb flushes for MADV_DONTNEED[_LOCKED] for better efficiency, in a > > way that very similar to the tlb flushes batching for MADV_FREE. > > This seems like a rather succinct commit message under the circumstances :) can > we put some meat on the bone? > > Perhaps explain why one might want to do so, propagating some of your excellent > cover letter contents here, etc. > > Also you're doing more than this, you're also exporting the (soon to be renamed, > ideally :) notify_unmap_single_vma() function, let's mention this here please, > and also mention why. Good points, thank you. I will update the commit message in the next spin following your suggestions. > > > > > Signed-off-by: SeongJae Park > > --- > > mm/internal.h | 3 +++ > > mm/madvise.c | 9 ++++++--- > > mm/memory.c | 4 ++-- > > 3 files changed, 11 insertions(+), 5 deletions(-) > > > > diff --git a/mm/internal.h b/mm/internal.h > > index e9695baa5922..be0c46837e22 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -435,6 +435,9 @@ void unmap_page_range(struct mmu_gather *tlb, > > struct vm_area_struct *vma, > > unsigned long addr, unsigned long end, > > struct zap_details *details); > > +void notify_unmap_single_vma(struct mmu_gather *tlb, > > + struct vm_area_struct *vma, unsigned long addr, > > + unsigned long size, struct zap_details *details); > > Yeah I know I said in 3/4 but I really hate this name. We need to change it... :) Yes, I will change the name in the next revision. > > > int folio_unmap_invalidate(struct address_space *mapping, struct folio *folio, > > gfp_t gfp); > > > > diff --git a/mm/madvise.c b/mm/madvise.c > > index 564095e381b2..c7ac32b4a371 100644 > > --- a/mm/madvise.c > > +++ b/mm/madvise.c > > @@ -851,7 +851,8 @@ static int madvise_free_single_vma( > > * An interface that causes the system to free clean pages and flush > > * dirty pages is already available as msync(MS_INVALIDATE). > > */ > > -static long madvise_dontneed_single_vma(struct vm_area_struct *vma, > > +static long madvise_dontneed_single_vma(struct madvise_behavior *behavior, > > Again, let's go with madv_behavior for now please. Otherwise we have a weird > inconsistency that sometimes behavior = the int 'behavior' value and sometimes > it's a pointer to the helper struct. Ye, I will do so. > > > + struct vm_area_struct *vma, > > unsigned long start, unsigned long end) > > { > > struct zap_details details = { Thanks, SJ [...]