From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F18D8C369CB for ; Wed, 23 Apr 2025 15:30:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E616D6B00A0; Wed, 23 Apr 2025 11:30:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E10DD6B00A2; Wed, 23 Apr 2025 11:30:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD9166B00A3; Wed, 23 Apr 2025 11:30:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AF0416B00A0 for ; Wed, 23 Apr 2025 11:30:53 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 0DB7A80F69 for ; Wed, 23 Apr 2025 15:30:55 +0000 (UTC) X-FDA: 83365696470.01.F26BE49 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf14.hostedemail.com (Postfix) with ESMTP id 0D265100003 for ; Wed, 23 Apr 2025 15:30:52 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=KVmK48R7; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf14.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745422253; a=rsa-sha256; cv=none; b=a5sJUpKcGQqvlzv8U/hy+IOGlntN4dnkpRjLg83hlSzMBsyxJWiC18r6CdTF10a3d15qng ZVANwXpmo0vDRXded4UWRwRqbKlLEZk1RASY0tQ2INs9bNz6bm3b9qcwjDAPtCahTgIN7T 56rR4hSgB2Gulox3fcbP8dgKGO19TtM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=KVmK48R7; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf14.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745422253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QdQQd14gs27YoNoKadl9Ge4PkElvVZR2B0DY8KqAfZo=; b=nDLv9rv9klDyuIrbUlKDWm66VPoiNwODH2YGj+Pf8oj7YLO179InF2+o9GqapCNSbIJjoK M2VSMuvbsOz42IeBNtHpbKss2o2KRuSNpYrH8tUwHMEfqek5imPYhmcnAESUbiUeXf5CJo 5xYGbVS4hR6XI2FGptsaOG1tj/4Fb+U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1D8CE49D17; Wed, 23 Apr 2025 15:30:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32471C4CEE2; Wed, 23 Apr 2025 15:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1745422251; bh=vCrNV5Ep0Be2fP9czEi4ya+G254XOqQWlvqvNwnHODQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KVmK48R7rnSO/dhqqjB22cF8xwz1JrNLNvAIwoUk2ZejcJMBFlGkIdYR4/JsAsCVZ LXsioArCsQbcOXexn+CXhgYhEYz5IUtNdO3ydxFsjDlHvAgdhsF59c1xQHHCc6YcNa I2kGcHu2E9rzkq7FUEokDl6GElvirqLxPpLRkU34= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Salvatore Bonaccorso , Milan Broz , David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sasha Levin , Alex Williamson Subject: [PATCH 6.1 264/291] mm: Fix is_zero_page() usage in try_grab_page() Date: Wed, 23 Apr 2025 16:44:13 +0200 Message-ID: <20250423142635.211780540@linuxfoundation.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250423142624.409452181@linuxfoundation.org> References: <20250423142624.409452181@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0D265100003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: sbbzz63odffazr73wpiho7mm71eyeuxq X-HE-Tag: 1745422252-854097 X-HE-Meta: U2FsdGVkX18sY9pXtnO2d+m9lC/QFAppHYgDs4A3scIS0jPbK+7pYv5blQwrLuRsCRIORWd71cyFIxNOgso6mqFrFTlz39JPxAUvPQ0ULtcuTaiuTjORg0hRvKTCLZpZZuvpvfqvuCJsPi44jcXVYlm2wo9zLDG6Kb4y+sgrSmcwzwNle1843dgZfORwLNjjQUuqLzXVZyP8LtWVHDpHCz/6Ax2j5dP7WmuOTOAvjIoRSeajf6jGO4r5X6RhSBvGLi7G5yhEhieNbnltszjx8UU5WfD6oMYGlfhyd2u83OioVZ9TKeTfgzny04JFqjHCZTs0a5EY3e+/5ejUz7RwoQ4FhS/m0VLBiFPA4o1osQJ2E+vbu8/iPFTuhxJStdBWTNSsh3WdeNzWlE0Mjp8c0fYd9+PgvvNNC1BY1cJxFGU9BwB7/3OKuHp6g9P+yygzfaI0wI0BdiU5rroJTBxawGxM+qk29vppiNKnbcPJb85tl8/olyZszeAfcwPzEXlY6F87JTTTkcj9YLJr746SNBc2369uVxS4Pd5oIAyW9onRDc6AkWVfmpQuoECwzks3iMUvCHvk3Ru4FSVK8EDAH53vrl6Hzezhz96jh5AuYUJ4dmptcB+vhFoKeFMXPOmn12q9ZAuESGaTFehQSB5z7DDtWSaMQKQaf79mCsHwsDCcKKv+wnqAbpsuDQm2ZGDpnER4+J7iK754+pkQWIjOORosRHLIQiKyK7fBzTz0qspPIs5Ml4UNTztR03MK+M2MkmZEDW2y0Fi9yxp4jvZ4q6wXy8mVjQJYbCgqBO628fbYHwTHc1pBfp1mKDgozJAm6JQ7BRudA+pK4EngfX1BI+sVXmpeK0e0ElAMMFFMMLopVqft6wWfuhd1OMDBKgD+jbKYGtbcAqxmkrBGLW3pDS2GXW6pA0lV2jeykw7I5IORfYyjjgnWvxY1t7b5voyHnu9n+9tXFtGaHg7t+g3 mFSoy20S 3QAZHYPejACdIXh1yMaYpXocFEki0T43vPft0teD8N822Cgla8xmJFUOniGtz3c2pdDGcT05TEYu5gr1R3J13kUj5Kvd+G4xbk9DVqqBvDOzXMljS5blNzTOPZ0cxldNCIW08x7zYk5Gl27iGLN1+oiF6z0g/rRs4NbXmog0PKpkqUeC3FwKKjukk5no+/LxBBuk5UtOrK53EvGuLiHnVT005iK47Bghd+kAY4b3DnMW7UOZhZqz1ySp1G3oAyneempeqrJYJx2WQhZqqiTV/ZbFJJrM9U6hZSeV4MRZUCl/LRAaOPFSG2t1GRY1p9ZcNoMCkc393FBAciAXoyXADsfRB4o70Ghin7JuQ3OByxg5BAOTYVogKhRvyOkuQG9sTtR/yEeFQmUjhtSgbhE2CzvlniRw/8Bs1ZIgTpyPrelDZVgCmM4wZ9eG1JV82OJgkJNrxWu8YAA5iMWiCJbKoVqMJsQlgQot+BBu9Tt7hzKnNYmo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alex Williamson The backport of upstream commit c8070b787519 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") into v6.1.130 noted below in Fixes does not account for commit 0f0892356fa1 ("mm: allow multiple error returns in try_grab_page()"), which changed the return value of try_grab_page() from bool to int. Therefore returning 0, success in the upstream version, becomes an error here. Fix the return value. Fixes: 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") Link: https://lore.kernel.org/all/Z_6uhLQjJ7SSzI13@eldamar.lan Reported-by: Salvatore Bonaccorso Reported-by: Milan Broz Reviewed-by: David Hildenbrand Cc: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org Cc: Sasha Levin Signed-off-by: Alex Williamson Signed-off-by: Greg Kroah-Hartman --- mm/gup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/gup.c +++ b/mm/gup.c @@ -232,7 +232,7 @@ bool __must_check try_grab_page(struct p * and it is used in a *lot* of places. */ if (is_zero_page(page)) - return 0; + return true; /* * Similar to try_grab_folio(): be sure to *also*