From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666B3C369D5 for ; Mon, 28 Apr 2025 12:04:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DB326B00AF; Mon, 28 Apr 2025 08:04:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 989D46B00B0; Mon, 28 Apr 2025 08:04:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8510D6B00B1; Mon, 28 Apr 2025 08:04:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 67FE66B00AF for ; Mon, 28 Apr 2025 08:04:39 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 41A701A1711 for ; Mon, 28 Apr 2025 12:04:40 +0000 (UTC) X-FDA: 83383320720.12.F7E93E5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 896E51C000D for ; Mon, 28 Apr 2025 12:04:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745841878; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=q0ek+w7Cj3PNAbRgahJDh4ULM0v6Ru1SXEA0WTuCJDg=; b=BNvXZgCmwcPf++SlbKea0SSPDrVJ3kioxmXGwCjbD+4lBU4qJ91Is0DgjOzBMbJdet6zNy aFkixkRXKTyFaUsXkcfXfpoRG/ywCgYGedi00ivvVa1z9psPovZqZqqTPG1CgH8RJQ1bYk BQebtYvPuElyTlWEvHvC4lJtzDLVzt0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745841878; a=rsa-sha256; cv=none; b=ACbe6S70TLhdk1SJw2jRvUHnm37PyNxoFbkkVCkrd+e/ppZxVRInj/L2XwSYxjlht1vZom gK/YxC74lUN66UQAf1DcP/3dubM+fNdLbOlAiO6mEfzbv9cEEP5nbyBucjGmqA4qHrLe1z 6hMHXZ8FDNIJTo1513kHWlj76IcuQak= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 107931516; Mon, 28 Apr 2025 05:04:31 -0700 (PDT) Received: from K4MQJ0H1H2.arm.com (unknown [10.163.78.210]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E54B93F66E; Mon, 28 Apr 2025 05:04:27 -0700 (PDT) From: Dev Jain To: akpm@linux-foundation.org Cc: ryan.roberts@arm.com, david@redhat.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, anshuman.khandual@arm.com, peterx@redhat.com, joey.gouly@arm.com, ioworker0@gmail.com, baohua@kernel.org, kevin.brodsky@arm.com, quic_zhenhuah@quicinc.com, christophe.leroy@csgroup.eu, yangyicong@hisilicon.com, linux-arm-kernel@lists.infradead.org, namit@vmware.com, hughd@google.com, yang@os.amperecomputing.com, ziy@nvidia.com, Dev Jain Subject: [PATCH 0/7] Optimize mprotect for large folios Date: Mon, 28 Apr 2025 17:34:07 +0530 Message-Id: <20250428120414.12101-1-dev.jain@arm.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: x8y3gespubcx59z5axq31st1j5krcosh X-Rspamd-Queue-Id: 896E51C000D X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745841878-683940 X-HE-Meta: U2FsdGVkX18oVKq/GnvrWN7tuZcfPjaQCgE3STIxcstlnesGjsvYY0pv6Ed5Ixiqr6ZwzfNxf5TclJXIfhp5TLK+HG2DXXX720ZoYvfUHEqOqpx0qKShdeWl3ObJ7CbkUr50zdw9pHKZFVX81Jpg5O6GiEWkrWw7uydCro0iXfADSd4xfE6A7waKlrjXfpq8oIDaO6lBCNFHQbbtoGKLaDYbadQ6OGngqCDTrPkytYkvI8A1iRVkAot/xntOYP0mixkx/feLZO6NplRtUPUU/j1EkvbYw0wn5Fw/sPnab8QjahDsfbmTl5ZuYyt58eXSBmse0Lk7DXYPZ/x0QlYdItDcMjqKCg0N2ke6RLSkkUwwpW7gA0NPrQO79JgubIDwzxgkbKJfF5PGL6EXozsmALAv1Fa2HXlSmEDV/HEaYY/xmpLe9yM4HWEEnIGI9d5okfCtG4pBXmkfLSxWQkmh2ylMieFgAiUJia2jb8uUYfY8vqrhsCSwdWaE1NMJfiSC7QEL4kPNVbk2a98FRZx1SSRiC54c3VLMmQ5FmTHdIKWNRMB19GxHgen41J5fjm44ZKqHKvpoTj0E757lUuyrL6dnU870BWWAZW1yCi4qKIH66WS/YYf8epPWp2ryvMT478IS+YoNTAKTsSfhMq33TSus6H/vkKKRtg+8OrvUU4Lu7RzxIV7hEYsJjiZcPu9bdMj2Ou934gooiQ8kr5ovZtXwrztvZBDNFHBsO6Yl+/2wTllCOBUKWIaF/2wALMyVDhe7e718LRF0mcs2hDRJtCbuP7s/38X6X8AL6XLCNqd/taWtWeO0FW+3qgJKbj52nDnFMR46efOQbNN3A16RhP9AllRh8lTAG1avBitFvu2IE5jHtQSe3ESHyGu8GtNiqxwKAhcfiEBKaSwdBSaTYI0Mzctvhx+37QfI6H7hjZYLbMRkx1Ofxhc3uLQkyva/iDdEyVAZlWD1tTPfbYD d05arMU3 lKoPa/JNy3I7IyCX/VkBusNf9GkOwgIcOZ2OYP7edJGaiXsroVX8fsfQlPZPXQvg3hJkT8fqfAX818yij+IsnMUWnxXA1QofjeXAy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This patchset optimizes the mprotect() system call for large folios by PTE-batching. We use the following test cases to measure performance, mprotect()'ing the mapped memory to read-only then read-write 40 times: Test case 1: Mapping 1G of memory, touching it to get PMD-THPs, then pte-mapping those THPs Test case 2: Mapping 1G of memory with 64K mTHPs Test case 3: Mapping 1G of memory with 4K pages Average execution time on arm64, Apple M3: Before the patchset: T1: 7.9 seconds T2: 7.9 seconds T3: 4.2 seconds After the patchset: T1: 2.1 seconds T2: 2.2 seconds T3: 4.2 seconds Observing T1/T2 and T3 before the patchset, we also remove the regression introduced by ptep_get() on a contpte block. And, for large folios we get an almost 276% performance improvement. Dev Jain (7): mm: Refactor code in mprotect mm: Optimize mprotect() by batch-skipping PTEs mm: Add batched versions of ptep_modify_prot_start/commit arm64: Add batched version of ptep_modify_prot_start arm64: Add batched version of ptep_modify_prot_commit mm: Batch around can_change_pte_writable() mm: Optimize mprotect() through PTE-batching arch/arm64/include/asm/pgtable.h | 10 ++ arch/arm64/mm/mmu.c | 21 +++- include/linux/mm.h | 4 +- include/linux/pgtable.h | 42 ++++++++ mm/gup.c | 2 +- mm/huge_memory.c | 4 +- mm/memory.c | 6 +- mm/mprotect.c | 163 +++++++++++++++++++++---------- mm/pgtable-generic.c | 16 ++- 9 files changed, 198 insertions(+), 70 deletions(-) -- 2.30.2