From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E19C369DC for ; Tue, 29 Apr 2025 16:54:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D4866B0008; Tue, 29 Apr 2025 12:54:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 981D76B000A; Tue, 29 Apr 2025 12:54:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FB296B000C; Tue, 29 Apr 2025 12:54:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5DC936B0008 for ; Tue, 29 Apr 2025 12:54:02 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A3B3B120BA5 for ; Tue, 29 Apr 2025 16:54:02 +0000 (UTC) X-FDA: 83387678724.23.F25FACB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 196DA140011 for ; Tue, 29 Apr 2025 16:54:00 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hcKV1ohs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745945641; a=rsa-sha256; cv=none; b=BYbsA/quyd+lv7M/Wu/+gg9Pd9ad8LyOd8KoVdwoHD1tNkA8teEH9ndsp8YckezguXdN12 lRQuEI2IwMVy14eK+Rl5kWfvkZtyA187sPbgGqq5RXvV7hPNrOdgYuN0uYcl95mlXBWMsh v9RkJ8D2pTGfMhyeLPc2b1CZTIbvYxo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hcKV1ohs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of kees@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745945641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CR+9gfHXjnsquQxYBVRUII/tVv5A+Hk/sk8sCHNfDQw=; b=wm3d9Rt6PaloNeR1XAtZIam3EHbl75O3hHsMc9B/Vd2jchyKp1mVXF5NJBY79GfoOEubOT RJFUw+q+ZWm22z78Bg9iYjucgJ1GREy/knhejSbbj0XUbOoureYuZcPc4V+z78a1phAvO2 rBXhtKzb6Crf8AE3aYle6MpVT42pDPU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8C5D8A4BB2D; Tue, 29 Apr 2025 16:48:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F553C4CEE3; Tue, 29 Apr 2025 16:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1745945640; bh=5RJO3uiAH1dTPxWEzb5m8V+Y2lqOnzCa86KySLOdzbU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hcKV1ohsGwxmF70tNP3aPhc8lKT3edJ3ES1uM32qXcH2EOduPFu1cAiHltG0DSPzy 5+N5jYm8EBGIJIzsvjh4qLoZ8JYAjAqyxHDpkTHXIZDQP2kVd2OxrCzahgejBGUt8q ijbUIJUZRh0cAsbQ8iSvNwq2Iq2msZBlUtLbpyqMgKKrf7zuSa71HtCe/h8QnvRFqM qKISiBXSav1WhxZgAuJCqaITIeeJu9Ta6cnTmREv7AK3VFkAGGjbmcyyn4EVrqVoo3 aaobg3vS2YEZQ3Z/pLI9quBdSkEcOH32KbwKEXLoBb5h9gV6+vgt7uzEajhul+9829 UNAxCaFkA8r3g== Date: Tue, 29 Apr 2025 09:53:56 -0700 From: Kees Cook To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Suren Baghdasaryan , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/4] mm: establish mm/vma_exec.c for shared exec/mm VMA functionality Message-ID: <202504290953.70A8F99@keescook> References: <91f2cee8f17d65214a9d83abb7011aa15f1ea690.1745853549.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91f2cee8f17d65214a9d83abb7011aa15f1ea690.1745853549.git.lorenzo.stoakes@oracle.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 196DA140011 X-Stat-Signature: 7hnbu6ih6scwsx4wwpux9adjpjyw8mz7 X-Rspam-User: X-HE-Tag: 1745945640-125084 X-HE-Meta: U2FsdGVkX18weYgiFbAwxeGCffRvJwnYzVzYDBfU96uiVSelSiP3xLOQ6kZeGrZDXhjXGh9Xl+Y0ctSk+rqltUE6LwiDDg9/gRh5J+EmeMDqfElgRFvwQP0Tyh2+2sgypXNy1LfK1993q1VEMadCKq15BLge/DRwq/goSTFrfNSf+/OCcSzUIrypw1MtkTHHEUO6sdkyandKCbFSfRLa76tB8R+oxQYQ+JGuKell8S8sD6f/et1r5HOHEXm9aVMJjV6rmew2v/ekOn+l70Q0smogEi6VH6VRlA6R4lONQEEWdQCebqUAgmVaMjeOtGn8SJ3cgi9Y8HO0Jra9Oc75iBgagGDCrmovazzN3INKboqSIYuyORDjmasbyY5/Tw2rLG20zK4TijtrgNuWU3CHLYsXri+PsIg+0EUjkHe8xp9nWBxUjRxs+zoFjKnThcehQcN6Mm10B8euHBMe8Se8m8aDTSfgS/joeWCtpxLbRywr7sLbClIseoeAgg/JgXZ8KVih5CTyj2aDEWC7FgevMxAP5JaTr4SnizfLUvK8f9Lw5VqMB6ThN/atVicY0gGcTRhvsvwMNenUhuXZphWBuhBRoIZ6wHWkaG3A9ilN3Ih8c5tTcOnuZpZ6TNJGY+NYpJpJ22Z/CaozZi2QfQKghTu6AlfQ0FXphn7FOXNPFF88LNJ8O/fj9d0K7zwQYYDHfKkbiVxzFLcQhE1gKZe7Gs67zX960KE9NsaUqe/qBgwI4/vtUrpcu+u9aE5DaoOM3k+blx7mWfTGAdJ62Sdj7yvCBaAECRLl3expA8flTB67kyq8BtSm7fDwPlkZX31+h2mNo0kY1ps7QvMCoac/b35xjmHw1C6Vl/PuFaMEoLObV9y+xb3M7Ln6I/PmeGI5B/ZrKnt8AId7q9Ba6sbn4WIBJJO96EYpaAxKL0yusRj8gbZ++H/6GEohBPc8eiPHhIGGqxzcaJxDZk9KMFE 7Z+cwQIQ 3gjEbXMdLdqU1k3nlPxVKMvyOANZkOA9gTuWD19Ljk4gPhudcGEnlohOK+VJJNWJjN3eVpLy4utuptjlPrzD5ordWxwYSCtVfeycmIyVwzIfftZvZ+ZZwjPIuZ2k4W4gcOjWdv8yjMQG/mv3Fe3HqMOCyAmpruiuxLBdKwivjC6GOFeEKmN8sgZsiQMaeaN7OENAia1K0f+7jKxFF+wfnN9FSoDfObiLIepN/a4HlVl8FaaMwKXIaSl5skl1BA3J5SjHg5/hHtWbWtLszDghnm+ZvR1Szy9qUwVyZn4waNJnlRxWXigi2B7QSffdTeUJ+8AlVV4zk9DUwdtLGVbQAK433sA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 28, 2025 at 04:28:14PM +0100, Lorenzo Stoakes wrote: > There is functionality that overlaps the exec and memory mapping > subsystems. While it properly belongs in mm, it is important that exec > maintainers maintain oversight of this functionality correctly. > > We can establish both goals by adding a new mm/vma_exec.c file which > contains these 'glue' functions, and have fs/exec.c import them. > > As a part of this change, to ensure that proper oversight is achieved, add > the file to both the MEMORY MAPPING and EXEC & BINFMT API, ELF sections. > > scripts/get_maintainer.pl can correctly handle files in multiple entries > and this neatly handles the cross-over. > > Signed-off-by: Lorenzo Stoakes (I realize I didn't actually send tags...) Reviewed-by: Kees Cook -- Kees Cook