From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C514C369DC for ; Wed, 30 Apr 2025 01:02:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3A9F6B00E0; Tue, 29 Apr 2025 21:02:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BE3E36B00E1; Tue, 29 Apr 2025 21:02:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A607A6B00E2; Tue, 29 Apr 2025 21:02:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 856E06B00E0 for ; Tue, 29 Apr 2025 21:02:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2BF451D07D4 for ; Wed, 30 Apr 2025 01:02:31 +0000 (UTC) X-FDA: 83388909702.10.E34C72E Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf15.hostedemail.com (Postfix) with ESMTP id 5BCFAA0008 for ; Wed, 30 Apr 2025 01:02:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hwfHyfTp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.166.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745974949; a=rsa-sha256; cv=none; b=hjz9IOZLy8mMwAaQ1c7WvxQipMgro8BiZ8Q1oluU30jwBwcfe2hoIno9kbKw7wksT/MfLL 074b9y+ZtD8uyv9KPzVs8K5kwUhthCI5QcrXiO3+zPneaB/ccXqD2saL5/UZS8FGTZ0bp3 0DrQ+MsCSbfeMTDGXkSlaVapWk09fPY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hwfHyfTp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.166.174 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745974949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jvAljtVW/v3KFIRTwVnJMMgZUEkDR0NzqV+zjbhASMk=; b=gZUXWLD7td3jp26hR3RtfYV48FFD5A8mbaWIENBEmzPG08mHAFYsPtsuRgqahTphbKUWfw 18LBPKQiImF42fti7+q3F1Tp8HoJBTB4NswSu7ACoBU+gHtdrT+BI4eleGBjQM5NIWMLmt q1+HxEXXnlA2aNFXo8OU6iRfnDu5cOo= Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-3d5e43e4725so18716585ab.1 for ; Tue, 29 Apr 2025 18:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745974947; x=1746579747; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jvAljtVW/v3KFIRTwVnJMMgZUEkDR0NzqV+zjbhASMk=; b=hwfHyfTp6i+AUZrhP+XQc+X/+jrKd+ASs4Vk4ZpnscJs2IE4ssoorKBRbtYGr3jiLo K8kg4ehxhpgAjeiXA1bW2ix2qC82zklj3kWFg8CzH9t75KnBA8EYr9R2jFqGMydhYhzc f7PT21F3KL5grUjGJisZKVe3XfH73da0v+vwaqqjnEA05o99AhGJ3GyU2QKeYJ1Nz1Ew KFIrfbvP3+0scumpm//j1M5iq+JXUynlih5J3mykk3bQJCoDtq9bqMbVp843F71oUZwo VjzRygKFdOMTRegHvWgYHQRos/gJlBIZl7zKudWSXe+9pVhSXJS4iwI33zLyq1AszP58 eRNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745974947; x=1746579747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jvAljtVW/v3KFIRTwVnJMMgZUEkDR0NzqV+zjbhASMk=; b=CgPVD52V0ZjTGNMRFaSybT2ORHyFXuYZCS9VQIk85N6cA5o24rya+aOJOCLeoqcNXS OG+EkqhCAWP+aFbrpnUcIzYmNiD6MgM9c8iQNRoMpdwWZ6ZryYI5KVCj7nBCAG7LZYUn 8xH1/bANKWSnInWJhqLYElOjczS8KsnJvB8nBUDjdoyUsXJ9NwGpJvs9iaCpXdFr3tT1 zAtwBhzD23DoqYwgNyQJx4Yo23LQV2e7ZTF+Llr4vDYiOiXdV+j5JcIdUleYmwhRNvPn apCNdIyhziSifNUj+YHgaYhx7vq1lV+tyXEh3v1Rlx+pt7ZTP6il52Za6v5whgxNftrM EGjw== X-Gm-Message-State: AOJu0YxH2YABgVkME7lv+0p0XR4cpWyEyr/q70enZ+/7WX6WVwFyRyVC bPABhwkdUmXiaofLyNCkl4bKyMK8zPK2lQTKxEfDCPk/U308OMHJ3m3atw== X-Gm-Gg: ASbGnctQ196x+YT+JLKHkjyS7qUiwa0EpXIsFrPA+19Jv1sBoXwnmXhYIYixtvx36pp fMOXmiZSyEeAKHoEADxCCJO6zTKRIzP6P8eKGCIzdfOvnKvbvKZ4/pYO1txxM65WGLVXC8mLTtF I6mBYu4NKaM9YHgKRyu8YQLm6Vwpq/QqDSFBqMx8S0+4zZd3c0NcSixoy3v/g4Sdy7MmeH4QD1T /gSva4seDNPXqkLPmLwvZmGnHXYMMBO86SxdV8+BZf6WjRbUmJeFLlHOR0e1ka0egG6W65beMX/ aLEfRg+P9HKp3UamnGzQbwEa4UAeeLRaw1drj9QaojKpe0fVciuZbH4x064EW9GWHbDSCUI5hIM JPg== X-Google-Smtp-Source: AGHT+IEqVWKK47PDWeN2vroc7qkCsqnpC1DhiEQxGM9nyXMqQBC4Oc+mxLlk/po3P//MbfWEHsKv6g== X-Received: by 2002:a05:6e02:164d:b0:3d0:4b3d:75ba with SMTP id e9e14a558f8ab-3d9676b28femr13321325ab.4.1745974947594; Tue, 29 Apr 2025 18:02:27 -0700 (PDT) Received: from fedora.. (c-24-8-12-5.hsd1.co.comcast.net. [24.8.12.5]) by smtp.googlemail.com with ESMTPSA id 8926c6da1cb9f-4f862e0f4c0sm534818173.4.2025.04.29.18.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Apr 2025 18:02:26 -0700 (PDT) From: "Vishal Moola (Oracle)" To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Vivek Kasireddy , Andrew Morton , "Vishal Moola (Oracle)" Subject: [PATCH 1/2] mm/gup: Remove unnecessary check in memfd_pin_folios() Date: Tue, 29 Apr 2025 18:00:58 -0700 Message-ID: <20250430010059.892632-2-vishal.moola@gmail.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250430010059.892632-1-vishal.moola@gmail.com> References: <20250430010059.892632-1-vishal.moola@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5BCFAA0008 X-Stat-Signature: 163dfsko7qqgm6nraidizg88rghmf5nz X-Rspam-User: X-HE-Tag: 1745974949-301269 X-HE-Meta: U2FsdGVkX1+gK7TQYgCqXGVxvofpZeRnDYsm2gRDUCcrIdq2dLEHkTQm5TzjSoXzbT5v9Ej2qMsflz1I5/f0MZWEIaq03mycfYy2ELRKlWWRg7TLef1ysnbCnyhMmezGCYiwpTTPe3lp19TmKRs5SdQleoQBcN9AAbqi2t0R3C5zE8n2D4Rn/yE+mnVFB5Pk5Tsi1GeE86Z2W0velsas3M2qq1UqElUF0fFr1S6X+TyP5kuNrYXPDOpn6qPL1XT3xDX6WV/jS8ZxY82dOtOGAcOS0DOvSbyi5CVzzyJS31VOEgPnIzF2DOJgqcZRtcl+hpP9KGW0KzA6zET6LFqBgjbFFeau3B/3L5eTTTyZo1rLMD7f36wZVu3xrtnbYyA8ZnRitdZLcl5dMguXJPTigmdY2AhmKPRYcBNaSz76b8WrF2Upfe9bSE0s4YSzP9tMHHuy3aLpFpvYOcICQdE51f8CVnQJ0sPWGUsFRahVWc14ZB3uFP0oNaQlsO6H+aCntG2aSaj4CHe7NY5xB0Ra+s8zDhizv2AWdOh8ZkzWrBzsLPU3fqvtrFSTnXFMzSOpjm3vwA8dbDW1zNpushT9LL6OcxNLok6xwvUSfvnPqDfv14dKIY2MEeazVHGbAL8g92H8mOxGmR9Vcdt9efWRb8Vqu+lXZ3zXyFQDFlzQhbF7cL9WAE4gn8Q+GatwN76RmIoIjE8oUUkxTBDlQ3CsXRg7ARvUdoP3kPfyrYSs3O95SLmEWJTxN6d/hlDgp/e8Vm8XCEJDtxKEqutzEChGt+dzkx63PhEvJZ84j/DHb2WbVUSy5X1veLX2r+iFJtY51JrlDtGmVPeV0SIgLBgRqg+Z0SrG+4XhWIHp07hEQGCBkHkzM7BswlWffbhYxlAH9n1YVPepLfpwGXjuVNaJQUF1wjJ9f0+yMjgSM/v7Wik2yxj+ffp7+/a6UONFe1NNTGbv7uiwt9ODLPOMX2R w1N260Tr X4NbRU0PT19S0LEa6W4rWMbKV+2Vkpie0pFxnQaONq5oFzBSEspIZxXuPmFfY/DSpcGLRZS+8cNaBIzAxMzpcNgsKR7cZtaSVv1hCXtySKHzkg8hvLHiYevZAebP40mtLX4FXAHbmJPtF22KznVMn6uKDpYEzcjLavtIhhwH35WT8tgmXkV2/cswXQnGP20hkeNTdADgO4kK8L5qMzfaFsZaAx1mml34+f4PnIxhRjrotXS09G8R7GfvboRLa+fi32x0BETxvlPWp4hahQrFCVpaIi9yamlv8fd8lMbD00K51gYiVYoLmSLEzALkdvAs088kcFK77LCtb5IgxodiuSV+8nEzFFS3H+pxtmTsc1w/u4pQSnQtXYasun7UIj5Rl+3VfKBDtr/sEfV1rwTn2bZmWGW+genRWHbiyriRVbIMgId8nfUPELnR5Hd09InuKhn6DsTUgWBfzKZ2hHlVNej7ZKWjKUfQUjqOeSOxicJQlTr6M0EzZYNB/xP8oNCsjszWSwuQ0BwG3/n8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Commit 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning memfd folios") checks if filemap_get_folios_contig() returned duplicate folios to prevent multiple attempts at pinning the same folio. Commit 8ab1b1602396 ("mm: fix filemap_get_folios_contig returning batches of identical folios") ensures that filemap_get_folios_contig() returns a batch of distinct folios. We can remove the duplicate folio check to simplify the code and save 58 bytes of text. Signed-off-by: Vishal Moola (Oracle) --- mm/gup.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index f32168339390..1fb8f3b9a493 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -3589,7 +3589,7 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, { unsigned int flags, nr_folios, nr_found; unsigned int i, pgshift = PAGE_SHIFT; - pgoff_t start_idx, end_idx, next_idx; + pgoff_t start_idx, end_idx; struct folio *folio = NULL; struct folio_batch fbatch; struct hstate *h; @@ -3639,19 +3639,7 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, folio = NULL; } - next_idx = 0; for (i = 0; i < nr_found; i++) { - /* - * As there can be multiple entries for a - * given folio in the batch returned by - * filemap_get_folios_contig(), the below - * check is to ensure that we pin and return a - * unique set of folios between start and end. - */ - if (next_idx && - next_idx != folio_index(fbatch.folios[i])) - continue; - folio = page_folio(&fbatch.folios[i]->page); if (try_grab_folio(folio, 1, FOLL_PIN)) { @@ -3664,7 +3652,6 @@ long memfd_pin_folios(struct file *memfd, loff_t start, loff_t end, *offset = offset_in_folio(folio, start); folios[nr_folios] = folio; - next_idx = folio_next_index(folio); if (++nr_folios == max_folios) break; } -- 2.49.0