From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC673C3ABBE for ; Thu, 8 May 2025 04:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31E0C6B000A; Thu, 8 May 2025 00:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A6736B0082; Thu, 8 May 2025 00:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 147856B0085; Thu, 8 May 2025 00:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E69156B000A for ; Thu, 8 May 2025 00:38:43 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0D01BC069C for ; Thu, 8 May 2025 04:38:44 +0000 (UTC) X-FDA: 83418484968.20.CDB3561 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf16.hostedemail.com (Postfix) with ESMTP id DF31218000E for ; Thu, 8 May 2025 04:38:41 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=TJsvKQ1u; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf16.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746679122; a=rsa-sha256; cv=none; b=nW3Zz588hyWRguklfmN4ROaz2TxSeuPEs1K/Vo0aLPs/IPE/BoEOzOdiGopHZslxu6TDsO G1dvWAZVDD8u81Sopjog79EP4atcobFkdKk4DOqtvYpcDWNWXkshpM0JMjcMMe+hF0734S OyqXKJPATIdsxZvO3uQnOkFfYKvO+wk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=TJsvKQ1u; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf16.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746679122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1cqTOyiEDcgpIamZxdiHYiIDNncwGcTc3EyIyp1gE8o=; b=UwQ98AhnNryZ1V0c9AixasAf7ygYq38MRaBIAo3EIEH84w1uH7VtxNgYs8uRtI9PAE/ZXz 4je4ERVPqOcrPdDhLZFKet9nmbtdK2+e55UKRHp5Z2SEdG7ReI35xf1gkaSWTBcPuAEfqt 28mitoi2CeO3hEKL64fkL2ELhIkE9S0= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-476977848c4so7238701cf.1 for ; Wed, 07 May 2025 21:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1746679121; x=1747283921; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1cqTOyiEDcgpIamZxdiHYiIDNncwGcTc3EyIyp1gE8o=; b=TJsvKQ1ua1QqrKp+mJ2PGNzbFaSgKL4UlnvtxRHdco60Sm8AKbAMUpv0lAkix9RniY UibMwHlXrVk3hE93PyZoRNW5+HsDJYNcknNDUVjLwyWVHD9nA1MzXstKYgRTG5t4L91O 98JqNdlPUpAXNrPgd7t1r9vj/QVQSlyrEBQs6NS5SdxNHAUpkzpNb7mPSVIAEc+y1+Yl HTbTKQnib+gq1ZERIr/MEMsTeVjPkwHGR2zdS7+MuxCtxpu8OvUI1Cm+NG14DU4tA3Ad qsk36X8s+QtP6dDcNJ4GkH4kYZk7U07mNsbW0UEmwBgXfgy7qmiiscnFz2HKKeUsz5T9 odfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746679121; x=1747283921; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1cqTOyiEDcgpIamZxdiHYiIDNncwGcTc3EyIyp1gE8o=; b=JHd8F62nJ6SHjhwj7HQmDvJ5ZwzycCphZn9AMyHYcPwOD3RZoZ2QxsuDRis7OwQf2o 74trilO7ebo0SxkxOfwHFmtSRXaG/duKB7R4XO678OAP4+0Zq7rjYhSsMdpXF0x6fq8R gAga2e/s/+Cw3QhSQdjsWMMOQp4BIulCwXzJ/rdFnTI3NTF0Mb/Xo0GD4SSTJ/LE2G0X PcyKEIhi6wt9Ol9gfezdCddiSRTCouPEKzeVYIubE75Excxmzeg8RLDcNpjQUKbaK+xS kL1e/2tamDsS1oip+D0Kfk6ttiNRVcSAg6c6AMemNvHSTxafrn5dsIu4lKHGGxQ5xc7I VoAw== X-Forwarded-Encrypted: i=1; AJvYcCWtbNqfZBl2PP+x5aLxlAIOfH8D475LeWsQ7Ns0vswzCYei3FLlAgIVJnQWaFqhAgwY8uB1DdCwpw==@kvack.org X-Gm-Message-State: AOJu0YwS+8KhGW5FGS89v6VW30kYKFgQ25lYdLPzKa/TKbyQJD9v9W0C Cn063tXnx7PRHozrZBkiyVfkAWS4hxww16AYzHpZZ11zEqdZ0NjgCCSC1wmqyBg= X-Gm-Gg: ASbGncstqiop5F19j+kWh3GioHccdcbYHtLMzP6prjdiZ7Ynr6neambD0wXpkLgT7i0 z9JUvLUrAbXiJOX/pJwu0k3ovxo3eA3BbPRTpI/u9ne/N84n0dhIYa9aOzvJYTsQRJhQlVE6ufx pOzENNSt5QsWXmC76cwAfysf8iGWhnphmtwfzLDuudrw1W/KTK8XJkom4kJNdFs7Udc1Feu54aN zSKXJdevO9868nAkDyJDSDx2vvarI3lMToT5Pb1611nZnm8bh43eg3DhDHQPW0RU6LfHmuIKELA xDtRAr5h0ltmcfAs96F6hwkIKzQojSIs+nqDDws= X-Google-Smtp-Source: AGHT+IG9SXx3+szVrANw7iRh1ucZW6wHm68iT4qY9p9QukDYzSxLw6oMm5attLANpOpVo2taKiUizw== X-Received: by 2002:a05:622a:354:b0:476:8296:17e5 with SMTP id d75a77b69052e-494495ba88fmr28566081cf.17.1746679120854; Wed, 07 May 2025 21:38:40 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id d75a77b69052e-49223457d50sm27837941cf.71.2025.05.07.21.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 May 2025 21:38:40 -0700 (PDT) Date: Thu, 8 May 2025 00:38:35 -0400 From: Johannes Weiner To: Zi Yan Cc: David Hildenbrand , linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Vlastimil Babka , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/4] Make MIGRATE_ISOLATE a standalone bit Message-ID: <20250508043835.GA320498@cmpxchg.org> References: <20250507211059.2211628-1-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250507211059.2211628-1-ziy@nvidia.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DF31218000E X-Stat-Signature: 3jkpu3rd3rpj15jea13675z3aaeyfgib X-HE-Tag: 1746679121-234655 X-HE-Meta: U2FsdGVkX1+wtDUcUVXJ7sw9THGSMPFu/nvcibO+uArBZgo9zguuQdLXKbJHWlhWe5E4ncdXG5U8mmET1vqrUdh21yeXFA51NPwQNYlBUizcyngA7mcSuFZC/dliMRvXI1QjFoMdpVsVqvbi9bXdzuEytgW61OvwS7hyUKuD8BZUwL7bfHODrpSRFI6FJIReWBHlfeSO3LGWUDCd7c3AjWmKBGJeQJbuuST8Zoryl/pwpx6qbGCfvCONYsiOxThX491beUkGnxtmRZIHcLEbOBoMl4RWQtolS3SRDjoT/8+Mec+zlinfSg7p6xofz0x9I7bm5qbwF/UAWBwE8DOCmNffDUzUkrzNcwb46dTbz6yQRJkETgeg4zo/QdmzN/AB2JOUYk2DKlmjYA9R0Gk+5QeU+Jt+FOA5TxJPwk5+7nM3+q3J7YDys5W1agZoumbK/kuil9Ehh+QG7bmiVJaQD1MHLdDt+dbKlETOef6Tw1O7pG4+2Dttge1vw3f3ezZYUBdHwHT7rU4E8NwYvx3CtLHAHxpeByVTt8sX/0jy0/MJruFvsT1JOq0O5cYDUqi4Mt6h8NP9+mvKcoCzeQJa+udvKkTBDDCSis9qsogRs9f47swTTZRInAlHMcZnl89IsmE4vAw8gcaX1YJZdZoJB9lzx80HRM7MHlJ7QVo+ED4cxLelQ7wTHPIRIyF5p8ALANo1U7kRokkmyAytSceNmmfQHpfj46t2zbUNvxFzL8PkKc5MmTEXWt32EWX+TnSYlWu59PLTyYKRSBONvg4QGKezvR0NmB6HacQGCduuQxX9pbEo9OzFvslx3v0LmSZ/Y0ogqTXT83TZ+ZGZaYxYZip6TZ/q/uswyQyB5c09U01+HahfgWWXvkcVavbYYVAJZNofaJdG1M6KRuvaWwEqXEvBujqV8ejY92BCs4bI8AcvXavfTNHr4Anddw9c7igCQiRVsldPx4zazxbIPST /kdaqvDn eCGF5e3JSZthPg3X9Xet5kty0mvb+6w+L0DoYJ8pl+weZ8neOxRmTdEXFssC1eQIkkMpMiu5LeQsL4eqowugAiWo7k6HdMt/MKutXPs95QxASnDAmI9Xfu6j/VOeIiVJXJcEv1GHfJw+t809b3TmtHcgiKqe5w9bpV6hfEIiZaywW5qtgxKUG8yksijrG4exwRVNO2a3tULV9dQe8BxTmE1c39INZiBjH6qv0Z+EIRmEhMjHit2MjbkQFS/JKpcTnx07lJQjr107RlzZjEX4zB8ItoDR8WRsHR9Ylb8UC7qf0InJS6qu5XBhCLHPLeHZij7R7dDO81qlkUYx6j1Nh/5F1rT9vb+2/I39aK3qgLgZtO/37ZDwQ6RZ7QYmEy+UJHh0WjzhKn2n2wGXoQbPuyBdLRQF4YFn/r72c5xO8/YbcS4Grz3yOpDcRIE1YgJUmnP9SLscTVdUBihxK/9LUgQL8vyl7EyLOl+P9JZLMjhPag0MQOwFzI/YzwwQ5N3/poWEmQc287VXcvbs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 07, 2025 at 05:10:55PM -0400, Zi Yan wrote: > > Hi Johannes, > > I incorporated all your feedback on v2 (see Changelog below), except the > "decoupling enum migratetype from the pageblock bits" one[1], since all > 5 migratetypes (not MIGRATE_ISOLATE) are just values and > "#define PB_migratetype_bits MIGRATE_TYPE_BITS" would take 5 bits > for migratetypes, which only requires 3 bits. Let me know if I > misunderstand your suggestion. Thanks. Right, it's better to stick with enum values. My main worry was that PB_migratetype_bits *usually* correspond to an enum migratetype, and MIGRATE_ISOLATE being the precarious exception. But I think it's much clearer with the special-casing in get/set_pageblock_migratetype() instead of the lower pfnmask functions. Thanks for moving that!