From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7A9C3ABC3 for ; Sun, 11 May 2025 03:07:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A4986B0088; Sat, 10 May 2025 23:07:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92BF76B0089; Sat, 10 May 2025 23:07:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F1346B008A; Sat, 10 May 2025 23:07:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5D4F06B0088 for ; Sat, 10 May 2025 23:07:44 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F19715E4F0 for ; Sun, 11 May 2025 03:07:44 +0000 (UTC) X-FDA: 83429142048.26.304FF07 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf16.hostedemail.com (Postfix) with ESMTP id 47F1D180003 for ; Sun, 11 May 2025 03:07:43 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2qlqS6EM; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746932863; a=rsa-sha256; cv=none; b=TV0bk+wrvEEYkNRUj55ser7MMlRfAKEPnBGXO9hB52CEvpui/C164GhuuzhEe/sFpzOXXa BsU5DgK6IBQ8b7Qqxc+hgjcNTPya2SpR2JWCL20mSpPY8WRpyplEaGc2nDFGhfTw8IHjse jdoME2a8UpvsN1f1zm33JIaB9l9O850= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=2qlqS6EM; dmarc=none; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746932863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BXdVC3FUSK9LSukugWv9PQ/rYQ+/f3XzWzUNFrH0VUw=; b=DVm/YHOehwejIU1V74goH2hxzz1kfi5CL9UWm8J0F8gt0YPbkFEHFrr9uNGnzYjjrHQ+wC G/XJvysxP/GI7XfIyiDbZH9TsjToFQwcH9dW8qimpnBIgJ/LRnXzVGSA07tMh3GDtKy+GB Vembdkle91IEP52u92jXWCfI/BoZDt0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 722D26000A; Sun, 11 May 2025 03:07:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7EB7CC4CEE4; Sun, 11 May 2025 03:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1746932861; bh=ZNkiyzbnYjCmJ7Q8aldKqzDsIc/xK+QlpyxxtNeuBjY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2qlqS6EMafUTp6lwh89oblzRV4jkgWldegyTw1GfvzoDsGhEEmRzCHA+pOsRpEkXf UfbQBePz9kd/IpeRF2UXtOsq/jcg5pkj3R5iZ4m2bZ2WDBV6F2Urz7lXx1l0FTDjDm syU3c0BJditxlFsK/eOTS0IqzlVzso12fz3eMh5k= Date: Sat, 10 May 2025 20:07:40 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: Tianyang Zhang , Harry Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan Subject: Re: [PATCH] mm/page_alloc.c: Avoid infinite retries caused by cpuset race Message-Id: <20250510200740.b7de2408e40be7ad5392fed9@linux-foundation.org> In-Reply-To: References: <20250416082405.20988-1-zhangtianyang@loongson.cn> <025e3f51-2ab5-bc58-5475-b57103169a82@loongson.cn> <20250422171116.f3928045a13205dc1b9a46ea@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 47F1D180003 X-Rspam-User: X-Stat-Signature: irpy37eycgtqtsfx5t4s1y53csgzsh1x X-HE-Tag: 1746932863-837740 X-HE-Meta: U2FsdGVkX1/9x0ss219GApuHQw8YRa9cQbcuS2Y9mpL5s1P1MN5BM9402FxJ8Vrx10DhZ97MHetVItlnpZtXacR/hjxplggDn+0iMfPZmK9pJvZneMiTWDRp/hKOw1r+AhGmwMTicbk95BRDXmIRW1MmjHgiltzCYtSAOGKscMR9Fnwy9gKd8eJ+8Bjo50ehyWyuwCzfpHP03yHy0cvDH5fmpofYe8Hy6CrxSGyVcodarYZ6+4FauZt+AtOLr+JheF1KR5sStrxC8jsR7yB0N9jhNHyKdF+41ElKSQztZbSF56tZ+AhWqgsFt1eUYr4xq+/mjetKdH8x+E7jZABAYtzK7MxDDCnbsz0ZVTaXFkYUXy7ZPAbw5k6TYmIPGDk5u95v2UWNv2Trj+dKU3EvugcVADAE7zq5ORYgfEW0tBW9zAgJcZoJwlozWASFAEh17+h6ep1hUruTJRaW2dq4pB5W3mR4cOxEn4BjJ9WT+cxScK7XLAIDVEKBFOa/ZSLCloPJv6Kcn6rZo1GmfEP+CYyOPmn5TFKD6/J1htF6foa/edi3EGMf9Iwdeox6epCp0fxxcrcADbY2L22pB4Pd8EjqvhkemBtiLQ0/CHgmrBLhhGJMacc7FfqOiE3YaiR5jn4URj0I2sArSLqXe9couj+JbO4A5FRQrKDjgRSpHHhj0I0i+ku3I0IHE2Qq7qFJ+smGG4XXMMRxKPLvLGhMXWYWcia543R4ihojKmWyT1ODCwQgb++NnkWJ6bQccwzB4Ey9dLZWLjiEYif6dh960SkoqP1dMJbHLgMB3r2vkFMPwlCQeJ/6rSdf7sx+Zxb+m6aCZL8q+ZuD0YrJ4w+x9zfQLfotDnYOHediBPJfMvsWl3Ok8tHgPPRb70WJFj5vvHIYIolD/Z1wF7kC0vNsjSc+kGevfo8x5SG9gkpmQASf+FNJi1mB5Rm1KYdnxkMHhpm10fvkAcsNDa0xc4G sOOsl1fu QNTQwuQc3FWtJ7fEaots88Ut4Ix20Yfcfv5BACAl5RA+O+Oy3Q1H7h8tH8Grn4EzBg1rLSwJNuhQsy+EG6IL9LU4Rt55Aa7C9U8UFN4rayrBEEoHRNE3v3YB3icLWBBJURQk7/sXLu8LUPQ5+mw9d11Oe2DkVsxzqL+PCOkX/MlJ5MfiNp1WDLxS4aMGfXWEtA6KavbscDTVPyPdLcGnARNwjv9iaxpxqidYs9n3zSYuDQayyBBEDyFqPpr7FA3yCWvttZ6LxLfE3qzktI4/dfcWSsE+7QRxv3lAXzv/dHs/qSaKcbACfWjK2qKNGUkIMi5Ik8eTzi7VMBdLQgly7RvwMy+JopgemmXeKONoL//+jWfdigkBSXVqJnMZznFi0V9fUurdq3jGDou0uimIX/u+gzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 22 Apr 2025 17:22:04 -0700 Suren Baghdasaryan wrote: > On Tue, Apr 22, 2025 at 5:11 PM Andrew Morton wrote: > > > > On Tue, 22 Apr 2025 20:10:06 +0800 Tianyang Zhang wrote: > > > > > > > > ... > > > > > > >> > > > >> Simultaneously starting multiple cpuset01 from LTP can quickly > > > >> reproduce this issue on a multi node server when the maximum > > > >> memory pressure is reached and the swap is enabled > > > >> > > > >> Signed-off-by: Tianyang Zhang > > > >> --- > > > > What commit does it fix and should it be backported to -stable? > > > > > > > > There's a new 'MEMORY MANAGEMENT - PAGE ALLOCATOR' entry (only in > > > > Andrew's mm.git repository now). > > > > > > > > Let's Cc the page allocator folks here! > > > > > > We first identified this issue in 6.6.52-stable , and through root cause > > > analysis, > > > > > > it appears the problem may have existed for a significant period. > > > > > > However It is recommended that the fix should be backported to at least > > > Linux kernel versions after 6.6-stable > > > > OK, thanks, > > > > This has been in mm-hotfixes-unstable for six days. Hopefully we'll > > see some review activity soon (please). > > I reviewed and provided my feedback but saw neither a reply nor a > respin with proposed changes. OK, thanks. Do you have time to put together a modified version of this?