From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 104C6C3ABC3 for ; Mon, 12 May 2025 12:36:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DF856B0114; Mon, 12 May 2025 08:36:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98E766B0116; Mon, 12 May 2025 08:36:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87E3F6B0117; Mon, 12 May 2025 08:36:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 683BC6B0114 for ; Mon, 12 May 2025 08:36:35 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D6F04BEA82 for ; Mon, 12 May 2025 12:36:35 +0000 (UTC) X-FDA: 83434204350.20.B280079 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf11.hostedemail.com (Postfix) with ESMTP id 6859F4000A for ; Mon, 12 May 2025 12:36:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747053394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WyoIqOjVTX4+u0ofQJEujd6134cE5srWho9kzlkXXno=; b=roZip96FOWNjJUnFc/jZpud3x5jpzf2QCE3Z/UO5X4np3k3p4fKL7QcDFk5/W144dn36ft aQB1XX0dR87hAknKsNrT/lMqNmeSMPJuJSFTah8alY2pdjotTTUOfPE0NqL2Y7VayhdDIy j6ITnFjORhQiEguxPMs7rWb/0KAVu9Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747053394; a=rsa-sha256; cv=none; b=KaTbvfjRX+tIEubZIRsnysdUh/DvRaz84TxD4f+rKfK11H3h8jhLRxQNH2o83GAB/yzm/i OZFZq/zumWRR27XvxExx97IADdK0v6Z/BPkYHsDbY5QdxKiB7A3lL60+mrXOqDX4jm1dbX XHLkLXkRI5+hjUPUFgZsnAzyFGQDMws= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com X-AuditID: a67dfc5b-681ff7000002311f-07-6821eb4fc11d Date: Mon, 12 May 2025 21:36:26 +0900 From: Byungchul Park To: Mina Almasry Cc: Pavel Begunkov , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, edumazet@google.com, pabeni@redhat.com, vishal.moola@gmail.com Subject: Re: [RFC 00/19] Split netmem from struct page Message-ID: <20250512123626.GB45370@system.software.com> References: <20250509115126.63190-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsXC9ZZnoa7/a8UMg9OX5CzmrF/DZrH6R4XF 8gc7WC3mrNrGaPHl5212i8ULvzFbzDnfwmLx9Ngjdov7y56xWOxp385s0dvym9miaccKJosL 2/pYLS7vmsNmcW/Nf1aLYwvELL6dfsNosX7fDVaL3z/msDkIe2xZeZPJY+esu+weCzaVemxe oeXRdeMSs8emVZ1sHps+TWL3uHNtD5vHiRm/WTx27vjM5PHx6S0Wj/f7rrJ5fN4kF8AbxWWT kpqTWZZapG+XwJWx5ft99oKjvBUPv69nb2A8zdXFyMkhIWAi8eDlVXYYe+HP00wgNouAqsS+ TwvBbDYBdYkbN34yg9giApoSS/ZNZO1i5OJgFjjLLPH10zlWkISwgJnE8cs3GEFsXgELiWnT 24GGcnAICdRIbDmTDxEWlDg58wkLiM0MNPPPvEvMICXMAtISy/9xQITlJZq3zgZbxSkQKDGp +z7YCaICyhIHth1ngjjzHLvE5z/pELakxMEVN1gmMArOQrJhFpINsxA2zEKyYQEjyypGocy8 stzEzBwTvYzKvMwKveT83E2MwEheVvsnegfjpwvBhxgFOBiVeHhPvFTMEGJNLCuuzD3EKMHB rCTC27gdKMSbklhZlVqUH19UmpNafIhRmoNFSZzX6Ft5ipBAemJJanZqakFqEUyWiYNTqoFR x+LqkVKDxgeRRnLyHG7qPb4Sew6Vx1mJnszo3P6x4/HXprNJSz7e4z+2k/+70bO2masVG7vM 3045LHf2srUnV7zzPrNGrWlqiQf3v55zv2vjR9789uz4ubkaQf93lZ9oKWoytVTrDZN6+Hri 93CTkxcXOmqtDM7wqX/W5vctLHfVAZNT6ycpsRRnJBpqMRcVJwIA//ACmuACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsXC5WfdrOv/WjHD4HWrsMWc9WvYLFb/qLBY /mAHq8WcVdsYLb78vM1usXjhN2aLOedbWCyeHnvEbnF/2TMWiz3t25ktelt+M1s07VjBZHF4 7klWiwvb+lgtLu+aw2Zxb81/VotjC8Qsvp1+w2ixft8NVovfP+awOYh4bFl5k8lj56y77B4L NpV6bF6h5dF14xKzx6ZVnWwemz5NYve4c20Pm8eJGb9ZPHbu+Mzk8fHpLRaP9/uusnksfvGB yePzJrkAvigum5TUnMyy1CJ9uwSujC3f77MXHOWtePh9PXsD42muLkZODgkBE4mFP08zgdgs AqoS+z4tBLPZBNQlbtz4yQxiiwhoSizZN5G1i5GLg1ngLLPE10/nWEESwgJmEscv32AEsXkF LCSmTW9n72Lk4BASqJHYciYfIiwocXLmExYQmxlo5p95l5hBSpgFpCWW/+OACMtLNG+dDbaK UyBQYlL3fbATRAWUJQ5sO840gZFvFpJJs5BMmoUwaRaSSQsYWVYximTmleUmZuaY6hVnZ1Tm ZVboJefnbmIERuay2j8TdzB+uex+iFGAg1GJh/fES8UMIdbEsuLK3EOMEhzMSiK8jduBQrwp iZVVqUX58UWlOanFhxilOViUxHm9wlMThATSE0tSs1NTC1KLYLJMHJxSDYz+tVElnb3lWzL2 vjZXrIn0LrTYvXtCu6/4EsP+ZbLG/xbtYCvtkSosYf57zdlPzOB1Lq9n15qvV6ccOXLwmIhY dLcs64qCc1+MPHTKp3ZIflrwv3JDvGrXb+4Vph8d1H4fO/av+sfkQ+tO37t8N6Jj/fs3U//V RF5m0/5ml/fm/fTtpjurT51XYinOSDTUYi4qTgQAYc+tCMgCAAA= X-CFilter-Loop: Reflected X-Stat-Signature: e48a4je1ciewqcq9s57huo4btngzcscr X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6859F4000A X-HE-Tag: 1747053393-780760 X-HE-Meta: U2FsdGVkX19thwf6EO395hh+6aB3TcJyyU1G2CXVe2ANHciKszjHW4Rth8S8mBmfdCVhQvbLNTdm1BVoWY/4dcwqnOTbuWL7N6sRfpgCWfW1MIaVo4q0GGz8sC+t36hqZ1cCOMZ0UCoYjJPXQEBTVHPBXTwMaTyqudRQKhm0qhZXupDob1SUU4nPMR/hcu9oP6h26X0upXKnKGprnh5go3n1z8s5gE+dtdPmMsezMfEJGkUy/i7lMcR+EKUFOlwM4y0XtRRhWTv/zJ+0595Lwz27GLYTYsyzVqw285x/GbZfuAiRSmTb0kHY0N8b0ayPbBo94gkvSrWqvx3oGpkk2SNjxjfnqjpVW3xE9KAlnHRPBtARbIv3nZKFims1wp7g4u61QWvMcVhUoDaKDY/Pl1iPijk4OkExORDTHyVP1B6HcPN818i+GuHEEQCYGyWEx2LLt8ntOskl8CYfdatg2uY5NgkMdtnUkY3uNJCzL0Kb+FUiMU4LPlCPaecgZdcocLNX924BWt39SGoGCX5f8m0F0IIYK7nd918+GUwwb/5Xfv6htVtDWDZw346TL5mF9RNQRC9y4D+YghWkBIdS2WHxJAqbCOfMDwpbm3IRvt5EMXJRQdbOrgK5i/ck3oJbGW0sngqcjSg/nchfivaOm2uBNqgTUuwtLMC0dnxsCtlI4bJrZadOL9bXlBsLAP7WmFMLtFWfJoudz9Pyv2/XG1dYMmQ86Ciiu4aCuGpIRqWz6LNRLMAuk56LyGsTVr3SbmJNsMQyFVfS8hqiRDc2ojavf27f827P4yNG5STJFs+yLr8MyKddgKE7jjaqPME7iyB+e3EhWoEOmuUMpuICBjRcZKXFG6gMgOmBREtGCQzA2S/RnZNh9NgIKZ54q7bFv0KtIkYT5E71amCzY1hD7KS65ZeXTNmHWeH1NZz3D/+j+vnO716VBLEc2qTCAvOSDpPzpDwXNu79EwRn3xa XuGxgRnl fCfz/KnYhC9PmsygDyejb/yCFWfm8L4dkre6uY1KNF1+Toc7YG2/8zFDTWwVnolKZjZueojhOUZiJEK5FI4HQWgbu7CWdxhMxsZQ32vq1gloQtfNcUQUO3alhhTCVHXpYZXCE6SLPpB5JV4j4wzE/8wkORe4G8FHxBS26aE/d6XdDYdBHnNJjWmHVSqSZFXKvnOdbMYi1H9P56+w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 09, 2025 at 07:09:16AM -0700, Mina Almasry wrote: > On Fri, May 9, 2025 at 4:51 AM Byungchul Park wrote: > > > > The MM subsystem is trying to reduce struct page to a single pointer. > > The first step towards that is splitting struct page by its individual > > users, as has already been done with folio and slab. This patchset does > > that for netmem which is used for page pools. > > > > Matthew Wilcox tried and stopped the same work, you can see in: > > > > https://lore.kernel.org/linux-mm/20230111042214.907030-1-willy@infradead.org/ > > > > Mina Almasry already has done a lot fo prerequisite works by luck, he > > said :). I stacked my patches on the top of his work e.i. netmem. > > > > I focused on removing the page pool members in struct page this time, > > not moving the allocation code of page pool from net to mm. It can be > > done later if needed. > > > > There are still a lot of works to do, to remove the dependency on struct > > page in the network subsystem. I will continue to work on this after > > this base patchset is merged. > > > > This patchset is based on mm tree's mm-unstable branch. > > > > This series largely looks good to me, but a couple of things: > > - For deep changes like this to the page_pool, I think we need a > before/after run to Jesper's currently out-of-tree benchmark to see > any regressions: > https://lore.kernel.org/netdev/20250309084118.3080950-1-almasrymina@google.com/ Sure. I will check it. > - Also please CC Pavel on iterations related to netmem/net_iov, they > are reusing that in io_uring code for iouring rx rc as well. I will. Thank you. Byungchul > -- > Thanks, > Mina